Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756003AbXHAKio (ORCPT ); Wed, 1 Aug 2007 06:38:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763264AbXHAKid (ORCPT ); Wed, 1 Aug 2007 06:38:33 -0400 Received: from gepetto.dc.ltu.se ([130.240.42.40]:50033 "EHLO gepetto.dc.ltu.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763208AbXHAKib (ORCPT ); Wed, 1 Aug 2007 06:38:31 -0400 Message-ID: <46B062AF.1040907@student.ltu.se> Date: Wed, 01 Aug 2007 12:38:39 +0200 From: Richard Knutsson User-Agent: Thunderbird 1.5.0.12 (X11/20070719) MIME-Version: 1.0 To: Mike Frysinger CC: Robin Getz , Yoann Padioleau , David Howells , kernel-janitors@vger.kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/68] 0 -> NULL, for arch/frv References: <200707270944.LAA17167@ifs.emn.fr> <22618.1185531297@redhat.com> <87lkd29mk9.fsf@wanadoo.fr> <200707272138.23323.rgetz@blackfin.uclinux.org> <8bd0f97a0707271837q5d5f31d9pe342e72ebf9368c1@mail.gmail.com> <46AF255A.4050106@student.ltu.se> <8bd0f97a0708010303j7f443b06lf9d77f6d36816237@mail.gmail.com> In-Reply-To: <8bd0f97a0708010303j7f443b06lf9d77f6d36816237@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1701 Lines: 41 Mike Frysinger wrote: > On 7/31/07, Richard Knutsson wrote: > >> Mike Frysinger wrote: >> >>> On 7/27/07, Robin Getz wrote: >>> >>>> If there is a definite style or semantic preference that everyone should live >>>> with - does it make sense to put checks in checkpatch.pl to enforce it? >>>> >>> checkpatch.pl does not have enough semantic knowledge to know if the >>> thing being tested is a pointer ... dont know if the sparse utility >>> would be able to pick it out as i'm not familiar with what level that >>> thing runs at >>> >> Didn't he mean "x == NULL" > "!x"? >> > > i'm sure i understand your meaning of ">" ... are you saying that "x > == NULL" is greater (preferred) to "!x" or are you saying that "x == > NULL" should be changed to "!x" ? > If I understood Robin correctly, he suggested that checkpatch.pl would tell to convert "x == NULL" to "!x", if that would be the preferred way. > i dont think the former case can be checked by checkpatch.pl, but the > latter certainly can ... but i'd be very skeptical you could get the > wider LKML audience to sign off one way or the other wrt to "x == > NULL" vs "!x". you can certainly get people to sign off on "x == 0" > being wrong when x is a pointer. > I agree! BTW, too bad checkpatch.pl does not know the types, since it otherwise could check for the "x [=!]= 0"-thing. Richard Knutsson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/