Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Oct 2022 16:42:00 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Rik van Riel <riel@surriel.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        kernel-team@meta.com, Andrew Morton <akpm@linux-foundation.org>,
        David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH] mm,madvise,hugetlb: fix unexpected data loss with
 MADV_DONTNEED on hugetlbfs
Message-ID: <Y1MuSFgBkPZmLu7o@monkey>
References: <20221021154546.57df96db@imladris.surriel.com>
 <Y1MFjnDBOzpCW/9Z@monkey>
 <e0fc94ec3e6e088ad26d1b2ba7a1e9dfb4fb8079.camel@surriel.com>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <e0fc94ec3e6e088ad26d1b2ba7a1e9dfb4fb8079.camel@surriel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?FPi5GbRwM3AN34YcLQYCa1uOYMJT60UoaTqHr5UytC5KrBe2k0y/+3KEtT?=
 =?iso-8859-1?Q?MDzHiJqPo7a9b12khBzTomcTFV1TykNQk9FR+MxccmudD0zoreG4mnfnsi?=
 =?iso-8859-1?Q?EJdy+fUJrWhQ+w6Rflxp+saxQBwoSE5mHg2GkvGUZs2pIFXLatY2fqHtdc?=
 =?iso-8859-1?Q?vIfOFa0g0EdioYAw1u/Ne0d8Bhe9sy8ZUpI/XYPe11XW220KOnTmP9xkr4?=
 =?iso-8859-1?Q?6rtPJ0OqpaRSy3taIXLW+n4Q+g9dUlzfBsctmeQGAIDoMHCfQF90ZRRp7n?=
 =?iso-8859-1?Q?zmsPA7fMB156e4iFfYaUSRkA/fFj+RKyu0fuIF8A2Aizb9ndarKCLSZTBd?=
 =?iso-8859-1?Q?DKD37Xi0IPph8Grm2TI//aIX2D0vTqFV4Eu9VympGk3ec+8XS7Xz4v/lQx?=
 =?iso-8859-1?Q?CcwCgfGupJm7uW2ME/letNorT/fkeB3OxyYFkg/ta0+K9dyx/VEMXg69VL?=
 =?iso-8859-1?Q?ilrbnuDuD22GPOBXWVj9mTDC8ZSX4h624y+Pr1sjh0cZGruXIkY0I8KBbg?=
 =?iso-8859-1?Q?qNh4nOUBHmpiXXHpFBJWE5HJOlZ+BrZjDDyvLaoBfAm0WGIfEg9ocIT/SP?=
 =?iso-8859-1?Q?Apyf1YpUg5X5vHY2mWMBt5xd4M06j/h9qFCTUMnezEHZsEN41UhxL4jZS3?=
 =?iso-8859-1?Q?NpNynAnbqMwkPRHbhasIHl02fGq8LZM7W3GRXnK6CLBTP/LHkCqKftwFWj?=
 =?iso-8859-1?Q?MosXOyvf32o+ZUlHfMxT1Mn2XZ+kaldyJhI5qHNXYb/AgdxPyxQgQY36HP?=
 =?iso-8859-1?Q?X4P2juuqQexVHYJWCfrwBkaOpw9cFxFs0eH3G8onhXMiudFJTWxfzAUA2p?=
 =?iso-8859-1?Q?5ahwQE05+MN3RX7q6f8tcK8qTsFfdh8d1cXTCFpDHkFnv8cr8KaFuYuy8q?=
 =?iso-8859-1?Q?ROOg4Wzv8aTDKzSZSyq0mTm2O9FJ7WG7rnUopDXbIVjOqLsgst7KNw0QoR?=
 =?iso-8859-1?Q?GPg+Z53SF4Wy5SRExygmk/PJGjUraRArPKemi6kOfWMFBisAfefu2TtPc2?=
 =?iso-8859-1?Q?XLahe0jrq7HQ/uQL4Bgup7gRv9uhFb0zxgt4cjZ4nQHppr5Ji6wqkZTUNx?=
 =?iso-8859-1?Q?8VU0vG7f48ISQZ9ckNzgWHzBizOOCJsQ/Q4tL5EtLZdkJG9rSyAO+4Topp?=
 =?iso-8859-1?Q?GUnOEyuejZmggrc6iTG4XZ6CLTq8VP2OWl8aXgA5OfKS36sraC0phv4jXs?=
 =?iso-8859-1?Q?rqqJMgE8CrTAg7a1UJA1GmL8nOlg6JFre8cCWenf4OeBGVWuCuSKzSsmQh?=
 =?iso-8859-1?Q?X2wkrV4fK4sSw51QMw1kGLGMKnyhj03Fr9cc8JOSCtyeb9xL2htbdHAkEa?=
 =?iso-8859-1?Q?FWZ4edmD9c7wJ82k8WnRpO4vHL3xNePjEvlNGfvfWa2o0oM7Gj4ERRU4+l?=
 =?iso-8859-1?Q?w5YnMGL5j8envRckZgLb6FYHvtM5a9XWEJhAehHztMXlqzHTJ/tCqOIpb9?=
 =?iso-8859-1?Q?Wa9CSMIbrLIEYwPRP99FYwLSxnF+AIsZenyqul9UJYiSleiTycGAIg/RVV?=
 =?iso-8859-1?Q?EzA5yEm1NC6+GfTFS6KCkNRm9Vtx8XSw4a80PmwdLJNMicybzVzZ77U/n2?=
 =?iso-8859-1?Q?1BO/S+YKG/fr+BFVYGXycNXnrPNxAj1CK6YnoKAm/4ORzPgz4yjHnPCrTA?=
 =?iso-8859-1?Q?7nyx1bC2kIAOpJB1mCSXCVZs7PS0h9WobAgjx2iKIJlopn7UsoRI6Mgw?=
 =?iso-8859-1?Q?=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69b4b6e9-5156-45ae-5a13-08dab3bddaf8
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 23:42:03.1182
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rxSyASFiKfVbl4Ok1EBC3y+JKUD3NXWYSz5mvuI6zDt2k4RzOZrcdCocrjoORgdyXznvh7Z8qRjeBMvIzHR1NQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4899
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-21_04,2022-10-21_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 adultscore=0 mlxscore=0
 spamscore=0 bulkscore=0 malwarescore=0 mlxlogscore=820 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210210138
X-Proofpoint-ORIG-GUID: hXAxE3WOTGGueziMGKciDxqB5xqHFL9u
X-Proofpoint-GUID: hXAxE3WOTGGueziMGKciDxqB5xqHFL9u
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/21/22 19:29, Rik van Riel wrote:
> On Fri, 2022-10-21 at 13:48 -0700, Mike Kravetz wrote:
> > On 10/21/22 15:45, Rik van Riel wrote:
> > > A common use case for hugetlbfs is for the application to create
> > > memory pools backed by huge pages, which then get handed over to
> > > some malloc library (eg. jemalloc) for further management.
> > > 
> > > That malloc library may be doing MADV_DONTNEED calls on memory
> > > that is no longer needed, expecting those calls to happen on
> > > PAGE_SIZE boundaries.
> > > 
> > 
> > Thanks Rik.? I tend to agree with this direction as it is 'breaking'
> > current code.? David and I discussed this in this thread,
> > https://lore.kernel.org/linux-mm/356a4b9a-1f56-ae06-b211-bd32fc93ecda@redhat.com/
> > 
> > One thing to note is that there was not any documentation saying
> > madvise would happen on page boundaries.? The system call takes a
> > length and rounds up to page size.? However, the man page explicitly
> > said it operates on a byte range.? Certainly mm people and others
> > know we only operate on pages.? But, that is not what was documented.
> > 
> > When the change was made to add hugetlb support, the decision was
> > made
> > to round up the range to hugetlb page boundaries in hugetlb vmas.?
> > This
> > was to be consistent with how madvise operated on base pages.? At the
> > same time, madvise documentation was updated say it operates on page
> > boundaries as well as the behavior for hugetlb mappings.? If moving
> > forward with this change we will need to update the man page.
> 
> I'll send in a patch for the man page after the patch gets
> merged. I'll change the text to clarify that the system
> may round up the specified length to PAGE_SIZE granularity,
> which is a quantity programs can get through (IIRC) getconf.

Ok, the man page now says madvise only operates on page granularity.
Perhaps we can add info about using sysconf(PAGE_SIZE) if that will
help.  What will really need to be changed is the description of
rounding hugetlb mappings up to the next huge page size boundary.
Just need to describe the hugetlb behavior.  Unfortunately, we may
need to define/describe the arithmetic:
	ALIGN_DOWN(PAGE_ALIGN(length))
i.e. Will align down except in the case length is within PAGE_SIZE
     of hugetlb page size.
-- 
Mike Kravetz