Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b2de197c-0c5b-c815-23c8-3f90c2e226ed@talpey.com>
Date:   Fri, 21 Oct 2022 20:34:51 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [Patch v8 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure
 Network Adapter
To:     Long Li <longli@microsoft.com>,
        Bernard Metzler <BMT@zurich.ibm.com>,
        KY Srinivasan <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Leon Romanovsky <leon@kernel.org>,
        "edumazet@google.com" <edumazet@google.com>,
        "shiraz.saleem@intel.com" <shiraz.saleem@intel.com>,
        Ajay Sharma <sharmaajay@microsoft.com>
Cc:     "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
References: <1666218252-32191-1-git-send-email-longli@linuxonhyperv.com>
 <1666218252-32191-13-git-send-email-longli@linuxonhyperv.com>
 <SA0PR15MB39198F9538CBDC8A88D63DF0992A9@SA0PR15MB3919.namprd15.prod.outlook.com>
 <PH7PR21MB3263D4CFF3B0AAB0C4FAE5D5CE2A9@PH7PR21MB3263.namprd21.prod.outlook.com>
 <9af99f89-8f1d-b83f-6e77-4e411223f412@talpey.com>
 <SA0PR15MB3919DE8DE2C407D8E8A07E1F992D9@SA0PR15MB3919.namprd15.prod.outlook.com>
 <PH7PR21MB3263A40A380B9D7F00F02529CE2D9@PH7PR21MB3263.namprd21.prod.outlook.com>
Content-Language: en-US
From:   Tom Talpey <tom@talpey.com>
In-Reply-To: <PH7PR21MB3263A40A380B9D7F00F02529CE2D9@PH7PR21MB3263.namprd21.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dm9GU2ZNWjIrd2ZwVTdLOFkzazRiVzhtNE51T1I1Q1BwcDArSTh1U2VKT0JJ?=
 =?utf-8?B?Q3ovV1FydnhrMDdJUzg3MDNaSGlSNDZSczJ0MnJ5bGREb09MOHhsV3Fvdklj?=
 =?utf-8?B?Q2JBM0tEVzU4VEFza2pkVElZcDVSdGcxNDF0YWthNTM5ZTVtVVBsUi9lM2NK?=
 =?utf-8?B?ZW1zUmZGYjZtSXIzbmVadTVMYXNvQkRCWk5tQ1FIQ2JndlJkYnFsSngzeTJF?=
 =?utf-8?B?L29wS0tzNTM1OTdNUGRTZ2NKdDhLUmN6UDZObFNkM3B4RkhhOTdyaWpmMGov?=
 =?utf-8?B?VDcwbmFmQkd6N01iWGFZSW9CTEJkUUpyUVA5UUdaOEdvY3dBMGRRcGxvWlZk?=
 =?utf-8?B?V2FNNTNsZlNEdmtXejZmOXIzaUVKQzZVaUdLUlc0MklwSjJyTmg0MWJxVnRG?=
 =?utf-8?B?ZnFFdlRMb3RML0xYWnd2cThGT2NiZ3o5ZnRPSFFsVmNtUXIvNmdHOUNXaDli?=
 =?utf-8?B?Z1NoQjJ6WW5ydGFDN0ZZMFhHQzRHNytxOFZMTUV6S04zUEtCU2w0aGdacjlE?=
 =?utf-8?B?ZGphZkRDWjRNeGhKWVN0Qnp1bkoxYzlUbDc0S1c5T3FmbkcyZFhGMEJraWcx?=
 =?utf-8?B?akxHTjQyQWJlOHpzK3JCVzJ3bHZURktUb3B2UnZyU2JDcW5weEhUeFk1MTBi?=
 =?utf-8?B?eXh6NGtsTWgrY00rdTRhT1h5b0I5a21CMGY1SzBkZlgyNk5sU1BxT2RmR1A3?=
 =?utf-8?B?Z2RISzE5Q0tnRDhvdVhEVzAyblBLajlxM0FDMFNtNEhPanh6QmRJK1F4d2xC?=
 =?utf-8?B?QVZnczZWa2d4SUM5VWh0eFFRaTB0ODhxVnR1K0YwRDRIbFdvTXRncVRiV1lC?=
 =?utf-8?B?U2VmZ0ZVbmwxNW5vazFrc3hNT3FrVzg5Ly9zWTljeW90Y2ZMckNveFRQa3BQ?=
 =?utf-8?B?TU9PbFE0UTN5QVdidjBqR0g0Vnp0QVZYMUFKc3o4eVdNUkp6YzRtOTBkVWFw?=
 =?utf-8?B?Q3FhTXkycTdwUU9qN05VelY5MjgxWlEyVmxsMzNobkdOZWxsZGxwMDZjamM0?=
 =?utf-8?B?TjE0SkJBdTFXajBZSGRkV21ydmZvUWJZYkFmRnB1RHNUdHdUSzJRYXBIblFt?=
 =?utf-8?B?OU9nN1YyVVJnSWVwUTNMdTJRVHNMeUVGVmk1cEJlaTM3L3FGY05kY3Yxa3d4?=
 =?utf-8?B?Z3RxUnpnQ00zUVhvT1RJMHhqYUI1ays0L1Jtc3IvNitSeTFZTnRtekJtNnpD?=
 =?utf-8?B?QXU0RG5ZbnlZRDRqd3RjMzZ0cXVBRmwzKzZLNkIwcS9qQ245YkNOY2ZjN3Vm?=
 =?utf-8?B?TEh5YUR1VmcycTlWWkUxOHc2RzQrVmdGa3lCT0s3LzdJWmpkVTVkQ2dJZDM0?=
 =?utf-8?B?QzViVDMwdWlHNm1sNysvbjQ1eVpuZW9GMUUyQWZxUmtiSzBYNlR5bHJqUTJP?=
 =?utf-8?B?NVU1Z21aNHEzV1VnK1VVbG5rUGlwd21RMkl2KzBEUkw5RURLYWIzZVJDQ1R5?=
 =?utf-8?B?Q0NzNmhUQ2pBSG5PQlkySlJLcnNzTWlYUGZldVdvZ21meEFBYlFxNVNMdFda?=
 =?utf-8?B?TnYvQzZjbXhRS2UwVExac0V1WnQ5V1ovTlJrekZPd0FXOTFKYjhhK2NiNkM4?=
 =?utf-8?B?UXMxYUhWVEc0eEo3T3FOcWFNa21BTHdlQVJ6QjVZbHdsandONHk1UUV4Tjgy?=
 =?utf-8?B?VSsvNXYvRldrczVaSk8xaFA5bVM2TEtWOWhhaFVnTXg5b1R6eFkyK3R6RFJH?=
 =?utf-8?B?a0tkNkw2T3IyMTBnNis4N00rU1B4OER2UFhPRldkR0VMZUNReXFkalBHOVFt?=
 =?utf-8?B?UERjRHlHYjJqNGRpem5kbTB5OFJOQ1Nuc2J3ZXM0dFVvSTRCRDZhTVB5b2RE?=
 =?utf-8?B?SHB2NGxQdGE2L2VtcnBLVU9Ub1NxeStVSG5XcXFtbEZYb0E5QzlEc3ZuejRm?=
 =?utf-8?B?MGNXckdXb0hmRmFZSnpsWWRILy94MjVydHhic0xnc1djWE5YN3RJK0lUbnp5?=
 =?utf-8?B?MWEzaEp2amJEUHA5VW5tNzdON3hieVpZemFLZ0tWc0JvclZCNzhxQnZtSmZu?=
 =?utf-8?B?S1VTR2dmdGtRaWI2NFBqRjN5QkZvMnd5YWRBRDJaR1VJczlJNmJFeXVyZkN3?=
 =?utf-8?B?RWNTRlBHdHhraXZYeUErbkpDdjZWTEtWWGNBRmltWEVxUUFYQUNoVDFuK3NP?=
 =?utf-8?Q?t5T8=3D?=
X-OriginatorOrg: talpey.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a889af5-6979-47d6-b6ab-08dab3c53a48
X-MS-Exchange-CrossTenant-AuthSource: BL0PR01MB4434.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2022 00:34:49.5838
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 2b2dcae7-2555-4add-bc80-48756da031d5
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: abHS8mcOvzndnenzLDjqo9amJ5g2BNwp7eNy8703ksN5+XPm/r02ZVjUJ6qftMmT
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR01MB2170
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/21/2022 6:55 PM, Long Li wrote:
>>> The upper 8 bits of an ib_mr remote token are reserved for use as a
>>> rotating key, this allows a consumer to more safely reuse an ib_mr
>>> without having to overallocate large region pools.
>>>
>>> Tom.
>>
>> Right, my point was that one cannot encode INT_MAX different MR
>> identifiers into 32 - 8 = 24 bits.
>>
>> Best,
>> Bernard.
> 
> The hardware exposes the number of MRs that exceeds UINT32_MAX.
> There is no software stack limit from hardware perspective.
> 
> In this case, maybe it's a good idea to set it to 0xFFFFFF. I'm making the change.

Actually, 2^24 MRs is enormous in itself. Does this driver
actually support that many? Without falling over?

Tom.