Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     John Garry <john.garry@huawei.com>
Cc:     <jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
        <jinpu.wang@cloud.ionos.com>, <damien.lemoal@wdc.com>,
        <hare@suse.de>, <linux-scsi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>,
        <ipylypiv@google.com>, <changyuanl@google.com>
Subject: Re: [PATCH v4 0/7] scsi: libsas: Use request tag in more drivers
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1mt9owodi.fsf@ca-mkp.ca.oracle.com>
References: <1666091763-11023-1-git-send-email-john.garry@huawei.com>
Date:   Fri, 21 Oct 2022 23:05:00 -0400
In-Reply-To: <1666091763-11023-1-git-send-email-john.garry@huawei.com> (John
        Garry's message of "Tue, 18 Oct 2022 19:15:56 +0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1fpbawOE52zgOi3JnxuY4Nwofr3Azv4W5U5n12sDvH9MQW9h6opumR71yf/Z?=
 =?us-ascii?Q?Qbe/4l4YyS1UTbp3SFV4LyPKCP7ZLrFuMO87KUQ3Ua2i86BVb14M6UFd2I8e?=
 =?us-ascii?Q?8BHbMJFEwkIJiCRQKJOBEKE436Q0sQdDmxQxERT0+2oeU8EyavB2D1xh7HPw?=
 =?us-ascii?Q?+wRdseS6pNd1+gvLXwDHVFKEd6Do+7r2QvxcoBX2cNXFvADzpVsDXFduNjrg?=
 =?us-ascii?Q?h/5Mp6re2D9GFFzwxO6Vy/EvaEtj2giQjrGfKpYx7bDfWZif3ZvsBYlLqwg6?=
 =?us-ascii?Q?gODiHmQS2MgJuwFfo3EGWip1TIeHgCC25SmbjKkjKYrMx7qUZb5tIay1L3eg?=
 =?us-ascii?Q?ORZjL03DrTFq15956dxq53Fu4k2eRkW9Iwto1Lf11DyqxKkwVvgePg7o/+yZ?=
 =?us-ascii?Q?MkddWmMrUY+osyg57GhfOAGKyXB7G4pkHp4N5RcVok5QMVLOguDgXZJjSJks?=
 =?us-ascii?Q?tUYLzgrVqzvknFqRl2uo0Z6uwlS4qI6PIT/zDu35i9iRgoW2r545TboJCSTi?=
 =?us-ascii?Q?/A5ETiSNtUiOy5Va4s4OzrhcI3fb/gB0Nefevh3CYe2guX1QK/Hz+45iIAgd?=
 =?us-ascii?Q?4+lOOsostXIBFwT6gK7yLT+WGGjsE3dj971tFgsqeGlowGLavYBPkO/xOmp7?=
 =?us-ascii?Q?/n+6VVhNdTiP1jv2MJ1Mhukd2QyaAmQ8FuIzxP4QuUOChueqe+qnIEsvsV3A?=
 =?us-ascii?Q?QnQS0RHG+Y9qBFFC8IoNkv8PBCo6pMzcvc+UDSIv5gXlxnUJgBWGctSU3yDk?=
 =?us-ascii?Q?wRwYVwlBu5rQI2xRywjdp//Bj+3WU05bwAnrPl1rSzjbcVD9eG+LgwH6P7Hn?=
 =?us-ascii?Q?nX0nS46vpK5yRvp9u7OruJs7WUSZRCJDMe4XNGHy0+l5SF4q23+EyEUIMvek?=
 =?us-ascii?Q?lqOoe01tos4Vc8FB/LqV0+ak2VXU+rHE+FpQ4v+p0fm7k8pF+cGWOQslcTbK?=
 =?us-ascii?Q?yhEmanpbogEVUIfqmxl16ki0Gbfis7Rg46FYomFXlnZUWjXWGt9woMdtVy9n?=
 =?us-ascii?Q?v3/PagqM9IRga05j6JB3ZZklrwgFTH0HHOXt57EciRxh8uBb9yY+ZIy2V2Mp?=
 =?us-ascii?Q?uPUTKNGMmcFmi1Uw6VueqNpXRwHP5qvmA/YWHMBdKYvk4dtIs3guTn2tFNgr?=
 =?us-ascii?Q?2dx7Eabm6XJangm0T1aGzAf5wRoug14qEYCZHav0RkJKaRpGBtMG0TkUqOnq?=
 =?us-ascii?Q?1GjKuN3TGiwnwthRHT+/Eh1Am2jtxgbQk4rjRJ2VsdiPV0wSf+LSWvfKE8vs?=
 =?us-ascii?Q?kuUzIJwSuafp8CQg7QcX0yQS3xuQCdejphGTU6Kf52BRD8BuPuPgp7hIR3CO?=
 =?us-ascii?Q?4RauMptlmxlL+KW9Nv5zUEwecmLeacd5lyfGmqQi2/ewkNuTsqTbetSqmtxN?=
 =?us-ascii?Q?mTPFUm9gOah6nCNgs9PCYBpDDXqduu2A9qO2+UznX+hWb46N9RJ4xJMtLMv5?=
 =?us-ascii?Q?cfOgoZWMjSpN14Lu2E3ZsgOln6Uw8nLzEt0zWIuzSD0b0uDYr4cVPxW7AYys?=
 =?us-ascii?Q?EBaNkiOXTNVi16JKc+UUkeR/98OJC6+dBlzsgWgYUskznvZwFwuRdNizQj00?=
 =?us-ascii?Q?645G9Xzy9xs8pWnkNeT7YMnkUiOTsb7a/ILSHnaq5bGRq96Oe2mwFot/sz0H?=
 =?us-ascii?Q?rA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2b088a4f-5a01-41fc-6e8b-08dab3da3651
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2022 03:05:02.3469
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 77DyGBfGeoO/kPG1TjhjWeXJFVDyNEqa8dulhxh50WJu4AflegzKT6ocVy+92KcnyDRv7HItjKY/5RaqXyp4PlQohuM6NWSDQJIltjfIfpg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB6189
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-21_04,2022-10-21_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0
 mlxlogscore=738 malwarescore=0 spamscore=0 bulkscore=0 mlxscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210220017
X-Proofpoint-GUID: Cd4i_ME8SGJORTjUHhyBN-ssJQbRnpXr
X-Proofpoint-ORIG-GUID: Cd4i_ME8SGJORTjUHhyBN-ssJQbRnpXr
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


John,

> All other libsas drivers manage the tags internally. Tag management in
> pm8001 and mvsas is currently using a simple bitmap, so use the
> request tag when available there. With this change we still need to
> manage tags for libsas "internal" commands, like SMP commands, and any
> other private commands so reserve some tags for this:

> - For pm8001 I went with pre-existing and unused PM8001_RESERVE_SLOT
>   size.  The value is 8, which should be enough. It is greater than
>   mvsas, below, but this driver sends a lot of other private commands to
>   HW.
> - For mvsas I went with 4, which still should be enough.
>
> isci and aic9xx have elaborate tag alloc schemes, so I'm not going to
> bother changing them, especially since I have no HW to test with.
>
> Helper sas_task_find_rq() is added to get the request and associated
> tag per sas_task when it is available.

Applied to 6.2/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering