Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <106d4377-1ba6-7970-b930-de3d766f3dd9@huawei.com>
Date:   Sat, 22 Oct 2022 10:52:05 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.1
Subject: Re: [PATCH] scsi: sd: Update dix config everytime sd_revalidate_disk
 is called
Content-Language: en-CA
To:     "Martin K. Petersen" <martin.petersen@oracle.com>
CC:     <jejb@linux.ibm.com>, <linux-scsi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>,
        <prime.zeng@hisilicon.com>, <kangfenglong@huawei.com>,
        <john.garry@huawei.com>
References: <20221019081825.20794-1-yangxingui@huawei.com>
 <yq1h6zzz740.fsf@ca-mkp.ca.oracle.com>
From:   yangxingui <yangxingui@huawei.com>
In-Reply-To: <yq1h6zzz740.fsf@ca-mkp.ca.oracle.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2022/10/20 8:18, Martin K. Petersen wrote:
> Xingui,
>
>> When the host protection capabilities are 0x77 and a DIF disk is
>> connected, the DIX and DIF of the disk are default enabled. Then if
>> that DIF disk is reformatted as a non-DIF format, per the currently
>> flow, the DIX is kept enabled which is not correct
> DIX is orthogonal to DIF and a host property. DIX should not be disabled
> just because the disk is no longer formatted with protection
> information.

As the host protection capabilities are 0x77 and not support DIX between 
OS and HBA only.

If write command is delivered to a non-DIF disk with DIX format this 
time, I/Os will be failed.

DIX status should  be updated when the disk DIF type changes.

>
> That said, your patch is probably fine. I'll take a closer look
> tomorrow.

ok, thanks.

Xingui

>