Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp3912505rwi; Sat, 22 Oct 2022 02:05:07 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7j9vlemkPUsY+4LOWxaUdwHgAKVNZzesfF/+BJpiR5Mbo5CqwI06ILqjSYbmrrn8I64ZYh X-Received: by 2002:a17:902:bf46:b0:179:eba5:90ba with SMTP id u6-20020a170902bf4600b00179eba590bamr23394932pls.16.1666429506998; Sat, 22 Oct 2022 02:05:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666429506; cv=none; d=google.com; s=arc-20160816; b=wjQqeu9hw/y3z4EacQ5tpGzkMbiIiYNMAfsxcSUhadJf+//qo4KGoCDfjAVyrHljBm vFX3nksm9XVYvzBHEj3MxrHD6QUW6QHVpJmzsjAqhE3XeT6432TomjCfy+tTpgfwNh3D n0sg7Qd+zZFbq2vwHOTJYk/05iy+WnRfX08qkxZQKz/NtmD+0oV4h6xL5DRDGiZttyzq b1fbolsFfIWfb172eSoCZTLNXOG1qrOTmBTjS0o6O+dTGiISTAUuc/R+SXdduqCRH4LY uUShM4MMDDW1/jTa+hYsW8G5r2RUnrbW4H3Z5gkQz1v3/JvB1KaCtjsFfh9l0fsxnfpP wkvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=9NV/ihc0Uh1gmyJpr61Y3yKDSmVXX5AfKL+sPrj3NMw=; b=xW1dFKYdxgTi+9DkjLze26EJBG75Y2iEAan1ax/0AAvn2sWzerWIMmNZcAqdj89Rrh Jj9UxQYEhjLau9yXDweqJ/6xRxJUtNw69u87fQuB7iGLddddc/d+nA0kmrrfcxAw/EWs pTISVhzXwJpI6xrNsY2RSYiGcz6NmBY2jxunYY1NBQ1OagKHSmhmz+rXHD/rsvywqUcQ 6nFgDBZDASZCfZiZnYPqdYx4tCBrUu24uPxJFvNL6dgUO+6iMCPhoHT0kbtoc6AbrkOM Ov+WmKGuGl5ExwqNb+FJp7yPskqpZ9K9wY+zdgDOiox26noPTo5mYmgESr3U2BLI2wCk e8rQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mzblqz1c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l69-20020a638848000000b00463cdd82176si26009902pgd.184.2022.10.22.02.04.54; Sat, 22 Oct 2022 02:05:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mzblqz1c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231916AbiJVHve (ORCPT + 99 others); Sat, 22 Oct 2022 03:51:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231565AbiJVHsl (ORCPT ); Sat, 22 Oct 2022 03:48:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C93C199F6B; Sat, 22 Oct 2022 00:45:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D0D0660B90; Sat, 22 Oct 2022 07:41:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB3E9C433C1; Sat, 22 Oct 2022 07:41:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666424469; bh=BMhRM4nqWbjmRpKYBjSHNb+WOA6zO/H96SN3tqK7YGs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mzblqz1cmdf6/pW4s7ZSdzBrX2jRSMu7u5ZmQN2EXgK7nZM0Js6CoK1oxt8PPUWAv oMpAH2J3uIb0uLTAaOiuKvqyY3fottfxNRKckoq8gx1loxI3b6bAO92Qn1ahpaguhE BNvtZ8LWFTMI9cVrCrL2XBIkzSXSfjORL1Q9OTug= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nicolas Dufresne , Dmitry Osipenko , Hans Verkuil , Mauro Carvalho Chehab Subject: [PATCH 5.19 157/717] media: cedrus: Fix endless loop in cedrus_h265_skip_bits() Date: Sat, 22 Oct 2022 09:20:36 +0200 Message-Id: <20221022072443.234474692@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221022072415.034382448@linuxfoundation.org> References: <20221022072415.034382448@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dmitry Osipenko commit 91db7a3fc7fe670cf1770a398a43bb4a1f776bf1 upstream. The busy status bit may never de-assert if number of programmed skip bits is incorrect, resulting in a kernel hang because the bit is polled endlessly in the code. Fix it by adding timeout for the bit-polling. This problem is reproducible by setting the data_bit_offset field of the HEVC slice params to a wrong value by userspace. Cc: stable@vger.kernel.org Fixes: 7678c5462680 (media: cedrus: Fix decoding for some HEVC videos) Reported-by: Nicolas Dufresne Signed-off-by: Dmitry Osipenko Signed-off-by: Nicolas Dufresne Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/staging/media/sunxi/cedrus/cedrus_h265.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/drivers/staging/media/sunxi/cedrus/cedrus_h265.c +++ b/drivers/staging/media/sunxi/cedrus/cedrus_h265.c @@ -234,8 +234,9 @@ static void cedrus_h265_skip_bits(struct cedrus_write(dev, VE_DEC_H265_TRIGGER, VE_DEC_H265_TRIGGER_FLUSH_BITS | VE_DEC_H265_TRIGGER_TYPE_N_BITS(tmp)); - while (cedrus_read(dev, VE_DEC_H265_STATUS) & VE_DEC_H265_STATUS_VLD_BUSY) - udelay(1); + + if (cedrus_wait_for(dev, VE_DEC_H265_STATUS, VE_DEC_H265_STATUS_VLD_BUSY)) + dev_err_ratelimited(dev->dev, "timed out waiting to skip bits\n"); count += tmp; }