Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp3932073rwi; Sat, 22 Oct 2022 02:26:34 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7tZqfn1/8IpMH0jypk3Y7cfPOK2XJZutk0dC/Lv7k0uZIJV49cCozAU6hPG58Bp6m1C56J X-Received: by 2002:a17:907:1623:b0:78d:9e8b:171d with SMTP id hb35-20020a170907162300b0078d9e8b171dmr19122205ejc.309.1666430784052; Sat, 22 Oct 2022 02:26:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666430784; cv=none; d=google.com; s=arc-20160816; b=Laonb3cCLZTOh9s8YTVRRD/JtjNj1GPxh3+CRwzwhcGrDmRKdm4gcaT0nhNAp5AgnH zqahdhrX9nJMnDktFEtPSparJa3Lk7NseeP2pq2SKgluO87vSioT1TH8sNT/xVxXxnua sDODjh2UzAvRVDCegNhaZCGJ2Yql4qN+3YV9PSzI0L7h1ETBQ2t/AqZXEpxZXYqDo2My YQZKUx3OI4bSsjasD4D0zaQHDPnJ47Bm239b4z2Sn79oNWUgqlebrSen5hil+PIp6TI7 EE40N83hBE7zoUqjj4I6C7LCNd3VJgmc/q/d1wTgIoKVfc5hVatlAySs2Nrr3JbYvPK0 FCoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=03jgGr6HwFQAtS5OxGZuj5lNrcCdb/ggv6vvWFUZ4Gc=; b=x9893qPTPgdOUDIvWvnfdNEGcfbSnbBb/TzyWt8Pw6QTwzoaPR2tSEP7IrzXNfaKZA JSdmuSpzMFMOJ8DA5IB0IS33zl9nTybCehwKzIx+cxi1j2nymPL9vzyzTEASn8L50A8u wXJdO2I2EQdTzvYqRTsJVJJcrgJymCG5fq2I7oOK9aYVklfO2JlLfENfbxg221cVTwQh TUrPT7ulWwMeGLd4k+TdbH70tmNE+tcnAu37UcIQJB1Dmz1fiFq/srV8dlOV+h+xD67V sfApY0ANK/sdAoCS9qGPxJiLVDZb2bgnBMfidLyQjiBzOBC2A6d9TimKJO7lJyMQlZe5 2sbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=uyenJxij; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b13-20020a056402084d00b0045c98bb5359si27982559edz.590.2022.10.22.02.25.59; Sat, 22 Oct 2022 02:26:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=uyenJxij; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230303AbiJVHg6 (ORCPT + 99 others); Sat, 22 Oct 2022 03:36:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230253AbiJVHg3 (ORCPT ); Sat, 22 Oct 2022 03:36:29 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52FF036DD5; Sat, 22 Oct 2022 00:35:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2A123B82DEF; Sat, 22 Oct 2022 07:35:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65988C433D6; Sat, 22 Oct 2022 07:35:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666424107; bh=8fi4KRnTeAjrn2RZpFpUaMqKpGr4C7VXsqZt/H77q6U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uyenJxijD2Whif/fKhAg65xur7rVaqr9O8y6TOVV4gtMCw9u++ckorYghGGbf8OH4 V87bU5MbMfhMHLHlP+JVTSm2pybgcjkM2WNi18WFyngwp/bFJKHEOGPtxulZ1LqU7B FHutiANflQ2GMW0s2azv3lwdoFPIVbt+iPca243s= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Takashi Iwai Subject: [PATCH 5.19 003/717] ALSA: rawmidi: Drop register_mutex in snd_rawmidi_free() Date: Sat, 22 Oct 2022 09:18:02 +0200 Message-Id: <20221022072415.630907767@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221022072415.034382448@linuxfoundation.org> References: <20221022072415.034382448@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Takashi Iwai commit a70aef7982b012e86dfd39fbb235e76a21ae778a upstream. The register_mutex taken around the dev_unregister callback call in snd_rawmidi_free() may potentially lead to a mutex deadlock, when OSS emulation and a hot unplug are involved. Since the mutex doesn't protect the actual race (as the registration itself is already protected by another means), let's drop it. Link: https://lore.kernel.org/r/CAB7eexJP7w1B0mVgDF0dQ+gWor7UdkiwPczmL7pn91xx8xpzOA@mail.gmail.com Cc: Link: https://lore.kernel.org/r/20221011070147.7611-1-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/core/rawmidi.c | 2 -- 1 file changed, 2 deletions(-) --- a/sound/core/rawmidi.c +++ b/sound/core/rawmidi.c @@ -1835,10 +1835,8 @@ static int snd_rawmidi_free(struct snd_r snd_info_free_entry(rmidi->proc_entry); rmidi->proc_entry = NULL; - mutex_lock(®ister_mutex); if (rmidi->ops && rmidi->ops->dev_unregister) rmidi->ops->dev_unregister(rmidi); - mutex_unlock(®ister_mutex); snd_rawmidi_free_substreams(&rmidi->streams[SNDRV_RAWMIDI_STREAM_INPUT]); snd_rawmidi_free_substreams(&rmidi->streams[SNDRV_RAWMIDI_STREAM_OUTPUT]);