Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221022070612.13009-1-tanjubrunostar0@gmail.com>
 <20221022070612.13009-6-tanjubrunostar0@gmail.com> <Y1Omg6Tfv/lc7Fu4@kroah.com>
In-Reply-To: <Y1Omg6Tfv/lc7Fu4@kroah.com>
From:   Tanju Brunostar <tanjubrunostar0@gmail.com>
Date:   Sat, 22 Oct 2022 09:29:22 +0100
Message-ID: <CAHJEyKWM0kRVkR_mHfUho6bdpb1eQ3eH6_W8ZAow4O=B9zWfbQ@mail.gmail.com>
Subject: Re: [PATCH v3 5/6] staging: vt6655: refactor long lines of code in
 the rest of the file
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        outreachy@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Oct 22, 2022 at 9:17 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Sat, Oct 22, 2022 at 07:06:11AM +0000, Tanjuate Brunostar wrote:
> > fix checkpatch errors by refactoring long lines of code in the rest of
> > the file
> >
> > Signed-off-by: Tanjuate Brunostar <tanjubrunostar0@gmail.com>
> > ---
> >  drivers/staging/vt6655/rxtx.c | 105 ++++++++++++++++++++++------------
> >  1 file changed, 67 insertions(+), 38 deletions(-)
> >
> > diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
> > index 951d4172e9f2..572be45cdbeb 100644
> > --- a/drivers/staging/vt6655/rxtx.c
> > +++ b/drivers/staging/vt6655/rxtx.c
> > @@ -1105,44 +1105,60 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType,
> >               if (byFBOption == AUTO_FB_NONE) {
> >                       if (bRTS) {/* RTS_need */
> >                               pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize);
> > -                             pMICHDR = (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts));
> > -                             pvRTS = (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts) + cbMICHDR);
> > +                             pMICHDR = (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize +
> > +                                        sizeof(struct vnt_rrv_time_rts));
> > +                             pvRTS = (void *)(pbyTxBufferAddr + wTxBufSize +
> > +                                              sizeof(struct vnt_rrv_time_rts) + cbMICHDR);
>
> Casting to void * is very odd.  Try working on fixing up that mess
> first...
>
> thanks,
>
> greg k-h
OK