Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v2] block: fix memory leak for elevator on add_disk
 failure
To:     Yu Kuai <yukuai1@huaweicloud.com>, axboe@kernel.dk, hch@lst.de,
        ming.lei@redhat.com
Cc:     linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        yukuai3@huawei.com, yi.zhang@huawei.com
References: <20221022021615.2756171-1-yukuai1@huaweicloud.com>
From:   Jason Yan <yanaijie@huaweicloud.com>
Message-ID: <8c22d055-6285-d5f6-1b83-8b08d39768b2@huaweicloud.com>
Date:   Sat, 22 Oct 2022 16:51:30 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20221022021615.2756171-1-yukuai1@huaweicloud.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2022/10/22 10:16, Yu Kuai wrote:
> From: Yu Kuai<yukuai3@huawei.com>
> 
> The default elevator is allocated in the beginning of device_add_disk(),
> however, it's not freed in the following error path.
> 
> Fixes: 50e34d78815e ("block: disable the elevator int del_gendisk")
> Signed-off-by: Yu Kuai<yukuai3@huawei.com>
> Reviewed-by: Christoph Hellwig<hch@lst.de>
> ---
> Changes in v2:
>   - fix wrong fix tag
>   - add review tag
> 
>   block/genhd.c | 12 ++++++++----
>   1 file changed, 8 insertions(+), 4 deletions(-)

Reviewed-by: Jason Yan <yanaijie@huawei.com>