Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 22 Oct 2022 12:52:11 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Florian Fainelli <f.fainelli@gmail.com>
Cc:     justinpopo6@gmail.com, alcooperx@gmail.com, balbi@kernel.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        bcm-kernel-feedback-list@broadcom.com, justin.chen@broadcom.com
Subject: Re: [PATCH] usb: bdc: change state when port disconnected
Message-ID: <Y1PLW2t7X9DHVd7I@kroah.com>
References: <1664997235-18198-1-git-send-email-justinpopo6@gmail.com>
 <Y0Gax8SUoq59hdoF@kroah.com>
 <f0706380-94f9-ed7d-1033-8da51aab6b01@gmail.com>
 <81528485-fa80-55ab-16ce-84de520f5262@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <81528485-fa80-55ab-16ce-84de520f5262@gmail.com>
Precedence: bulk

On Mon, Oct 17, 2022 at 02:05:42PM -0700, Florian Fainelli wrote:
> On 10/10/22 07:58, Florian Fainelli wrote:
> > 
> > 
> > On 10/8/2022 8:44 AM, Greg KH wrote:
> > > On Wed, Oct 05, 2022 at 12:13:55PM -0700, justinpopo6@gmail.com wrote:
> > > > From: Justin Chen <justinpopo6@gmail.com>
> > > > 
> > > > When port is connected and then disconnected, the state stays as
> > > > configured. Which is incorrect as the port is no longer configured,
> > > > but in a not attached state.
> > > > 
> > > > Signed-off-by: Justin Chen <justinpopo6@gmail.com>
> > > > ---
> > > > ? drivers/usb/gadget/udc/bdc/bdc_udc.c | 1 +
> > > > ? 1 file changed, 1 insertion(+)
> > > 
> > > What commit id does this fix?? Should it go to older kernels?? If so,
> > > how far back?
> > 
> > This would be:
> > 
> > Fixes: efed421a94e6 ("usb: gadget: Add UDC driver for Broadcom USB3.0
> > device controller IP BDC")
> > 
> > that issue was present since the driver was included in Linux with the
> > commit above, we did not really consider it to be a serious enough bug,
> > but I suppose it would not hurt to affix the said Fixes tag.
> 
> Greg, are you picking up the patch as-is, or do you need Justin to resusbmit
> with the Fixes: tag added?

Now merged, thanks.

greg k-h