Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     LKML <linux-kernel@vger.kernel.org>,
        linux-stable <stable@vger.kernel.org>,
        Anna Schumaker <Anna.Schumaker@Netapp.com>,
        Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 5.19 554/717] NFSD: Return nfserr_serverfault if splice_ok
 but buf->pages have data
Thread-Topic: [PATCH 5.19 554/717] NFSD: Return nfserr_serverfault if
 splice_ok but buf->pages have data
Thread-Index: AQHY5eyW2zD3eq+/T0GdaBrfEjzLgK4aflGA
Date:   Sat, 22 Oct 2022 14:46:35 +0000
Message-ID: <E22D29B2-5740-46E7-9A4A-52BAE214FDA1@oracle.com>
References: <20221022072415.034382448@linuxfoundation.org>
 <20221022072522.883630640@linuxfoundation.org>
In-Reply-To: <20221022072522.883630640@linuxfoundation.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0MM19o7G97B4Aegw89zDzcVo2wReuD8c6B2SvaKlZ/kkfrvVfXVZqetROG+j?=
 =?us-ascii?Q?O2NT5RnLPWUosi4JKyPP9fG67pVAce8YnlF41uk0Am0yayGqXhBv+a1gh0bC?=
 =?us-ascii?Q?r8+U1noNC3hpvzTkrEoyLPAeRQ3t9i1NhozNcEMm89E8GXoHOafitrRxKhOY?=
 =?us-ascii?Q?nimS0lFB1NkzkP+YdBpXYoejkVOVXFydVyVzIZIMNOUHLj4SXvyLEaBDlj/U?=
 =?us-ascii?Q?BswAM1N8oZzx8GbUntrGGs4AQ7FdFG+LXtFuOUAiGECwydkoMlFTw1TeemFT?=
 =?us-ascii?Q?FyyYU6CwY0m0+HDI9Ci4Z7sySYT8++KH+nhysZFaHEeXOyL0aUtTkOpBQ/1E?=
 =?us-ascii?Q?dlfcitu97f2KVia8nvQukxeJhMDLJlRaGHIWMijnXYMv11Q6TaDhErGjriTc?=
 =?us-ascii?Q?7xaN3d3GeE7yvKoQKObKiEG4qiqzg8HzkF+lEjMgD06CcHRR/E6C4jPkYo8p?=
 =?us-ascii?Q?SZXe0X7SMvZ7RvSRcpejn+Xsjj9UbJG7uLPwRtmn+jmrrVUXlHTwVaqzqQ9v?=
 =?us-ascii?Q?u/Uzj4dEIg72atIgppFHwlbiy/h82Xioj0gNo0N3H3ZeyO//WivJocb0+KwK?=
 =?us-ascii?Q?xV7BIF7zavKlKrTCWiIryilrkvcu1iiFdBBlK7KVab2H4zxpbiav2xnJfyj2?=
 =?us-ascii?Q?NHreiN81B+01qF3Y+6g97Qm1TVIXLR1eLDXOTFpixhkoSnCHnygdkdqZsT7C?=
 =?us-ascii?Q?Ea2YL+aqd54zUf8+94sSC5JBhzak3zfxJRS+3iSXa9VL96121cXaJ60ZEQxi?=
 =?us-ascii?Q?XVL6U2sNff8grzqAOLf3mzAearTxW7EpVZEhYSUA9tPfWqbgSTCgKn1YaUHU?=
 =?us-ascii?Q?PSBoNFrBXEjm+t2nq31hw/9TTVpRte6J1MCbLfWYJvZOqtmt9TvRDmSZQ0ZY?=
 =?us-ascii?Q?GzteKvyoYmaTAMlqrI+HKJ9OXos9QexJRDTlOIOem0Zj2EyseT2RS948XKUp?=
 =?us-ascii?Q?Ei3uJhcnNtHvQ8zWtn+A9DVjy1t07q5yD4yQC/VbShDaaqAxPPCG1Isz7oK2?=
 =?us-ascii?Q?uCfw/PFyPaTMcF4hv2iJEK70OmP2bMYnlcBGt/mgmxuzZ88+cf0JfIzQ6+lp?=
 =?us-ascii?Q?MbCP7M+SMhpy11Sd90tDAdWyv5VLQYTI5kLbTrKvI3LgNUbCKI7ZAAV+7rd9?=
 =?us-ascii?Q?dzhDyXv2hYQN3HYk8hf4E1UgMwluTQGidgUQp0hL91/rPI3Q9oNJC7IjSW8c?=
 =?us-ascii?Q?AxqZC6c6Xs+Qwp+bdmQyoXjvrcS+2unkJeOYl6DLrWTsDvfG7biZUiysu8vb?=
 =?us-ascii?Q?Ijmf+yug5bd2Az0D1Ql+fXxlM706tosmUi1a72l9uqdM5j4Fcwr92gOk62pY?=
 =?us-ascii?Q?NihFd0SrCWGT6QwF1gmgLJj/Z7Iut3OpZjOHJzvMXL7D8nS7f/AbsJJU948g?=
 =?us-ascii?Q?LoxE538J0nP/W1UcvwfxDy/AVZ8VsJpqjPIuV2F6sSqAU56XQXmFlH2HPGKr?=
 =?us-ascii?Q?4PXJBZqJfudJKbThhhF6Z7Vdx3BDU8TgommO5Fc19S7l8xpUICRJfDWr/bDF?=
 =?us-ascii?Q?WX49BB6oSf2IqLiy7PRgb3MnMw3IEuyE379JBErYJCVv/I3T2fUrKKEA6E0l?=
 =?us-ascii?Q?ApesX93xeMPNShwYPKCdwFMHBAOkY85huX7+qVe8Y1dZnXrZUOYD0jdXGcfY?=
 =?us-ascii?Q?ig=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <C8BC39C3AF54C241B78B0EED8653C5A8@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DS7PR10MB5134.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 974f2abc-e083-45a1-6253-08dab43c3818
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Oct 2022 14:46:35.8036
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mdauUmFa0YQ2N01QycxLTTiSA9VlY3x2y/N4FfJXzy2VTytlRcQOx2Rj9P+4xrZr3MxgTWLmzUHyfTPLXyhy6w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4122
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-21_04,2022-10-21_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 phishscore=0
 mlxlogscore=999 adultscore=0 malwarescore=0 spamscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210220092
X-Proofpoint-ORIG-GUID: StBV1simoDOO9r1LJmOru0IfuLybKsHI
X-Proofpoint-GUID: StBV1simoDOO9r1LJmOru0IfuLybKsHI
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Oct 22, 2022, at 3:27 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.o=
rg> wrote:
>=20
> From: Anna Schumaker <Anna.Schumaker@Netapp.com>
>=20
> [ Upstream commit 06981d560606ac48d61e5f4fff6738b925c93173 ]
>=20
> This was discussed with Chuck as part of this patch set. Returning
> nfserr_resource was decided to not be the best error message here, and
> he suggested changing to nfserr_serverfault instead.
>=20
> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
> Link: https://lore.kernel.org/linux-nfs/20220907195259.926736-1-anna@kern=
el.org/T/#t
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
> fs/nfsd/nfs4xdr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> index eef98e3f4ae5..1e5822d00043 100644
> --- a/fs/nfsd/nfs4xdr.c
> +++ b/fs/nfsd/nfs4xdr.c
> @@ -3995,7 +3995,7 @@ nfsd4_encode_read(struct nfsd4_compoundres *resp, _=
_be32 nfserr,
> 	if (resp->xdr->buf->page_len &&
> 	    test_bit(RQ_SPLICE_OK, &resp->rqstp->rq_flags)) {
> 		WARN_ON_ONCE(1);
> -		return nfserr_resource;
> +		return nfserr_serverfault;
> 	}
> 	xdr_commit_encode(xdr);

Why is this change to be included in stable kernels?


--
Chuck Lever