Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 22 Oct 2022 11:11:12 -0400
From:   William Breathitt Gray <wbg@kernel.org>
To:     William Breathitt Gray <william.gray@linaro.org>
Cc:     linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org,
        Kamel Bouhara <kamel.bouhara@bootlin.com>
Subject: Re: [PATCH v2] counter: microchip-tcb-capture: Handle Signal1 read
 and Synapse
Message-ID: <Y1QIEPBaYFcjtw+7@ishi>
References: <20221018121014.7368-1-william.gray@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="p1S8upHQyjbUoLz2"
Content-Disposition: inline
In-Reply-To: <20221018121014.7368-1-william.gray@linaro.org>
Precedence: bulk


--p1S8upHQyjbUoLz2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Oct 18, 2022 at 08:10:14AM -0400, William Breathitt Gray wrote:
> The signal_read(), action_read(), and action_write() callbacks have been
> assuming Signal0 is requested without checking. This results in requests
> for Signal1 returning data for Signal0. This patch fixes these
> oversights by properly checking for the Signal's id in the respective
> callbacks and handling accordingly based on the particular Signal
> requested. The trig_inverted member of the mchp_tc_data is removed as
> superfluous.
>=20
> Fixes: 106b104137fd ("counter: Add microchip TCB capture counter")
> Cc: stable@vger.kernel.org
> Cc: Kamel Bouhara <kamel.bouhara@bootlin.com>
> Signed-off-by: William Breathitt Gray <william.gray@linaro.org>
> ---
> Changes in v2:
>  - Simplified action_read() changes to just handle qdec_mode and
>    non-TIOA Signals before continuing with existing code

Queued for counter-fixes.

William Breathitt Gray

--p1S8upHQyjbUoLz2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCY1QIEAAKCRC1SFbKvhIj
K++tAQDXFZWn/HfRjhWoQtjL9COX6tTdBW+GBnHuNY1F5OZJuwD+O4BgyQcytFjO
vc2bRSUznJOKQRr/oG84q+qQSQO/cQA=
=6sLC
-----END PGP SIGNATURE-----

--p1S8upHQyjbUoLz2--