Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp4598963rwi; Sat, 22 Oct 2022 12:50:16 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4wbL7bOP5wiUUn2NywYjl3JBRcGj+zOZup0yTOCALFiW8Y0r+xHsz5G5G90br3wzEDglqB X-Received: by 2002:a05:6402:249b:b0:460:cb11:27d4 with SMTP id q27-20020a056402249b00b00460cb1127d4mr13199578eda.410.1666468216457; Sat, 22 Oct 2022 12:50:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666468216; cv=none; d=google.com; s=arc-20160816; b=RCJmmSrY/OVlCUeKftzOM3DV18FCu4+GP5fubZPvp5G+d6l7oLgUXPdkPFaKwWC2p9 eU45a9+3GQLhbsDZFvI0YIRvOTiQoNXSaE5DyCnnvAa/F1t6Wb7zRZb3lqDEdDunkVzD yajd14KlREJH5zFBm8kNowQqIhVApS05BXzlJRR4OsdKc2833mHCuDT/FWki3TL5w8yh q0WBI6K/jfBwTm2GFnH+eFu2qD6Hdpe5yvX9NbTgempEPceiKN8c2JsO7bD2UbzswbSM 4PCQBjq4jZSKlIpeYv0UOY37ME5V5BnwlPVcNIyF4JLuH1RpeNDiusKI06HrNCgbLuHa lqwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=T9LpZPFlHgWUe4eDeTAs56Flwrd0wFRaYHk0aeDHPxQ=; b=Ia91p+JlJiKKS69BPyXNKv2Jh10Fsy2HdOfgsgRbiD0TaRIlKjs1g3UzVkUSbA5hQo Aii0OI6BThg6ipuF1xtfZRgSXDyeP9KMDkNlyy30rme1hKZfe247FuPJ0f7wzevrw76O sDSMldHixAtPEDWL6GulDSUjXKYh/NPr3WucQ22jMO0fsCcKAIcYlzQV4ZFQKmgtfyEm eSEPBaveOryEOnkOWgHTxNhGmlv/WhgZdIW0t3l472ZDEOXsA/Ksr/pA8aYWoLe0GYop z4YyjwRvuif2qltLfGcuVh2Y8pnQXgSKOVS5cq8kF83sUTAw+q5dgrhOjtRS04BWOpJB 3UxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=lcNCARL4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k5-20020a1709062a4500b0079195ddab1bsi11644218eje.221.2022.10.22.12.49.48; Sat, 22 Oct 2022 12:50:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=lcNCARL4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229823AbiJVTqY (ORCPT + 99 others); Sat, 22 Oct 2022 15:46:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229904AbiJVTqS (ORCPT ); Sat, 22 Oct 2022 15:46:18 -0400 Received: from msg-2.mailo.com (msg-2.mailo.com [213.182.54.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B56FB72FF2 for ; Sat, 22 Oct 2022 12:46:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1666467954; bh=WUEJ8LIJXWvv1saHl+RLKcZFwmk9DIjuDaA5XV0CvcA=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To; b=lcNCARL43jASSGjMEKI92i+tlWApUTueOU+8pqNUtsO2k4bfCTMM5Ias3439r8S2S qy/13+tuYIRXQFMwzj+ikrtpDvfKX7rUYrZtj+1XLjwxN/RTZRcsG14E1omHibr9t7 L2a6/7nSk64jFIl8CPR8g+gOCbOSaZ14vjRi7k/Q= Received: by b-2.in.mailobj.net [192.168.90.12] with ESMTP via [213.182.55.206] Sat, 22 Oct 2022 21:45:54 +0200 (CEST) X-EA-Auth: hfqt9AylkVo773CYc4VKlOR4dKDu7bAeyIc2xThFM+Vr+cYgqcUPYhOm+GZmP6YtXcUmAoY7az6CAoijkSWgBCpvMp2vDe4e Date: Fri, 21 Oct 2022 22:19:43 +0530 From: Deepak R Varma To: Greg KH Cc: outreachy@lists.linux.dev, Larry.Finger@lwfinger.net, phil@philpotter.co.uk, paskripkin@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kumarpraveen@linux.microsoft.com, saurabh.truth@gmail.com Subject: Re: [PATCH v4 00/11] staging: r8188eu: trivial code cleanup patches Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DATE_IN_PAST_24_48, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 22, 2022 at 10:05:36AM +0200, Greg KH wrote: > On Fri, Oct 21, 2022 at 02:56:10AM +0530, Deepak R Varma wrote: > > Address different kinds of checkpatch complains for the staging/r8188eu module. > > The patches are required to be applied in sequence. > > > > Changes in v4: > > 1. Include patch 11 in the set for unused macro clean up. Suggested by julia.lawall@inria.fr > > 2. Update patch 1 per feedback from David.Laight@ACULAB.COM > > 3. Update patch 5 & 6 per feedback from dan.carpenter@oracle.com & julia.lawall@inria.fr > > > > Changes in v3: > > 1. Patch 4: Extend the __constant_htons to htons change to other files of the driver. > > This was suggested by philipp.g.hortmann@gmail.com > > 2. Patch 4: Spelling mistake corrected as pointed out by joe@perches.com > > 3. Patch 5 through 10: Included in this version. Additional clean up patches. > > > > Changes in v2: > > I incorrectly labeled the first revision as v1 instead of v2. So, > > following change recorded under v1 is actually changes for v2. Feedback > > provided by philipp.g.hortmann@gmail.com > > 1. Improve language / grammar for the patch descriptions > > 2. Further improve code reformatting > > > > I've taken these, but note, your email system is not properly being > authenticated. Here's the results I get when I use the tool 'b4' to > apply the patches: > > Grabbing thread from lore.kernel.org/all/cover.1666299151.git.drv%40mailo.com/t.mbox.gz > Analyzing 20 messages in the thread > Checking attestation on all messages, may take a moment... > --- > ✗ [PATCH v4 1/11] staging: r8188eu: use Linux kernel variable naming convention > + Tested-by: Philipp Hortmann (✓ DKIM/gmail.com) > ✗ [PATCH v4 2/11] staging: r8188eu: reformat long computation lines > + Tested-by: Philipp Hortmann (✓ DKIM/gmail.com) > ✗ [PATCH v4 3/11] staging: r8188eu: remove {} for single statement blocks > + Tested-by: Philipp Hortmann (✓ DKIM/gmail.com) > ✗ [PATCH v4 4/11] staging: r8188eu: use htons macro instead of __constant_htons > + Tested-by: Philipp Hortmann (✓ DKIM/gmail.com) > ✗ [PATCH v4 5/11] staging: r8188eu: correct misspelled words in comments > + Tested-by: Philipp Hortmann (✓ DKIM/gmail.com) > ✗ [PATCH v4 6/11] staging: r8188eu: Add space between function & macro parameters > + Tested-by: Philipp Hortmann (✓ DKIM/gmail.com) > ✗ [PATCH v4 7/11] staging: r8188eu: Associate pointer symbol with parameter name > + Tested-by: Philipp Hortmann (✓ DKIM/gmail.com) > ✗ [PATCH v4 8/11] staging: r8188eu: replace leading spaces by tabs > + Tested-by: Philipp Hortmann (✓ DKIM/gmail.com) > ✗ [PATCH v4 9/11] staging: r8188eu: Put '{" on the symbol declaration line > + Tested-by: Philipp Hortmann (✓ DKIM/gmail.com) > ✗ [PATCH v4 10/11] staging: r8188eu: Correct missing or extra space in the statements > + Tested-by: Philipp Hortmann (✓ DKIM/gmail.com) > ✗ [PATCH v4 11/11] staging: r8188eu: Remove unused macros > + Tested-by: Philipp Hortmann (✓ DKIM/gmail.com) > --- > ✗ BADSIG: DKIM/mailo.com > --- > Total patches: 11 > > > Please look into fixing up your DKIM settings. Hi Greg, Yeah, there is some trouble with my email settings and I have already written to the tech support. I will also look DKIM authentication issue and let you know if I need further guidance from you all. Thank you for highlight it. ./drv > > thanks, > > greg k-h