Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 22 Oct 2022 16:19:56 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     kernel test robot <lkp@intel.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        kbuild-all@lists.01.org,
        Naoya Horiguchi <naoya.horiguchi@linux.dev>,
        David Hildenbrand <david@redhat.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Mina Almasry <almasrymina@google.com>,
        Peter Xu <peterx@redhat.com>, Rik van Riel <riel@surriel.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        Matthew Wilcox <willy@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Wei Chen <harperchen1110@gmail.com>, stable@vger.kernel.org
Subject: Re: [PATCH] hugetlb: don't delete vma_lock in hugetlb MADV_DONTNEED
 processing
Message-ID: <Y1R6nKdWb4hNA/sA@monkey>
References: <20221021230722.370587-1-mike.kravetz@oracle.com>
 <202210221005.gYJlzVHS-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202210221005.gYJlzVHS-lkp@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+2lbae60RNlEWsZO7kADoTtRGOjawmXUH29qyOL4tiMg7m94pzfW2kmpGFl6?=
 =?us-ascii?Q?hymXDnpPNXyaNuQCEf0avHOS2NUJT7nE/ifi5Fu8MjXKXKenhJwCtmhsSwMl?=
 =?us-ascii?Q?RDYC6DVbQmis5VU8ChBH5ragUBD1LGNO6WOEhrWG7DUTBGbobXMYryKsDhZK?=
 =?us-ascii?Q?4Q+HuXIbgwdE6g9FjkKraX1MXtyyq6d6hJblRd76f0oWawKKz9QjO3VElLQJ?=
 =?us-ascii?Q?J3v03pWaiCKccgGXH3+yhk5bwmqSN2s6iXB33FkHEzGinvS2iowD/f11TPyu?=
 =?us-ascii?Q?ODZ1WiG4BXYPIrrt1al1EHn6qj9UrOh13lD8fB7jOQwW31i/FblKBMQ3OHGt?=
 =?us-ascii?Q?wd1WMvorOf7Fx1OQ6MFxzg2fEs830FNl/lr/Ypb3WfrJSLVZuO+nUQgtifGS?=
 =?us-ascii?Q?5PnHIDHlB+hXfMthYrEZmmP2UdR013cfOoJ8BPHVTRqWCxkP+npDzQOWi/GU?=
 =?us-ascii?Q?C8Bmgt4NmjFZqLb5donH3rzH0kj75ZSwr+voYIYimB9oCK2vWDprTZYJg5Fi?=
 =?us-ascii?Q?gSwsgU9t4jwrNGawrkCHc5net4j1EjjlN+FMwsVzh0M1CNjZwKpxmh/GjC1m?=
 =?us-ascii?Q?5m7P3PvJg+cn5iizorvn1fidXsDAJjJ4qc/0W18Ci6pSUrotYfDMDsliAtkZ?=
 =?us-ascii?Q?Dix81nV9NWVitWhx/qMkxmJQWOGoZ+FgkFKDerdMLQTkrE1wskGTcAaL7C+5?=
 =?us-ascii?Q?A8G2IZzayPyipRK2YQ/fFmCa9CY1K1W7KFsJNmSYp+D2ziF4hBSBnmUTLDHH?=
 =?us-ascii?Q?Vb/a1SRA+Kl9q30rr+cvqyYBuqMqmLrPbF0T50brM4C8vwJnX3x9NDwuvpwi?=
 =?us-ascii?Q?gVtsvxBW8vqCm9VfzZKF7kcQ5EDW2pEjfGtOgKXgb28NhyyCYDgAKTcR4OIW?=
 =?us-ascii?Q?LICx80extSzUwtk+metEUF7IuGIG2baa64HaUK9vrzNL80NvZ99PAwjCMdsK?=
 =?us-ascii?Q?1XMlkq4+QzX9Q1cEImLdtMrFEVVLjHtbk/+zJV6G35WMnlCwUeRp+2FZKVAW?=
 =?us-ascii?Q?60b53nmUoSurdxosBZmRcihOmjOkXRn3DWl2T14sFSM8BZ+W5iSXL/JnAGE3?=
 =?us-ascii?Q?itLXEW6wjEotXuuFXsyFGLDM5vlrNzlLBtZAdeGSTZ+WffAcxFax1cICPs6s?=
 =?us-ascii?Q?6H3gwIr/aWmzCvx2L5NZeoab93a8Dn+1Nsd50Ac6iWmSR9xlGF8hXqBGtos/?=
 =?us-ascii?Q?Jrn2vOp+EuImqDY3ZW7FcMXeHLUOBijFH9OnJqdj3yX+EjGLCsgzmDpVIV/f?=
 =?us-ascii?Q?edq/SR9BgXgladRNUzNRf0hfCYEEnMkuDLz+iuLImTfpX/ZupE8l61wvUFQ2?=
 =?us-ascii?Q?8SWYj+Wr8TDuPMJW9NucOi+HBnEnrgso/BewaOQYxTFJJ26MQ9U7FBK8Xb+x?=
 =?us-ascii?Q?MkCjhBSubM0501+xVm2sw0qenzMl/to4Vg0S77BlD+Hztq7UXpE+hYVZ20mu?=
 =?us-ascii?Q?R1vHlbiJ+jy+DKV3rh59jMQgKcJE2qTL6fu/o6mKKccp6IdDjtpyomk44F/C?=
 =?us-ascii?Q?idfMMt/+AFjc/m0WarcCM0O5GML3W8SjDLqta6D6ucYLeNqxm9Ac3PiJhcNJ?=
 =?us-ascii?Q?prdOwFxt9YLeykKkTup6LMseH3qbg9R5uIdVIWa++bkHA7Ac0i08QfGWnGPr?=
 =?us-ascii?Q?GA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5b1e74b2-c6aa-49df-182f-08dab483f08c
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2022 23:19:59.8118
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oMKRqz/K0IOa/FJJ5Oi/oKBjabbP/iE7nL+rZ1mHNrUv7n+f9hXXmAbSOhBT8G7mif/tP5tSF/E56u8GZTOD+Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5319
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-21_04,2022-10-21_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 phishscore=0
 suspectscore=0 mlxlogscore=999 bulkscore=0 adultscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210220146
X-Proofpoint-ORIG-GUID: -grTO9U68b_A-1A_S1Z5VhX7ZUd7eeeP
X-Proofpoint-GUID: -grTO9U68b_A-1A_S1Z5VhX7ZUd7eeeP
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/22/22 10:45, kernel test robot wrote:
> Hi Mike,
> 
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on akpm-mm/mm-everything]
> [also build test ERROR on linus/master v6.1-rc1 next-20221021]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Mike-Kravetz/hugetlb-don-t-delete-vma_lock-in-hugetlb-MADV_DONTNEED-processing/20221022-070934
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
> patch link:    https://lore.kernel.org/r/20221021230722.370587-1-mike.kravetz%40oracle.com
> patch subject: [PATCH] hugetlb: don't delete vma_lock in hugetlb MADV_DONTNEED processing
> config: powerpc-allnoconfig
> compiler: powerpc-linux-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/intel-lab-lkp/linux/commit/b52333ec636c58b31a006e7b4a0e6e9f1280ceaa
>         git remote add linux-review https://github.com/intel-lab-lkp/linux
>         git fetch --no-tags linux-review Mike-Kravetz/hugetlb-don-t-delete-vma_lock-in-hugetlb-MADV_DONTNEED-processing/20221022-070934
>         git checkout b52333ec636c58b31a006e7b4a0e6e9f1280ceaa
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash arch/powerpc/kernel/
> 
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from arch/powerpc/kernel/setup-common.c:37:
> >> include/linux/hugetlb.h:431:13: error: 'clear_hugetlb_page_range' defined but not used [-Werror=unused-function]
>      431 | static void clear_hugetlb_page_range(struct vm_area_struct *vma,
>          |             ^~~~~~~~~~~~~~~~~~~~~~~~
>    cc1: all warnings being treated as errors

Wow!  I was unaware that madvise could be removed via a config option.

I will soon send a v2 with changes as follows:

- Use __maybe_unused on the static stub in the !CONFIG_HUGETLB_PAGE case
  in hugetlb.h.
- Wrap clear_hugetlb_page_range in hugetlb.c with #ifdef CONFIG_ADVISE_SYSCALLS
  so that it is not included if !CONFIG_ADVISE_SYSCALLS.
-- 
Mike Kravetz