Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp5142135rwi; Sun, 23 Oct 2022 00:28:25 -0700 (PDT) X-Google-Smtp-Source: AMsMyM73+z/uSNvnBSA12mx+L5BKT/bo5n0S4GoC7L6HQPMT4g5CaW+TdksD7Ov9veCyhYbkjuBa X-Received: by 2002:a63:200e:0:b0:45b:d6ed:6c5 with SMTP id g14-20020a63200e000000b0045bd6ed06c5mr22925921pgg.121.1666510104794; Sun, 23 Oct 2022 00:28:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666510104; cv=none; d=google.com; s=arc-20160816; b=DpNcZbv5ubKwIW6zMh4MnFvk4d6/l50rLkylh46q3d/U2OIDsDbpvvQQ3or+3fyebW 0q2cvSeg9HBCMLVbulESHcuuoKNHp947g9Es0G192elkGTuVoBdP9S0W+Ud7w5sbyVio ZaS9EToqtCNDRJLHEPDWo8XfjWAFqmzQKegbwt4bBmwUKJw2Ez8lPl8WQ6NyIhlM0YOA 1am9LpudRZfVbK9+GJ2SwfrhIfjpFPLANjo9Cn+NTJP212BB/dmzTsCWbVYq14HpGZ3Z vlz2HUTLvxxnHQaDYMXa2WwftBRvympqLhIny8YYr8BvOth1MIFdjO/JwysvRLny5ysq Su2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=lP4csMVI11zhuV7sGoe8Kep7XXE0ztSZiFUr2yvWEbw=; b=UaC77JT3WXPvPpveXmYPy7d6iIvA7c3IN4odPNvWzzXzMtVF0P823385bkNMssAryg QV31vnaRamsQT22hhHl2+zqSsd8lD8iEa5gKPLUQJTAbt9S4oj3Qjde7vT8J532dtZe8 yeTKFyircTmJlbbI/qRE3Qkn9xCDvJkNUXcBaS4R0O++hqcJ6HLWPWf0KiisN3BNgLu2 D8tBeUMeXG/sdeKVsHalzjKWsxoYO2q9kZAlzPHgf9C9jwITN2OqYun2oxG8ZoPFXbXz 3L35pPytzhnKuiTShMUIeTLNFK9xFrJhJICJ9ni2m2FksL58uPZdumicmb6AdtlYCGmr HYvw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=d7l7K8Xg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w8-20020aa79548000000b00561cb07c77csi30610939pfq.232.2022.10.23.00.28.13; Sun, 23 Oct 2022 00:28:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=d7l7K8Xg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229882AbiJWGwN (ORCPT + 99 others); Sun, 23 Oct 2022 02:52:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229610AbiJWGwJ (ORCPT ); Sun, 23 Oct 2022 02:52:09 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A37F76964; Sat, 22 Oct 2022 23:52:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666507929; x=1698043929; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ABkS0NhAjDi8ntSJ5iUziEw9CbuP9xXeeAUlShM0158=; b=d7l7K8XglqPq/42axHqWjQTjxt7CswOp0iEM4uKMDSTJztDvpoIG8HQ8 fphV8P1gSJtaJRcFTB0nl4/J8/sx9vU7Q55Ow1+AGRf6H5jkGaQnupKlA eS6HNSUFMoXcd1thIRHbPStRr1TE79YcpnLtdp7HAi9RxBDXhXrVr+l0W pHUCqFWLFzSwo5c2LXGwKkvCW1o0IxBGK5m9idBOjISJtBWTno0CwVazN YxO4QIV+BCmirOf7PLJm5Y0m952Ttsu8LdXBS2Ru05A1PgeZl9UFaqKB+ o21brek933AGAuEwzAkCd7InisodSkWm2MkiinRY+pSF9JLFGeCYqvnUU Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10508"; a="308332040" X-IronPort-AV: E=Sophos;i="5.95,206,1661842800"; d="scan'208";a="308332040" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2022 23:52:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10508"; a="699804517" X-IronPort-AV: E=Sophos;i="5.95,206,1661842800"; d="scan'208";a="699804517" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 22 Oct 2022 23:52:06 -0700 Received: by black.fi.intel.com (Postfix, from userid 1001) id C01F4107; Sun, 23 Oct 2022 09:52:28 +0300 (EEST) Date: Sun, 23 Oct 2022 09:52:28 +0300 From: Mika Westerberg To: Colin Ian King Cc: Andreas Noever , Michael Jamet , Yehezkel Bernat , linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] thunderbolt: remove redundant assignment to variable len Message-ID: References: <20221019225709.1506515-1-colin.i.king@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221019225709.1506515-1-colin.i.king@gmail.com> X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 19, 2022 at 11:57:09PM +0100, Colin Ian King wrote: > The variable len is assigned a value that is never read. It is re-assigned > a new value in the following do-while loop and never referenced after > the loop. The assignment is redundant and can be removed. > > Cleans up clang scan build warning: > drivers/thunderbolt/xdomain.c:344:2: warning: Value stored to 'len' is > never read [deadcode.DeadStores] > > Signed-off-by: Colin Ian King Applied to thunderbolt.git/next, thanks!