Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 23 Oct 2022 09:53:09 +0300
From:   Ido Schimmel <idosch@nvidia.com>
To:     Vladimir Oltean <olteanv@gmail.com>
Cc:     netdev@kapio-technology.com, davem@davemloft.net, kuba@kernel.org,
        netdev@vger.kernel.org,
        Oleksandr Mazur <oleksandr.mazur@plvision.eu>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Hauke Mehrtens <hauke@hauke-m.de>,
        Woojung Huh <woojung.huh@microchip.com>,
        UNGLinuxDriver@microchip.com, Sean Wang <sean.wang@mediatek.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Ivan Vecera <ivecera@redhat.com>,
        Roopa Prabhu <roopa@nvidia.com>,
        Nikolay Aleksandrov <razor@blackwall.org>,
        Shuah Khan <shuah@kernel.org>,
        Russell King <linux@armlinux.org.uk>,
        Christian Marangi <ansuelsmth@gmail.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Yuwei Wang <wangyuweihx@gmail.com>,
        Petr Machata <petrm@nvidia.com>,
        Florent Fourcot <florent.fourcot@wifirst.fr>,
        Hans Schultz <schultz.hans@gmail.com>,
        Joachim Wiberg <troglobit@gmail.com>,
        Amit Cohen <amcohen@nvidia.com>, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org,
        bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v8 net-next 10/12] net: dsa: mv88e6xxx: mac-auth/MAB
 implementation
Message-ID: <Y1Tk1eTlLI6ue8IA@shredder>
References: <82d23b100b8d2c9e4647b8a134d5cbbf@kapio-technology.com>
 <20221021112216.6bw6sjrieh2znlti@skbuf>
 <7bfaae46b1913fe81654a4cd257d98b1@kapio-technology.com>
 <20221021163005.xljk2j3fkikr6uge@skbuf>
 <d1fb07de4b55d64f98425fe66156c4e4@kapio-technology.com>
 <20221021173014.oit3qmpkrsjwzbgu@skbuf>
 <b88e331e016ad3801f1bf1a0dec507f3@kapio-technology.com>
 <20221021181411.sv52q4yxr5r7urab@skbuf>
 <Y1P0/gYdvrk+W866@shredder>
 <20221022144951.v2twgp2lcnhnbhrv@skbuf>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221022144951.v2twgp2lcnhnbhrv@skbuf>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AoefoeGVFYlYReLrOOSeQyzJithxqa8+F+zlKShZTmZqVP5FnJHHTsnA3efr?=
 =?us-ascii?Q?9NQBKZ68LKyoXlMomb2NvUOT6KxuP0oTVWvY8eiJvMB0QaXtI81yg0RXRaVB?=
 =?us-ascii?Q?1YJsm6xuOxgj01WYvcV2q2z2CBXGIN75wRhzeb4J8uxN+m0KjlsAFxni3VpS?=
 =?us-ascii?Q?SHMeTuqfCFdB/1cTUNYu5Qc16W9fdfd9j4V4qM7ZUCoh9TbS0nrs0FQLU5Ai?=
 =?us-ascii?Q?w24BeKH+WmJAmC90LHpg3PMzOnog3aHm7wOhBkm1jxAXuw9YZcEUAgpPujNd?=
 =?us-ascii?Q?1kMaBA8K7v2ma95ZXGc4g032MP0kvjMyR1KJxv7DKK1dfuMhfwAr4o+Bofoc?=
 =?us-ascii?Q?u+wJKxdYgafdIklF92/ItLarLQdgd0h8oZFqQ7vDjtHWyuAvNVMpGZXVgp/K?=
 =?us-ascii?Q?KUyQEru7O8p4QWXH3kRBgzMoo8XHtXpmzv8IfYJBn2LAORjyob8wq5s/eaDd?=
 =?us-ascii?Q?KgWyEH9xm753PnXoyOeTaCkoXxCC9Zc4o2QBX9v56Yb7PrDPmyoWk+ty8GpW?=
 =?us-ascii?Q?g967pmrs6HqxDZJUSS9cen+YjI3gA+MRwiQOwizjm3db7YW31Wwc/NQ8mr++?=
 =?us-ascii?Q?cvGdF3CjNBLMrvgnF467KlgaIlM7Q8GV8RH+d8213hBvBpiwXKslBturNh17?=
 =?us-ascii?Q?bRnsUgG+3HVdim2w9VMRap2+jSc1Vtk0PdgPWY8QNCU4UtDLGP2JHBFNoj0D?=
 =?us-ascii?Q?FYws9C278NA4Gv5+9+g7ZONbiaMIbSMYglBJY23zaAP88E68YkGYuzJxA5TP?=
 =?us-ascii?Q?nY/SKHvzidXyAx4hxVgXywiKflJ29g0uOREqRaWGHwSNBkfnP264Q+78CP6r?=
 =?us-ascii?Q?mmp7qDW8k2zxwh7py//dyZrxGXsduJJvXJEVf7JhxE0GngL4a+76a3dfPWMf?=
 =?us-ascii?Q?kS/Kf25FFkX2MpBIRnuLeDvB1EQOnxNEj8GOBi3Q3EhIwqpeK4+d8TYwtgGx?=
 =?us-ascii?Q?O6qXxL72U5x3ToDRVLdffiAGp3ExHEkSoqIQPy6eCfC0rGPsOES+valRWYua?=
 =?us-ascii?Q?XpEOF8i3LYxOlqSQ/cAalWvwNhKTQ1VjPH/cWNqJFDebnUzaiUjORA3OTJUg?=
 =?us-ascii?Q?1R061PY1gSdyahmYQXuEqhoyjyO5skWJPIGYds1RblHZoJCwoYspXLSBUgWx?=
 =?us-ascii?Q?ttWFMh9s6lFIs0ArmU+TmiV9IIRiqKNLeYAzctsRGDtJ5WKpfrTshi46W0Ww?=
 =?us-ascii?Q?T9tvBa4oc9GkjhaL0m2S/imj8rLLydYPtXNACwK+Gwglo8Q9iGla2GTw6SEH?=
 =?us-ascii?Q?rdNzEQf1HRQC1boflrUnx/C1I+iQPoCNuEqxdvHZu33i4LopQBGI9TrfyBWl?=
 =?us-ascii?Q?Hcljgl8wW0jRd6ZkelIuXBYw1RPSBlZ/Edpq5dxzrOWHNyp4bCuXfMp+7Fqf?=
 =?us-ascii?Q?IuNVxJ74323nJkgDhEYmEK2VJev6DVcZcD5kDUDt2pFK2n8TPeoYyjlmBqUE?=
 =?us-ascii?Q?fGnVoazqkcz5VUPCsUt1rxvwL5m6JmBpQE0inDxTHb5NTR4ySf0wzDu+f2vP?=
 =?us-ascii?Q?jzWivHHNUaH4DrVnZ+oPAo+8zLEXXQ7t4KVVgj85A3fmmHbmWXuU1Sg00nOH?=
 =?us-ascii?Q?EdOsvICWiNKE3h18baatLb6/wLB7LJYJBqP42jMQ?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 06bf7512-a81d-4ca4-0259-08dab4c3420b
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6179.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2022 06:53:14.8329
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FWafE4TCU4W21YP5aiavDYkf2wXnVtxMIZvc0ExLLyik15VNnyY9UWy8pwjLZNHSsiAhmFl7X4Q41enRpzzpdg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6273
X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Oct 22, 2022 at 05:49:51PM +0300, Vladimir Oltean wrote:
> On Sat, Oct 22, 2022 at 04:49:50PM +0300, Ido Schimmel wrote:
> > In the above scenario, learning does not need to be on for the bridge to
> > populate its FDB, but rather for the bridge to refresh the dynamic FDB
> > entries installed by hostapd. This seems like a valid use case and one
> > needs a good reason to break it in future kernels.
> 
> Before suggesting any alternatives, I'd like to know more details about
> how this will work in practice, because I'm aware of the limitations
> that come with DSA not syncing its hardware FDB with the software bridge.
> 
> So you add a dynamic FDB entry from user space, it gets propagated to
> hardware via SWITCHDEV_FDB_ADD_TO_DEVICE, and from there on, they have
> completely independent ageing timers.
> 
> You'll still suffer interruptions in authorization, if the software FDB
> entry expires because it was never refreshed (which will happen if
> traffic is forwarded autonomously and not seen by software). And at this
> stage, you could just add static FDB entries which you periodically
> delete from user space, since the effect would be equivalent.
> 
> If the mitigation to that is going to involve the extern_learn flag, the
> whole point becomes moot (for mv88e6xxx), since FDB refreshing does not
> happen in the bridge driver in that case (so the learning flag can be
> whatever).

Once a dynamic FDB entry is installed in hardware the software bridge no
longer sees the majority of the traffic that refreshes this entry, which
means we need to prevent the bridge from mindlessly ageing and removing
the entry. I see two options, depending on the capabilities of the
underlying hardware implementation:

1. If the hardware is capable of generating an event that an entry was
aged out, then once the dynamic entry was installed in hardware the
device driver needs to let the bridge driver know that it is no longer
responsible for ageing the entry. This can be done by either marking the
entry as extern_learn or offloaded. The latter is more accurate, but we
need to patch br_fdb_cleanup(). Upon an ageing event, the device driver
will tell the bridge to remove the entry via
SWITCHDEV_FDB_DEL_TO_BRIDGE.

2. If the hardware is unable to generate ageing events, but allows
querying the activity of the entry, then the device driver will need to
emulate the behavior of the first option. This allows us to use the same
interface between the bridge and device driver regardless of the
underlying hardware implementation. My feeling is that most devices fall
in the first category.

> > Regarding learning from link-local frames, this can be mitigated by [2]
> > without adding additional checks in the bridge. I don't know why this
> > bridge option was originally added, but if it wasn't for this use case,
> > then now it has another use case.
> 
> There is still the problem that link-local learning is on by default
> (follows the BR_LEARNING setting of the port). I don't feel exactly
> comfortable with the fact that it's easy for a user to miss this and
> leave the port completely insecure.

I'm willing to patch the man page and add a note near the 'locked'
bridge port option.

> > Regarding MAB, from the above you can see that a pure 802.1X
> > implementation that does not involve MAB can benefit from locked bridge
> > ports with learning enabled. It is therefore not accurate to say that
> > one wants MAB merely by enabling learning on a locked port. Given that
> > MAB is a proprietary extension and much less secure than 802.1X, we can
> > assume that there will be deployments out there that do not use MAB and
> > do not care about notifications regarding locked FDB entries. I
> > therefore think that MAB needs to be enabled by a separate bridge port
> > flag that is rejected unless the bridge port is locked and has learning
> > enabled.
> 
> I had missed the detail that dynamic FDB entries will be refreshed only
> with "learning" on. It makes the picture more complete. Only this is
> said in "man bridge":
> 
>        learning on or learning off
>               Controls whether a given port will learn MAC addresses
>               from received traffic or not. If learning if off, the
>               bridge will end up flooding any traffic for which it has
>               no FDB entry. By default this flag is on.
> 
> Can live with MAB being a separate flag if it comes to that, as long as
> 'learning' will continue to have its own specific meaning, independent
> of it (right now that meaning is subtle and undocumented, but makes sense).

Yes, I agree it is subtle.

> > Regarding hardware offload, I have an idea (needs testing) on how to
> > make mlxsw work in a similar way to mv88e6xxx. That is, does not involve
> > injecting frames that incurred a miss to the Rx path. If you guys want,
> > I'm willing to take a subset of the patches here, improve the commit
> > message, do some small changes and submit them along with an mlxsw
> > implementation. My intention is not to discredit anyone (I will keep the
> > original authorship), but to help push this forward and give another
> > example of hardware offload.
> > 
> > [1] https://github.com/westermo/hostapd/commit/10c584b875a63a9e58b0ad39835282545351c30e#diff-338b6fad34b4bdb015d7d96930974bd96796b754257473b6c91527789656d6ed
> > [2] https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=c74a8bc9cf5d6b6c9d8c64d5a80c5740165f315a
> 
> I think it would be very nice if you could do that. As a middle ground
> between mv88e6xxx and mlxsw, I can also try to build a setup on ocelot
> (which should trap frames with MAC SA misses in a similar way to mlxsw,
> but does also not sync its FDB with the bridge, similar to the mv88e6xxx.
> Not sure what to do with dynamic FDB entries).

Will try to post my patches this week.

> If only I would figure out how to configure that hostapd fork (something
> which I never did before).
> 
> Hans, would it be possible to lay out some usage instructions for this fork?

That would be good.