Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758098AbXHAPgT (ORCPT ); Wed, 1 Aug 2007 11:36:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752648AbXHAPgJ (ORCPT ); Wed, 1 Aug 2007 11:36:09 -0400 Received: from out2.smtp.messagingengine.com ([66.111.4.26]:50170 "EHLO out2.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751301AbXHAPgH (ORCPT ); Wed, 1 Aug 2007 11:36:07 -0400 X-Sasl-enc: U8LgaHh1AX103SUCDFJdR7xR4i5Q80bDNwZhHvZhQ/fb 1185982566 Date: Wed, 1 Aug 2007 12:36:02 -0300 From: Henrique de Moraes Holschuh To: Hugh Dickins Cc: Len Brown , Michal Piotrowski , linux-kernel@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net, Richard Hughes , Matthew Garrett Subject: Re: THINKPAD_ACPI_INPUT_ENABLED seems regressive Message-ID: <20070801153602.GJ23111@khazad-dum.debian.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-GPG-Fingerprint: 1024D/1CDB0FE3 5422 5C61 F6B7 06FB 7E04 3738 EE25 DE3F 1CDB 0FE3 User-Agent: Mutt/1.5.16 (2007-06-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2130 Lines: 50 Cc's added. On Wed, 01 Aug 2007, Hugh Dickins wrote: > When updating this IBM ThinkPad T43p from 2.6.22 to 2.6.23-rc1 > using make oldconfig, the text and default Y of > > config THINKPAD_ACPI_INPUT_ENABLED > bool "Enable input layer support by default" > depends on THINKPAD_ACPI > default y > ---help--- > Enables hot key handling over the input layer by default. If unset, > the driver does not enable any hot key handling by default, and also > starts up with a mostly empty keymap. > > If you are not sure, say Y here. Say N to retain the deprecated > behavior of ibm-acpi, and thinkpad-acpi for kernels up to 2.6.21. > > made it sound like a good thing, so I configured it Y. But its only > effect seems to be to disable the key I use most, Fn+F4 to suspend to > RAM. It also disables Fn+F3 to blank the screen, though I don't use > that one; but does not disable the brightness and ThinkLight keys, > presumably because they just get mapped to KEY_RESERVED. Actually, it doesn't disable the keys, but it routes them differently, so it will work well only if you have very up-to-date HAL, etc. Richard, Matthew, would the HAL crowd be unhappy if I switch that default? Distros with new enough userland would be expected to compile the kernel with THINKPAD_ACPI_INPUT_ENABLED, though. > I get along fine now with THINKPAD_ACPI_INPUT_ENABLED disabled; but > suggest that its text is misleading, and default Y questionable. > Or perhaps there's a bug, and I can help try patches. No bug in he code. The help text should clearly be improved, and the default could be switched to N. I will send in a patch, after I get a few comments. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/