Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932890AbXHAPsW (ORCPT ); Wed, 1 Aug 2007 11:48:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752074AbXHAPr5 (ORCPT ); Wed, 1 Aug 2007 11:47:57 -0400 Received: from out2.smtp.messagingengine.com ([66.111.4.26]:49903 "EHLO out2.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760348AbXHAPrz (ORCPT ); Wed, 1 Aug 2007 11:47:55 -0400 X-Sasl-enc: e7bhwwyYFonyvUrrapvjEhdxAPjj30grDYeqrIF451d0 1185983273 Date: Wed, 1 Aug 2007 12:47:49 -0300 From: Henrique de Moraes Holschuh To: "Michael S. Tsirkin" Cc: Hugh Dickins , Linux Kernel Mailing List , len.brown@intel.com, linux-acpi@vger.kernel.org, Ingo Molnar , mingo@redhat.com, linux-pm@linux-foundation.org, ibm-acpi-devel@lists.sourceforge.net Subject: Re: 2.6.21-rc1: T60 ACPI issues Message-ID: <20070801154749.GK23111@khazad-dum.debian.net> References: <20070801135820.GA8266@mellanox.co.il> <20070801145607.GB8480@mellanox.co.il> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070801145607.GB8480@mellanox.co.il> X-GPG-Fingerprint: 1024D/1CDB0FE3 5422 5C61 F6B7 06FB 7E04 3738 EE25 DE3F 1CDB 0FE3 User-Agent: Mutt/1.5.16 (2007-06-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2172 Lines: 52 (CC changed from Borislav to ibm-acpi-devel). On Wed, 01 Aug 2007, Michael S. Tsirkin wrote: > > > 2. Pressing Fn/F4 does not trigger suspend to ram > > > This normally triigers ACPI event which triggers suspend to RAM on Ubuntu > > > (echo mem > /sys/power/state works) > > > > I'll bet this is your CONFIG_THINKPAD_ACPI_INPUT_ENABLED=y. > > I got the same, see my "THINKPAD_ACPI_INPUT_ENABLED seems regressive" > > mail to Henrique and lkml an hour ago. [...] > > > 3. After suspend to RAM, system wakes up but laptop's screen is blank, > > > switching VTs etc does not help. > > > External screen wakes up OK though. > > > dmesg output from boot attached. > > > > (I've not had that.) > > Bingo. > sudo rmmod thinkpad_acpi cures both 2 and 3. > Thanks for pointing this out. I can see how it would help with (2), as that prompty tells the firmware to issue its default ACPI events for Fn+F4 upon removal. But I have *NO* idea what thinkpad_acpi might be doing that is causing issues with the wake up after a resume. Please open a bug in bugzilla.kernel.org about it, and attach the full debug output of a suspend+resume cycle with and without thinkpad-acpi loaded. Also, please try the same with thinkpad-acpi loaded, but CONFIG_THINKPAD_ACPI_INPUT_ENABLED set to N. If the problem goes away, please retest, but set hotkey_enable to 1 and do an "cat /sys/bus/platform/devices/thinkpad_acpi/hotkey_recommended_mask > /sys/bus/platform/devices/thinkpad_acpi/hotkey_mask" before the sleep. You will probably need to enable a bunch of debug options in ACPI and thinkpad-acpi to get good enough logs. It is probably worth posting the acpid logs too: the real difference might be there. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/