Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp5471126rwi; Sun, 23 Oct 2022 06:41:08 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6aC/M/gVQ8Ht3i+Ygpr3CVLA58Ckv0uiBWAxfToJHe/WrvM2tNJvE+gjGQFgquziig9/9R X-Received: by 2002:a17:907:2cea:b0:7a3:4ebe:5eb with SMTP id hz10-20020a1709072cea00b007a34ebe05ebmr4180778ejc.228.1666532467855; Sun, 23 Oct 2022 06:41:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666532467; cv=none; d=google.com; s=arc-20160816; b=sdz6dpfGYhTWtdVVnmOCsL37MkCqu1UMSSkP3SZm/jvZ6yyqi13oN3TRxCaAuPbeGj pmIxSrYgJmxc//pOIZTltuOxg3yt6Ypo4SbWkhMmZkGpRnvRym4zRZPTZR42h5GYZOCC srxChaJenBZeIxNly5+Jh86U1LVdVTJtxPc540b5wq/tW5N1gS+rjQ1Z1pwhPayjmatq BN6OYXXk6noFQqVlqq6ewvlH5SjyrEfYlcagYz+uxa+p5DOs01ijkdqNtOSJMHnbEHFS mD85180HjQEp3tNo5EtBGjI/DaxSth1yoIYS/Ox6sm1kKrI2ropWr2LBhja1VfdDoKpU fN+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:in-reply-to:date:subject:cc:to:from:references :dkim-signature; bh=MoVvCB1hQ8h8zDnqjfbOWIK1oHoE24MiFfun5t1upMI=; b=yCsuY1cW+tL0Iv0TIG5908ocpuCVwLQcNUdtIzCMO7VyXLmTZjrLYO8wIEEsHOXUUD etP7OcO1SSHXucDNeIpbWnthFV8vEWeqE3RZNpXSc9iOr89L2SbYtJ4By0FByDkwhC16 jl/JnlxCjmKLD9liZWNOwI556/zCz205FKApKc5s7hIvamnyZhh6rrePSjHTDQJ4oFfU U/9Ck51PaT6Ppz9rU6K87KKRMzvM5QH9MGDSTau46VWVfSnL25D1v/YWCCn+ocSRXrOA ke41HYSbIwxZ2MA8wrbXcVKvHaPAt4baeXe3rQ9R3Y2MNBdSXnuk4+nSZUYoi1ZgMRAJ MDkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=NEg55mCB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b13-20020a056402084d00b0045c98bb5359si31595131edz.590.2022.10.23.06.40.41; Sun, 23 Oct 2022 06:41:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=NEg55mCB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230395AbiJWNgK (ORCPT + 99 others); Sun, 23 Oct 2022 09:36:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229987AbiJWNgI (ORCPT ); Sun, 23 Oct 2022 09:36:08 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 251B767470; Sun, 23 Oct 2022 06:36:04 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id l14so4729935wrw.2; Sun, 23 Oct 2022 06:36:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:references:from:to:cc:subject:date:message-id :reply-to; bh=MoVvCB1hQ8h8zDnqjfbOWIK1oHoE24MiFfun5t1upMI=; b=NEg55mCBKWVDjo1kRCfYA7EY4H2EQEKh4Gl4eI1jB7DDDdO7CXlXwFZUyrFc9kU9hj A8vziP1KkGF1mzhP/xlCKLHMuXX49jwpb6tftQqHjZPyIR4qOB/ng/5D/KXe5GbAeKvv OL5sYbR8wrUB0oKBeWCrnKhffMc8bdpIBsJXdROnNLU+7idU/jhWuPV3R7kzRRtvx4G1 38qw2uWSn94M7qCT90MCAYEHjhpr9zdfWhU2D5KbyVRQBbmu4AW2XfvbaKvuYWdxq4Gh GCURUtzHBBi8IFjVrF0cTlJTvCSSx2UFqthe8+fSjRIizIhCNol4pN4RQc/FrP9uLoHw UfOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:references:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=MoVvCB1hQ8h8zDnqjfbOWIK1oHoE24MiFfun5t1upMI=; b=2ztBJWDRF0DSNP0pOuz6dbmPZ2ZCWBvFpR1hBncdOmGU55qD91KqXW35T7u9U2BOsE elGjjSdrN58+RCz6VPPtdz0f5SSL0NFdI6r1jRzxov5S+ILmlt4W4+lOSclWaXXnlXiD bLM/BwBUWjDl308I6eYsFerrhlxDG3OyiCiI/ntbpJHyrsrd6ejX8l7GIqW5v/ILAeOK mOLERypsfrJq3t7MyS2i8h7QXqSAuZ7vNWulGm/u106raRN2mMTAPPOFMPozwt95zOKR qgcCGrcz249Mjw4NKR6/NprjvYddyBiCJyxAaDLZuOupgc/nBVeNQjXMPyk/us9bGn9h H8kg== X-Gm-Message-State: ACrzQf1hhN0ilFKIrXDSUCMd7TiyRQzhvE1CzkZ8KnY7dCx0IuHXvolZ Ry/KHPBeIpTMIdJqHjHPyy9RQ1j0zu7sFQ== X-Received: by 2002:a5d:47c2:0:b0:22e:4911:6925 with SMTP id o2-20020a5d47c2000000b0022e49116925mr18217396wrc.403.1666532163122; Sun, 23 Oct 2022 06:36:03 -0700 (PDT) Received: from localhost (94.197.10.75.threembb.co.uk. [94.197.10.75]) by smtp.gmail.com with ESMTPSA id j18-20020adff012000000b00228fa832b7asm23675246wro.52.2022.10.23.06.36.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Oct 2022 06:36:02 -0700 (PDT) References: <20221022191308.82348-1-aidanmacdonald.0x0@gmail.com> From: Aidan MacDonald To: Paul Cercueil Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, zhouyu@wanyeetech.com, linux-mips@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 0/9] ASoC: cleanups and improvements for jz4740-i2s Date: Sun, 23 Oct 2022 14:29:34 +0100 In-reply-to: Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Paul Cercueil writes: > Hi Aidan, > > Le sam. 22 oct. 2022 =C3=A0 20:12:59 +0100, Aidan MacDonald > a =C3=A9crit : >> This series is a preparatory cleanup of the jz4740-i2s driver before >> adding support for a new SoC. The two improvements are lifting >> unnecessary restrictions on sample rates and formats -- the existing >> ones appear to be derived from the limitations of the JZ4740's internal >> codec and don't reflect the actual capabilities of the I2S controller. >> I'm unable to test the series on any JZ47xx SoCs, but I have tested >> on an X1000 (which is the SoC I'll be adding in a followup series). >> Changes in v5: >> * Drop 'mem' resource removal patch already upstream. >> * Update FIFO flush bits fix to address Paul's review comments. >> * Drop PLL clock name patch, that needs a different approach. >> Link for v4: URLHERE > > Forgot something? ;) > > -Paul > Ah, sorry, that's why you shouldn't eat dinner between format-patch and send-patch... :) Link to v4: https://lore.kernel.org/alsa-devel/20220708160244.21933-1-aidan= macdonald.0x0@gmail.com/ >> Aidan MacDonald (9): >> ASoC: jz4740-i2s: Handle independent FIFO flush bits >> ASoC: jz4740-i2s: Convert to regmap API >> ASoC: jz4740-i2s: Simplify using regmap fields >> ASoC: jz4740-i2s: Use FIELD_PREP() macros in hw_params callback >> ASoC: jz4740-i2s: Align macro values and sort includes >> ASoC: jz4740-i2s: Support S20_LE and S24_LE sample formats >> ASoC: jz4740-i2s: Support continuous sample rate >> ASoC: jz4740-i2s: Move component functions near the component driver >> ASoC: jz4740-i2s: Refactor DAI probe/remove ops as component ops >> sound/soc/jz4740/Kconfig | 1 + >> sound/soc/jz4740/jz4740-i2s.c | 455 ++++++++++++++++++---------------- >> 2 files changed, 243 insertions(+), 213 deletions(-) >> -- >> 2.38.1 >>