Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 23 Oct 2022 20:47:00 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     wangjianli <wangjianli@cdjrlc.com>
Cc:     mathew.j.martineau@linux.intel.com, matthieu.baerts@tessares.net,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, netdev@vger.kernel.org, mptcp@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/mptcp: fix repeated words in comments
Message-ID: <Y1VF1DBYePbkTk8x@debian.me>
References: <20221022070527.55960-1-wangjianli@cdjrlc.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="M9jz/0j3xO1O4oqZ"
Content-Disposition: inline
In-Reply-To: <20221022070527.55960-1-wangjianli@cdjrlc.com>
Precedence: bulk


--M9jz/0j3xO1O4oqZ
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Oct 22, 2022 at 03:05:27PM +0800, wangjianli wrote:
> Delete the redundant word 'the'.
>=20
> Signed-off-by: wangjianli <wangjianli@cdjrlc.com>
> ---
>  net/mptcp/token.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/net/mptcp/token.c b/net/mptcp/token.c
> index f52ee7b26aed..b817c2564300 100644
> --- a/net/mptcp/token.c
> +++ b/net/mptcp/token.c
> @@ -287,7 +287,7 @@ EXPORT_SYMBOL_GPL(mptcp_token_get_sock);
>   * This function returns the first mptcp connection structure found insi=
de the
>   * token container starting from the specified position, or NULL.
>   *
> - * On successful iteration, the iterator is move to the next position an=
d the
> + * On successful iteration, the iterator is move to the next position and
>   * the acquires a reference to the returned socket.
>   */
>  struct mptcp_sock *mptcp_token_iter_next(const struct net *net, long *s_=
slot,

NAK!

Instead, slightly reword the comment above as "On successful iteration,
the iterator moves to the next position and acquires a reference to the
returned socket.".

Also, you and other @cdjrlc.com developers ignore reviews that request
changes to your patches. If you want to participate in kernel
development community, please don't just sending random patches without
any sort of reply.

I have pointed out this behavior either as part of my review or as reply
to reviews from other developers. I may write this as final warning before
I just say NAK without further ado to your future patches.

Thanks.

--=20
An old man doll... just what I always wanted! - Clara

--M9jz/0j3xO1O4oqZ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCY1VF0AAKCRD2uYlJVVFO
o25EAQDIoaFBeuz0b5mrP55Nk6SpOrkxQQ0pTeEwTsUbrqbC2wD/UsccZMALgll3
5yvwmQtwwSeG2n05VcGxoklMaPFGDwQ=
=mQXI
-----END PGP SIGNATURE-----

--M9jz/0j3xO1O4oqZ--