Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 22 Oct 2022 04:10:44 +0530
From:   Deepak R Varma <drv@mailo.com>
To:     Bagas Sanjaya <bagasdotme@gmail.com>
Cc:     outreachy@lists.linux.dev, gregkh@linuxfoundation.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: wlan-ng: remove commented debug printk
 messages
Message-ID: <Y1Mf7IVccbst10iP@debian-BULLSEYE-live-builder-AMD64>
References: <Y1L0FiKvrM9jjZG9@debian-BULLSEYE-live-builder-AMD64>
 <Y1VDM2kWIi1I5dqI@debian.me>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y1VDM2kWIi1I5dqI@debian.me>
Precedence: bulk

On Sun, Oct 23, 2022 at 08:35:47PM +0700, Bagas Sanjaya wrote:
> On Sat, Oct 22, 2022 at 01:03:42AM +0530, Deepak R Varma wrote:
> > diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c
> > index e04fc666d218..6bef419e8ad0 100644
> > --- a/drivers/staging/wlan-ng/p80211netdev.c
> > +++ b/drivers/staging/wlan-ng/p80211netdev.c
> > @@ -881,55 +881,42 @@ static int p80211_rx_typedrop(struct wlandevice *wlandev, u16 fc)
> >  		wlandev->rx.mgmt++;
> >  		switch (fstype) {
> >  		case WLAN_FSTYPE_ASSOCREQ:
> > -			/* printk("assocreq"); */
> >  			wlandev->rx.assocreq++;
> >  			break;
> >  			wlandev->rx.ctl_unknown++;
> >  			break;
> >  		}
> > -		/* printk("\n"); */
> >  		drop = 2;
> >  		break;
> >
> > @@ -1007,7 +986,6 @@ static int p80211_rx_typedrop(struct wlandevice *wlandev, u16 fc)
> >  			wlandev->rx.cfack_cfpoll++;
> >  			break;
> >  		default:
> > -			/* printk("unknown"); */
> >  			wlandev->rx.data_unknown++;
> >  			break;
> >  		}
>
> Shouldn't these printks be guarded under CONFIG_DEBUG_KERNEL instead?

Hi Sanjaya,
Sure they can, but I think they are very basic tracing message and do not appear
to carry much of information useful the event of debugging. Do you have a
suggestion on what additional information may be added to make them more useful?

If you still think we should have then in the CONFIG_DEBUG_KERNEL guard, let me
know and I will attempt to improve these.

Thank you,
./drv

>
> --
> An old man doll... just what I always wanted! - Clara