Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: UMNyF1tSZRqvWjjUo631PtaBve+FoVn7vV6iUre/YdGJUe8JemyjAO1hhBv4t67VlnVVpUXjfW
 JKcTnJ1i+lGTM2nq82GqbCzrXY296F6T/hwO++BYw9ytZfuszmODiLsZBcUyATM3c5P6hjwUrO
 L4CrCwPkzgQe40F2M3RQb9SWmxPvxe/3TCGzaWOtgQ/DBu6kV6G43Pvsr5q5PH0qNJEl/jtLXL
 MDpGAA3cqm3dsnLVByDjAc7DRzS/uR8nJzg5Vml6SnBqTSubdThYnkIqWwWgw4WLTOjMhLeoFp
 D6e9DIIGFZPDebXcMfXlSl/w
IronPort-SDR: I3PAWXqvc3XnFKE64wx52eolyc1LBfFzk5YbnTfQXRCSepvyDaUSL72W8aiiQpdPXnpwgyc65R
 JC4rrkFnJkX5J5ADJjD6+fNh+cBMYqqoccFphCJ235yEYia64W45HkUDIfexGSF1kkixKVK9Vr
 psRkWSfBAmArShzRh4RGnHrIivYj+HZWSD29i8m7p3H+AGgO4HQ7zaXqW7Hu5uWZFMU4Ic0i2D
 XnPSS1fUCSIK6cjm2ewy1ZJJMOR7fwlAsARue9fLWX5QHRl0m4A2sUmwAiXIpA7W+oiQKJRKtW
 e/Q=
WDCIronportException: Internal
Message-ID: <d458f39c-9927-33e8-b200-51e7cc09f2df@opensource.wdc.com>
Date:   Mon, 24 Oct 2022 07:41:35 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH 09/21] pata: remove samsung_cf driver
Content-Language: en-US
To:     Arnd Bergmann <arnd@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     linux-kernel@vger.kernel.org, Ben Dooks <ben-linux@fluff.org>,
        Simtec Linux Team <linux@simtec.co.uk>,
        Arnd Bergmann <arnd@arndb.de>,
        Sergey Shtylyov <s.shtylyov@omp.ru>,
        Hannes Reinecke <hare@suse.de>, linux-ide@vger.kernel.org
References: <20221021202254.4142411-1-arnd@kernel.org>
 <20221021203329.4143397-9-arnd@kernel.org>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20221021203329.4143397-9-arnd@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/22/22 05:27, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> This device was only used by the smdk6410 board file that is now
> gone, so the driver can be removed as well.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Arnd,

This patch does not apply to the for-6.2 branch of libata tree. I can fix
that easily, but I am concerned about the fact that this deletes the
header file include/linux/platform_data/ata-samsung_cf.h, which has some
function declarations for gpio used under arch/arm/mach-s3c. So If I apply
this before you queue the other patches for this driver in for-next, we
may endup with build failures. No ?

> ---
>  drivers/ata/Kconfig                          |  10 -
>  drivers/ata/Makefile                         |   1 -
>  drivers/ata/pata_samsung_cf.c                | 662 -------------------
>  include/linux/platform_data/ata-samsung_cf.h |  31 -
>  4 files changed, 704 deletions(-)
>  delete mode 100644 drivers/ata/pata_samsung_cf.c
>  delete mode 100644 include/linux/platform_data/ata-samsung_cf.h
> 
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 6b446cfc3455..3b8cb7a29efd 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -1136,16 +1136,6 @@ config PATA_RZ1000
>  
>  	  If unsure, say N.
>  
> -config PATA_SAMSUNG_CF
> -	tristate "Samsung SoC PATA support"
> -	depends on SAMSUNG_DEV_IDE || COMPILE_TEST
> -	select PATA_TIMINGS
> -	help
> -	  This option enables basic support for Samsung's S3C/S5P board
> -	  PATA controllers via the new ATA layer
> -
> -	  If unsure, say N.
> -
>  config PATA_WINBOND_VLB
>  	tristate "Winbond W83759A VLB PATA support (Experimental)"
>  	depends on ISA
> diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
> index 2cca9f500649..4ee5c0761d90 100644
> --- a/drivers/ata/Makefile
> +++ b/drivers/ata/Makefile
> @@ -109,7 +109,6 @@ obj-$(CONFIG_PATA_PLATFORM)	+= pata_platform.o
>  obj-$(CONFIG_PATA_OF_PLATFORM)	+= pata_of_platform.o
>  obj-$(CONFIG_PATA_RB532)	+= pata_rb532_cf.o
>  obj-$(CONFIG_PATA_RZ1000)	+= pata_rz1000.o
> -obj-$(CONFIG_PATA_SAMSUNG_CF)	+= pata_samsung_cf.o
>  
>  obj-$(CONFIG_PATA_PXA)		+= pata_pxa.o
>  
> diff --git a/drivers/ata/pata_samsung_cf.c b/drivers/ata/pata_samsung_cf.c
> deleted file mode 100644
> index aba1536ddd44..000000000000
> diff --git a/include/linux/platform_data/ata-samsung_cf.h b/include/linux/platform_data/ata-samsung_cf.h
> deleted file mode 100644
> index fccf969dc4da..000000000000

-- 
Damien Le Moal
Western Digital Research