Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: c26+CtD+jf9mpHeFpvKmOUh9IKWRs/XbS2Ebzz/QW4MjKN5+UlaKdsS92VipKX/j8lyLtlbImv
 n3HSCFnYLflgDn0m7NPv0Nx+BCBPc5Y3V+ynAvNcqdmtvOKSg2dTN8f3qeDM60Ii5SnY1QlC1X
 IXKe38WJ1sSeNzNYIe0iinxPQTPoYyAfY4aubb3qRSdTBLryuKdpDIcjPu3oLC8QCZZLtbCNLs
 tHTr/v+oEa/J3IimFN8SIxh7T+xQy1MljzEG8Prm8Gc6Vh2SxPyc09NqfkjERE8bgBoGe90iqq
 E66UqQlPvPL2/HckhlTYtzIK
IronPort-SDR: a17Ud51/pPHwOqdBADSdW3pNHxRkxKoepb90YZZa+4JaEYdwndCx0WQeM03JnYh9PNm/Wb0DU8
 uHqqEXm23+zalIxdIagsZ3E0z9pb5byhoULhebq/yPVZy1kdPbCBJdp0jQCRKsayU4ZfXH6Lud
 dQSqnohV6ZXGnlW0K+HvEG95rUcOvslU2Jlo+VLaroka09tqYGENFrqZGNLYtRkEcWJVq81jN8
 Ky0/DwCoI3IfXFUCV7b6NgqMtwX+K6BAR9wogHxzRlZMNm8jiEdnIZBCU/Zi3cD5KheieNqLbu
 PsY=
WDCIronportException: Internal
Message-ID: <33b942d9-e589-34b7-2967-bbb939fef121@opensource.wdc.com>
Date:   Mon, 24 Oct 2022 07:43:10 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH 09/21] pata: remove samsung_cf driver
Content-Language: en-US
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
To:     Arnd Bergmann <arnd@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     linux-kernel@vger.kernel.org, Ben Dooks <ben-linux@fluff.org>,
        Simtec Linux Team <linux@simtec.co.uk>,
        Arnd Bergmann <arnd@arndb.de>,
        Sergey Shtylyov <s.shtylyov@omp.ru>,
        Hannes Reinecke <hare@suse.de>, linux-ide@vger.kernel.org
References: <20221021202254.4142411-1-arnd@kernel.org>
 <20221021203329.4143397-9-arnd@kernel.org>
 <d458f39c-9927-33e8-b200-51e7cc09f2df@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <d458f39c-9927-33e8-b200-51e7cc09f2df@opensource.wdc.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/24/22 07:41, Damien Le Moal wrote:
> On 10/22/22 05:27, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> This device was only used by the smdk6410 board file that is now
>> gone, so the driver can be removed as well.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Arnd,
> 
> This patch does not apply to the for-6.2 branch of libata tree. I can fix
> that easily, but I am concerned about the fact that this deletes the
> header file include/linux/platform_data/ata-samsung_cf.h, which has some
> function declarations for gpio used under arch/arm/mach-s3c. So If I apply
> this before you queue the other patches for this driver in for-next, we
> may endup with build failures. No ?

It may be simpler for you to take this patch ? If yes, then:

Acked-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

> 
>> ---
>>  drivers/ata/Kconfig                          |  10 -
>>  drivers/ata/Makefile                         |   1 -
>>  drivers/ata/pata_samsung_cf.c                | 662 -------------------
>>  include/linux/platform_data/ata-samsung_cf.h |  31 -
>>  4 files changed, 704 deletions(-)
>>  delete mode 100644 drivers/ata/pata_samsung_cf.c
>>  delete mode 100644 include/linux/platform_data/ata-samsung_cf.h
>>
>> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
>> index 6b446cfc3455..3b8cb7a29efd 100644
>> --- a/drivers/ata/Kconfig
>> +++ b/drivers/ata/Kconfig
>> @@ -1136,16 +1136,6 @@ config PATA_RZ1000
>>  
>>  	  If unsure, say N.
>>  
>> -config PATA_SAMSUNG_CF
>> -	tristate "Samsung SoC PATA support"
>> -	depends on SAMSUNG_DEV_IDE || COMPILE_TEST
>> -	select PATA_TIMINGS
>> -	help
>> -	  This option enables basic support for Samsung's S3C/S5P board
>> -	  PATA controllers via the new ATA layer
>> -
>> -	  If unsure, say N.
>> -
>>  config PATA_WINBOND_VLB
>>  	tristate "Winbond W83759A VLB PATA support (Experimental)"
>>  	depends on ISA
>> diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
>> index 2cca9f500649..4ee5c0761d90 100644
>> --- a/drivers/ata/Makefile
>> +++ b/drivers/ata/Makefile
>> @@ -109,7 +109,6 @@ obj-$(CONFIG_PATA_PLATFORM)	+= pata_platform.o
>>  obj-$(CONFIG_PATA_OF_PLATFORM)	+= pata_of_platform.o
>>  obj-$(CONFIG_PATA_RB532)	+= pata_rb532_cf.o
>>  obj-$(CONFIG_PATA_RZ1000)	+= pata_rz1000.o
>> -obj-$(CONFIG_PATA_SAMSUNG_CF)	+= pata_samsung_cf.o
>>  
>>  obj-$(CONFIG_PATA_PXA)		+= pata_pxa.o
>>  
>> diff --git a/drivers/ata/pata_samsung_cf.c b/drivers/ata/pata_samsung_cf.c
>> deleted file mode 100644
>> index aba1536ddd44..000000000000
>> diff --git a/include/linux/platform_data/ata-samsung_cf.h b/include/linux/platform_data/ata-samsung_cf.h
>> deleted file mode 100644
>> index fccf969dc4da..000000000000
> 

-- 
Damien Le Moal
Western Digital Research