Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <87fsfem6zd.wl-kuninori.morimoto.gx@renesas.com>
From:   Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To:     Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
Cc:     broonie@kernel.org, lgirdwood@gmail.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, perex@perex.cz, tiwai@suse.com,
        alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] ASoC: simple-card: Support custom DAI system clock IDs
In-Reply-To: <20221022162742.21671-1-aidanmacdonald.0x0@gmail.com>
References: <20221022162742.21671-1-aidanmacdonald.0x0@gmail.com>
User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0
Content-Type: text/plain; charset=US-ASCII
Date:   Sun, 23 Oct 2022 23:54:14 +0000
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BHa1fr8a4O5wPVaLf616tpIxOeTPc0isoUyzccd3EL63tYVav+Bpq2JAzA0V?=
 =?us-ascii?Q?1DHzovPAGXJkeU2dBjL1F0bEEoqVgs9/9Q56RGKM4jtn4avKSi98IrEeMQQ5?=
 =?us-ascii?Q?uNAQ33V7J9/o+XaejyXnJoGRv5MXfMPz9hRaaUmdEo3d7mk53k0i5ZJrA1iG?=
 =?us-ascii?Q?5ba46N09Ad3NJDvs4udm8cimTS9bEaQd4M5fAwLokAGNlYJIzhV/gGCynHy+?=
 =?us-ascii?Q?mCkpLy6rJ7SbZnwqRYwpNoQP005XU/eb1NW9vPoT1xjuCpZeaiAxlt7IUUh2?=
 =?us-ascii?Q?nqFQEvfUNWqgGb4YguDzUi8vN3O9pUHeZaJ46ZIp6EqOv41GxiyiWsKOJvyQ?=
 =?us-ascii?Q?VZEtHK3qDVs0hT2zd/dpBtZtv+0PDCxc91vcCFxKR8HmmXIK5Vfcary71m8g?=
 =?us-ascii?Q?E+MuOcEfr2yc/eDjG2vzb3044/JuMtfJe8JeCmjBNVaj2x4J2sIx6I7GLavw?=
 =?us-ascii?Q?RjBz+c7+QYh6Y6bJAr95/O9hqGaLtnX5mmk5ossaL9r/RoLQflE+2fgjYI+5?=
 =?us-ascii?Q?sjwtt+R9M13Uwzw0bAOiHMronAY+YW/b2jXRUuxPV92MikQ/f7PsnbVFui7p?=
 =?us-ascii?Q?avrIbjxObxTM0NTWl00UUnqJL2qTxTUzH0vz6nG3Bzd1/kjtRIPGDeDXW8ol?=
 =?us-ascii?Q?Qh+AK2qaJ8Q9aRkUnOCK9FNmZB6Mn53GIvf3EbikrVJCVW0rtk0XSk1fXxJ7?=
 =?us-ascii?Q?9VUJkZqAZwvBHP3SVoj5hQ+F01QAiW1GvWtNRXK24dGnOzGZ0eoBQ9ImHzjw?=
 =?us-ascii?Q?Xu06FdyJeBPpWDaAsJZx8KULBYXp7paCvua/8uJ/9adOIdL/o75fZbZ9tgiF?=
 =?us-ascii?Q?e+H7pHMzm/++SMcrkRT6klaNIpvuHESqyvOBp0vSew9ilRI4akOhCQY0XR38?=
 =?us-ascii?Q?9wAIyuzfzHwjlixd6EjvaHZ01RB/1P1pUoxMgpvY18aGDlhNmDz84K2atmMS?=
 =?us-ascii?Q?avLImQgd2Svcp7EYlM1BB1ehjeOkguId1bR1Aq6swIi1kHcy1MLVJnCyn7vW?=
 =?us-ascii?Q?mCJeL2+GFlUSQUrPMSQFT3W69aq8wt8SSpW5Ak1kQeKx4uLu+CTBFJLEKKi2?=
 =?us-ascii?Q?Yf33AZtKmeoVjHEplG+BY6PtI7UvvYRrIf6qPj74WNZdDpsIz4qASopupvO+?=
 =?us-ascii?Q?F8adJ+7nNE32yfcjFC9pKCMtrlHoyYLdDNTtK5BZL+QI6Aqebz7QutzFjXcX?=
 =?us-ascii?Q?dQdS2qTXnShxuE01Q+510asqsziy6uVHladp/ug2hXPbIOeCTSWrXhUO9xCi?=
 =?us-ascii?Q?A70cCgnijBBjEOhptdKQ3MyTX/D3q4FsOlFn9s1RsGF/PxVkSOq0w3IAoYHj?=
 =?us-ascii?Q?V63GrH2teGho7Y5mmq84LVDUpRKLieUQc4/l97DWUF8jPCONwAXpKN1tyFDx?=
 =?us-ascii?Q?UBg+gJzIv2WynZTkvKavbzYJWWSEUy3m3a9RDQhmD4fnVhMqpftPDt1f6wzB?=
 =?us-ascii?Q?Qhux6dH165CoUUiIH5rIJN0eOPenbDPgeVG5CuWrNqtaYnjJINGOfrlk6zUL?=
 =?us-ascii?Q?oLk9hrxaHvYiYNR6ZC60GFeLA/HpRLjiiqfoKDVcDIm5SyESnkFIJvmBuBP9?=
 =?us-ascii?Q?znFYIMefkuY9WJwvCTNaCMqQaadO07YJBOw9kZh3h2m+fXVepab6oQQGV8yG?=
 =?us-ascii?Q?ztThJ/XV3LYuOnTBDip4Nqg=3D?=
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6e01735e-eac2-4f6c-5bbb-08dab551e3ec
X-MS-Exchange-CrossTenant-AuthSource: OS3PR01MB8426.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2022 23:54:15.2085
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MAdBa97dwtc/XtdFB7kXuEr/uPn/BvAOyZpxJGbOKt8luy3dgctPwGXtVasp7Ikl/sjuFJND3K6IkTEqHl0SCGms1tJ/xUiAWmzP3lw5razh8u6J4R2guz6px1rQ0n+D
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWPR01MB10521
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi Aidan

Thank you for your patch

> Some DAIs have multiple system clock sources, which can be chosen
> using the "clk_id" argument to snd_soc_dai_set_sysclk(). Currently
> this is hardcoded to 0 when using simple cards, but that choice is
> not always suitable.
> 
> Add the "system-clock-id" property to allow selecting a different
> clock ID on a per-DAI basis.
> 
> To simplify the logic on DPCM cards, add a dummy "asoc_simple_dai"
> instance and use that for the dummy components on DPCM links. This
> ensures that when we're iterating over DAIs in the PCM runtime there
> is always a matching "asoc_simple_dai" we can dereference.
> 
> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
> ---

I think adding "system-clock-id" and adding "dummy asoc_simple_dai" are
different topics. This patch should be separated into 2 patches.

And I couldn't understand the reason why we need to add dummy asoc_simple_dai.
In my understanding, we don't parse DT for dummy connection.
Which process are you talking about specifically here?

	This ensures that when we're iterating over DAIs in the PCM runtime there
	is always a matching "asoc_simple_dai" we can dereference.
- 
Thank you for your help !!

Best regards
---
Kuninori Morimoto