Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221024015510.1917-1-angus.chen@jaguarmicro.com>
 <CACGkMEsag0xGcGxPnaou3wiO8iJBL4Pxecj6Vd-KEN7otQX5aQ@mail.gmail.com> <TY2PR06MB342493C73F9119E847765796852E9@TY2PR06MB3424.apcprd06.prod.outlook.com>
In-Reply-To: <TY2PR06MB342493C73F9119E847765796852E9@TY2PR06MB3424.apcprd06.prod.outlook.com>
From:   Jason Wang <jasowang@redhat.com>
Date:   Mon, 24 Oct 2022 10:17:22 +0800
Message-ID: <CACGkMEsVP8qwT5aOqvwp-YjswT59Ctu6jDfYPBftzbn_wb7ZzA@mail.gmail.com>
Subject: Re: [PATCH v2] vDPA: rename get_vq_num_max to get_vq_size_max
To:     Angus Chen <angus.chen@jaguarmicro.com>
Cc:     "mst@redhat.com" <mst@redhat.com>,
        "virtualization@lists.linux-foundation.org" 
        <virtualization@lists.linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "lingshan.zhu@intel.com" <lingshan.zhu@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Oct 24, 2022 at 10:16 AM Angus Chen <angus.chen@jaguarmicro.com> wr=
ote:
>
> Hi Jason
>
> > -----Original Message-----
> > From: Jason Wang <jasowang@redhat.com>
> > Sent: Monday, October 24, 2022 10:01 AM
> > To: Angus Chen <angus.chen@jaguarmicro.com>
> > Cc: mst@redhat.com; virtualization@lists.linux-foundation.org;
> > linux-kernel@vger.kernel.org; lingshan.zhu@intel.com
> > Subject: Re: [PATCH v2] vDPA: rename get_vq_num_max to get_vq_size_max
> >
> > On Mon, Oct 24, 2022 at 9:56 AM Angus Chen <angus.chen@jaguarmicro.com>
> > wrote:
> > >
> > > The get_vq_num_max of vdpa_config_ops is mean get the max size of vq,=
not
> > > the max number of vq,it is kind of confused,rename it.
> > > And get_vq_num_min rename to get_vq_size_min,
> > > set_vq_num rename to set_vq_size,
> > > rename implement of this ops also.
> > >
> > > Signed-off-by: Angus Chen <angus.chen@jaguarmicro.com>
> > > ---
> >
> > Not a native sparker. But num_max came from virtqueue structure:
> >
> > /*
> >  ...
> >  * @num_max: the maximum number of elements supported by the device.
> >  ...
> >  */
> >
> > struct virtqueue {
> >         ...
> >         unsigned int num_max;
> I noticed this also=EF=BC=8Cand I always confused by the definition. Take=
 virtio_pci_common_cfg for example:
>
> /* Fields in VIRTIO_PCI_CAP_COMMON_CFG: */
> struct virtio_pci_common_cfg {
>         ...
>     __le16 num_queues;      /* read-only */
>
> It just a suggestion.
> Thank you.

Let's hear from the others then decide.

Thanks

> >         ...
> > };
> >
> > Thanks
>