Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Oct 2022 10:04:41 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     linux-kbuild@vger.kernel.org,
        Johannes Zink <j.zink@pengutronix.de>,
        Ariel Marcovitch <arielmarcovitch@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kconfig: fix segmentation fault in menuconfig search
Message-ID: <Y1YAyQ4s+wxfAPAU@debian.me>
References: <20221023191055.85098-1-masahiroy@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="PFpEuUJq57bt2SZs"
Content-Disposition: inline
In-Reply-To: <20221023191055.85098-1-masahiroy@kernel.org>
Precedence: bulk


--PFpEuUJq57bt2SZs
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Oct 24, 2022 at 04:10:55AM +0900, Masahiro Yamada wrote:
> Since commit d05377e184fc ("kconfig: Create links to main menu items
> in search"), menuconfig shows a jump key next to "Main menu" if the
> nearest visible parent is the rootmenu. If you press that jump key,
> menuconfig crashes with a segmentation fault.
>=20
> For example, do this:
>=20
>   $ make ARCH=3Darm64 allnoconfig menuconfig
>=20
> Press '/' to search for the string "ACPI". Press '1' to choose
> "(1) Main menu". Then, menuconfig crashed with a segmentation fault.

You missed the prerequisites: search EFI and press 1 to jump to
CONFIG_EFI.

>=20
> The following code in search_conf()
>=20
>     conf(targets[i]->parent, targets[i]);
>=20
> results in NULL pointer dereference because targets[i] is the rootmenu,
> which does not have a parent.
>=20
> Commit d05377e184fc tried to fix the issue of top-level items not having
> a jump key, but adding the "Main menu" was not the right fix.
>=20
> The correct fix is to show the searched item itself. This fixes another
> weird behavior described in the comment block.
>=20
> Fixes: d05377e184fc ("kconfig: Create links to main menu items in search")
> Reported-by: Johannes Zink <j.zink@pengutronix.de>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> Link: https://lore.kernel.org/r/20221023191055.85098-1-masahiroy@kernel.o=
rg

Missing Cc: stable? The segfault (IMO) appears after v5.15, so all
supported stable branches are affected.

Anyway, the segfault gone away with this patch applied. Thanks.

Tested-by: Bagas Sanjaya <bagasdotme@gmail.com>

--=20
An old man doll... just what I always wanted! - Clara

--PFpEuUJq57bt2SZs
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCY1YAxAAKCRD2uYlJVVFO
o2HWAQCc8AnxqmRk7EXDCw/tGNQvDKVAAcBJxEwn0+m5LiNlKgEA8X42VnAZRZRu
vsjQyQZtBJWTWn+v2wPuOLCMP+wTpwc=
=x7fI
-----END PGP SIGNATURE-----

--PFpEuUJq57bt2SZs--