Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Oct 2022 06:08:42 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Bagas Sanjaya <bagasdotme@gmail.com>
Cc:     Deepak R Varma <drv@mailo.com>, outreachy@lists.linux.dev,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: wlan-ng: remove commented debug printk
 messages
Message-ID: <Y1YPypVbN5v18uni@kroah.com>
References: <Y1L0FiKvrM9jjZG9@debian-BULLSEYE-live-builder-AMD64>
 <Y1VDM2kWIi1I5dqI@debian.me>
 <Y1VL/wITM64U6qLi@kroah.com>
 <4863c6d7-ffdd-1304-981b-9b0644a87f4e@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4863c6d7-ffdd-1304-981b-9b0644a87f4e@gmail.com>
Precedence: bulk

On Mon, Oct 24, 2022 at 10:08:00AM +0700, Bagas Sanjaya wrote:
> On 10/23/22 21:13, Greg KH wrote:
> >>> @@ -1007,7 +986,6 @@ static int p80211_rx_typedrop(struct wlandevice *wlandev, u16 fc)
> >>>  			wlandev->rx.cfack_cfpoll++;
> >>>  			break;
> >>>  		default:
> >>> -			/* printk("unknown"); */
> >>>  			wlandev->rx.data_unknown++;
> >>>  			break;
> >>>  		}
> >>
> >> Shouldn't these printks be guarded under CONFIG_DEBUG_KERNEL instead?
> > 
> > No, they should just be removed as was done here.
> > 
> 
> What if in case of debugging without these printks?

I can not parse this line, sorry.