Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <yuji2.ishikawa@toshiba.co.jp>
To:     <posciak@chromium.org>, <paul.kocialkowski@bootlin.com>,
        <hverkuil-cisco@xs4all.nl>, <mchehab+samsung@kernel.org>,
        <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Question for an accepted patch: use of DMA-BUF based videobuf2
 capture buffer with no-HW-cache-coherent HW
Thread-Topic: Question for an accepted patch: use of DMA-BUF based videobuf2
 capture buffer with no-HW-cache-coherent HW
Thread-Index: AdjnYKQwg5kJk8s9S/Cvff5NBTRsiQ==
Date:   Mon, 24 Oct 2022 04:27:26 +0000
Message-ID: <TYAPR01MB6201716571D23E09CC436555922E9@TYAPR01MB6201.jpnprd01.prod.outlook.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?TXRCSGNpaEducHUxcVpaTVBvTHZZRFdYZWUyRGMzbVVQSDM3OUF0N3lN?=
 =?iso-2022-jp?B?RXc0eEE0dDBrNWFoZHVhYUs5aS9LcFZPb25EQ1NvYXQ4MVZoQjRycFBj?=
 =?iso-2022-jp?B?dWs4dFJoMTRGSU1zNHhRTFdYYU4xMGRRNzlmbi9LUE9ucURSTzRpSFJB?=
 =?iso-2022-jp?B?Rk42bmNPVVBOQ2RrMnk2ZUpnSGorYlVOOTRYbGtaaERaZ29YeS8yZ25E?=
 =?iso-2022-jp?B?ZmdEYjlQZDlsM25ab0ZuSzhGNU5sZmFMRlord1Y2aGlxVWFvdEZ5MU1I?=
 =?iso-2022-jp?B?M08xeVlNZGFsLzc3amlqQWlzWGhFaW84Vy82S29LZ2xvY28xS3J3MFRl?=
 =?iso-2022-jp?B?SFNrNHYxZFJrQ3JDS0N2RmZIOXZaMXVqdnJnOGtLcktpWSsxYzJuakZr?=
 =?iso-2022-jp?B?QlNRTVdHYmlCWDRjekhMbFRJSGRWOU1QcWZRUEdaYVYwR25HT1pHd0Ix?=
 =?iso-2022-jp?B?Mm5KcnVjR2xFSkdBMS81NHZrTjZsSTBORjBNQks5YUdIUEV1UVBvaE5N?=
 =?iso-2022-jp?B?dU4rUmVnL0g2R29KNTFlWGh5dFZRV1pqaVNOSElKb1h2SkdCV3FzRllS?=
 =?iso-2022-jp?B?bkFwTm96M0E5Zzl6UVVUc0g3aklGVjhzQm9lcm1LclJPVk83eDJ5Y0tC?=
 =?iso-2022-jp?B?bmZsVEtyYlRpdmpERGNwTHN0S2o3bjNCSUltRHdQNnkwM0taQ1lKRTEx?=
 =?iso-2022-jp?B?VW0vMTlLQXJ5UFZOMzR1VUtVT1pIZkN3TlVxUVVGSEpzUmppczhlcDRw?=
 =?iso-2022-jp?B?ZmZ5eFdhQ1F3Qkdsb0I3S0pDQnJnTEZHY1UwZzJ3UGltdGpDem9tSFda?=
 =?iso-2022-jp?B?dWUyNW1ueWEvUWpNUUJHcmpLV2tmc1JDSFdSdXQwZWJzbzBmT0dwdHlW?=
 =?iso-2022-jp?B?WDd6RXhkVldEMktLV0hkVmhUN3E5VjZqN1prY1RFUmViVE41dnRiZEl1?=
 =?iso-2022-jp?B?U2hVU2xlMk1KZk1VN3lrWFBCQVZ0Y29NWWw1NXdiZStUR1ViM1VsbjFk?=
 =?iso-2022-jp?B?R3oveFRSQW1nTVc4SlpGWXBYSzM1ODd2QUY0T3VpL3R2T05NN0M1Ukto?=
 =?iso-2022-jp?B?b3o3MUQ1bFBCQTNTczBLOWRxWUczZFZVL2xRU3g2d01oRGt6OWtUZFNv?=
 =?iso-2022-jp?B?aW9kRndUWTJxV1d6cFViS3dXOFpFK2h5am03c1lJZU9SSzkzckxsWDNL?=
 =?iso-2022-jp?B?bWJ1dndiZUVNL2xYRmdpUXNGZTJjN3I5SUwvZDBZcGJJQ0J1T1Vpc0xz?=
 =?iso-2022-jp?B?dzVLeExCL1lSRmNIYjd0RmFIaXJjbGc0YVowMWdBVEVaellhNkowamRK?=
 =?iso-2022-jp?B?TU5WaUk0M3RGUlh2UW1rS3lMTzY0NlJWNzNmUkd2VjZqOVhrZ1lFZGJt?=
 =?iso-2022-jp?B?MmFick4wMjNjVG91QU40cmdmekxxVzNTblZZQThSQ0V5TmMxVitzWTl1?=
 =?iso-2022-jp?B?MWxuWXJTaFQrNXg1YVdOTEFaSlJKaTVjdE5maE53YVMxL0cwU2NSUncw?=
 =?iso-2022-jp?B?ejZ3VDhmKzd0czdTMFRiQU93cDFxRXhRN01SVFg4ZDhTd2NnZFZmaFE2?=
 =?iso-2022-jp?B?ZG9KRTloZGZ4K1pyNElnU2IrSFVkdXpYaW5aRy8zSHlpeXBXYXRjNmtT?=
 =?iso-2022-jp?B?VnV1WG9xb0lObUlSSGYySU1nc3lzbjFmYkZRMThnZk1KaDFNNE4yeXE0?=
 =?iso-2022-jp?B?d0JNV09maFNoc3dKTDUzOStOeUNlQU8wS3R5MkpnVzFGV3pJWDdOU1Va?=
 =?iso-2022-jp?B?ZFZFQWQvOXM5YjJDc2doS0RXNFRmdkdydDQ5c0JybFJsM0t0elB1ZXh2?=
 =?iso-2022-jp?B?ZFE3V0doMkpYWXo2NStPNTU4WlowZThHWStVbUlCSGM5TGNlTEZ5aDVy?=
 =?iso-2022-jp?B?bjhyYTVVU0krYk1obzlmN0xacTJEK3pNem5XTXY3Q1RjWDBsMTBxT0Rk?=
 =?iso-2022-jp?B?RFFkZzkyK2EzQjB2Zk9FdVI3Ny92UWNVMDRmTXFwc0JFaU40UUh1OHZX?=
 =?iso-2022-jp?B?Q2dScHZtdUI4QVdIOWRHRWM4Y1pIeFAwU2VZZjVRS25rZHBXWUtwOUh6?=
 =?iso-2022-jp?B?MHhlYisvU0QvUU9hK2RxdlR3elEyR040TDd4bGlFeGtaTWxjdkdUeUlv?=
 =?iso-2022-jp?B?TGp3aElvU2NkS0hBNGVsLzkzMU1KR3JpWnNrY1J6N1BHZEJTckpGcXBQ?=
 =?iso-2022-jp?B?cXh3NEhrd1VSNEhSNitxNXYzVDBmUVowT3ZpVUZ1S1loRzZLd09ISCtB?=
 =?iso-2022-jp?B?d1UzeHFaYmxJOGJGRDVTTmFMM0dEZGZYcWVudGg3OE5NcGNKWEd6RlR3?=
 =?iso-2022-jp?B?MklHZlRHVGdTY1B1Z2xnNDU3eG5wUlNaMVE9PQ==?=
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYAPR01MB6201.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 90ed0f6b-9488-4212-51d5-08dab5780e06
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Oct 2022 04:27:26.1876
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f109924e-fb71-4ba0-b2cc-65dcdf6fbe4f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JnfWscJOlF4eUp1tyPRvNk/G9b3TdvwbtHIdtsHonVf6yCondHKWeMSf40HFCVht2cLLA4vafrgPctwzyg2OUZyv7/nr6l4QwTmfNC5xSgM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB5992
X-OriginatorOrg: toshiba.co.jp
MSSCP.TransferMailToMossAgent: 103
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,
I'm porting a V4L2 capture driver from 4.19.y to 5.10.y [1].
When I test the ported driver, I sometimes find a corruption on a captured image.
Because the corruption is exactly aligned with cacheline, I started investigation from map/unmap of DMA-BUF.

The capture driver uses DMA-BUF for videobuf2.
The capture hardware does not have HW-mantained cache coherency with CPU, that is, explicit map/unmap is essential on QBUF/DQBUF.
After some hours of struggle, I found a patch removing cache synchronizations on QBUF/DQBUF.

https://patchwork.kernel.org/project/linux-media/patch/20190124095156.21898-1-paul.kocialkowski@bootlin.com/

When I removed this patch from my 5.10.y working-tree, the driver yielded images without any defects.

***************
Sorry for a mention to a patch released 4 years ago.
The patch removes map/unmap on QBUF/DQBUF to improve the performance of V4L2 decoder device, by reusing previously decoded frames.
However, there seems no cares nor compensations for modifying lifecycle of DMA-BUF, especially on video capture devices.

Would you tell me some idea on this patch:
* Do well-implemented capture drivers work well even if this patch is applied?
* How should a video capture driver call V4L2/videobuf2 APIs, especially when the hardware does not support cache coherency?

***************
[1] FYI: the capture driver is not on mainline yet; the candidate is,
https://lore.kernel.org/all/20220810132822.32534-1-yuji2.ishikawa@toshiba.co.jp/

***************
Sorry for sending the same email message again. I wrongly posted previous one with HTML format.

Regards,
              Yuji Ishikawa