Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Oct 2022 09:35:23 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Kang Minchul <tegongkang@gmail.com>
Cc:     Larry Finger <Larry.Finger@lwfinger.net>,
        Phillip Potter <phil@philpotter.co.uk>,
        Pavel Skripkin <paskripkin@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] staging: r8188eu: remove unnecessary variable in
 rtw_recv
Message-ID: <Y1YyK7YYshq1nayg@kadam>
References: <20221023200532.259276-1-tegongkang@gmail.com>
 <20221023200532.259276-3-tegongkang@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221023200532.259276-3-tegongkang@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4ANfy5htSHUt4n9ZaJ4XhKsVjJ7+CGCMgLI06a1cpaQ4W47/IMqOwSJoiSsN?=
 =?us-ascii?Q?xyHgKHNArkQXZU49bAFH3/ihrFdwaNF6okmAfIkkL+PO5MZkBvxmpGlEZSTS?=
 =?us-ascii?Q?a8uc1xzOa+hoZBTTDaf2IGF1Ma7Oke3PCPXPeCpqFCJ0CUVRksdCWlbzyOYy?=
 =?us-ascii?Q?nqIuEXkE2ysRmsGV/WP73PSnv3aLgf0DEErDCr2oDF2X22/mVQWHRCqbRIbk?=
 =?us-ascii?Q?6RBX4OaMzNZTtAE2fYrayoPJJv0VcZBK1LaDMK74JUWlikwbtEzpoMlKGKuE?=
 =?us-ascii?Q?1Z3FzneCZjbpzEs/hqVTi6KW1S9JefSRkoV2oBBzVwv+TdMsQ4CzeYCJqpxm?=
 =?us-ascii?Q?2Q1qFYOIPaIFSOAbwWWb9TWPf3WEhjcXDkEL9n8OiIB7d4GxcphMvvzb3VRM?=
 =?us-ascii?Q?h6aX+ZlNOg+HAlY2DgStz/iF3c8aAgbN6w1BMLzhXPHKpYN+JkE8lcAgdX8Q?=
 =?us-ascii?Q?OZhH8qDcSyIs6Nir6mnXOGIWWgqo0qlE5dvZBAzfwxL6bNyBIoWmY+RwVmMi?=
 =?us-ascii?Q?H1DDnpKpEGPWLYR1ZKs0UDLad7vvKoXgg029Z3lu/3fpaIrW9/iV/FTx7+U3?=
 =?us-ascii?Q?i6LKFaKig5oTMv3bkvbDGj9ikzOFeTRp21O0ITKm5SxzgpLKEAfUm/5TCtmT?=
 =?us-ascii?Q?nl5bY5UUS6Wp6OEhQlW/72rpdeJ4LWaaQ+ATQCxWQhvkJ9uPLOrJXZiW09xN?=
 =?us-ascii?Q?eo+JwtDInhI7aQFhmoMiVk4WNPmcJGOLWiawT9IPbjK6CWF+l6ec4FRloXgU?=
 =?us-ascii?Q?GbVWJk9fXcP7mgN4HnxdDnBGJu1K/AJLzmxDHbFeLSdpjgCIeeAszH+CQCnf?=
 =?us-ascii?Q?6awFhxwHqglN2FF/AKnVsGMa7Q4Tnt2ln0rjdFTU5sWyM3N1vyNRfG7IfulV?=
 =?us-ascii?Q?tzvZOCjzFirx47OjKROxeRBmQtQQgoTu/nr1P7eFR4FpCKpI+5MjDoLOcXjO?=
 =?us-ascii?Q?l9NDElR6OFd1PkkXT7fRLKLPHAZ6StvUmPdsVQONiSEsf89tyCzWO2N91iGs?=
 =?us-ascii?Q?lWKhT9pVcZ7fFAggvSk+v8mZy5ShQPrYsUeDG8USer75aKoLbmerYl2K0jUE?=
 =?us-ascii?Q?lZpYm8xKLXkgsdQlcSOqoXCv1pmmryrzXUsmXdiaM2k1WjNC2UNOyTVN98o4?=
 =?us-ascii?Q?qy1t3ylysGs43XiZsJ2slHkMBA3F6SA9p98apypL/nRksiqT1W1Um+iiFgx+?=
 =?us-ascii?Q?ODME5M9/MA/3R7t/lK1DamzpqRga6capNHUtOEimH5NArN+l4SDATP36zhSE?=
 =?us-ascii?Q?mSxGoSU71smVnQH+FGhSROG90x7D0oFspIU1iUs9+bjhb/ALWO7ikH74M58M?=
 =?us-ascii?Q?am5N/aIN3xWyYraomREI4kMgjIUMscYIm4XRUDSIqLql991qwGNmRzf3E9oD?=
 =?us-ascii?Q?wWEIW1rmUBkRJsRiW7oIIvaGGsl3VMs3uWkwo5Ba+K9RBcnAQbdu1xGiQZbL?=
 =?us-ascii?Q?j2cG89LtrGwyk6fDx3ixbS/pFs2gG10dbeqbg/wleOnxfCRvgaR3ieFHtPcw?=
 =?us-ascii?Q?JSnbgWnws4DuVaDoiaksf9FObTXf537/XtvIKQXCLoI1g60N9TxhdKpfzweW?=
 =?us-ascii?Q?G6zrSXKI8W2sblK1u+7IZg5nmkytwnecYxDIFWm029v2PrRrDiG2mkH0sV4C?=
 =?us-ascii?Q?xA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 96e59966-b62f-4e25-caf6-08dab589f801
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 06:35:40.6266
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6cRszhfbxBPA+l4NbMkiqk+BBErjNAEBwY/qDGnOPQ5QzwEWvG/G3ssJTm+HPk9iKPiiwzxjg+Fadiv5i7DxZYQmawovA67S4feUiu4Sih0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4743
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-23_02,2022-10-21_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=853 bulkscore=0
 suspectscore=0 malwarescore=0 phishscore=0 mlxscore=0 spamscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210240041
X-Proofpoint-GUID: peFmB1J0TEnIjNo7ENyhiAE8aba4JK_2
X-Proofpoint-ORIG-GUID: peFmB1J0TEnIjNo7ENyhiAE8aba4JK_2
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 24, 2022 at 05:05:30AM +0900, Kang Minchul wrote:
> Return _SUCCESS directly instead of storing it in a variable.
> This can prevent cocci warning as follows:
> 
>   Unneeded variable: "ret". Return "_SUCCESS" on line 1516
> 
> Signed-off-by: Kang Minchul <tegongkang@gmail.com>

Make the function void instead.

regards,
dan carpenter