Subject: Re: [PATCH] FRV: Make BSG declarations dependent on CONFIG_BLOCK
From: James Bottomley <James.Bottomley@SteelEye.com>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@osdl.org, akpm@osdl.org, jens.axboe@oracle.com,
       linux-kernel@vger.kernel.org
In-Reply-To: <28317.1185979496@redhat.com>
References: <1185976630.3468.73.camel@localhost.localdomain>
	 <20070801091353.10608.32356.stgit@warthog.cambridge.redhat.com>
	 <28317.1185979496@redhat.com>
Content-Type: text/plain
Date: Wed, 01 Aug 2007 12:30:21 -0500
Message-Id: <1185989421.3468.94.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1033
Lines: 25

On Wed, 2007-08-01 at 15:44 +0100, David Howells wrote:
> James Bottomley <James.Bottomley@SteelEye.com> wrote:
> 
> > Are you sure you're testing with git head?  CONFIG_BLK_DEV_BSG cannot be
> > set unless CONFIG_BLOCK is (which was a bug in previous releases now
> > fixed in git head ... unless the fix has gone wrong?).
> 
> Neither CONFIG_BLK_DEV_BSG nor CONFIG_BLOCK are set.  The problem is that the
> stub BSG functions refer to undefined structures when CONFIG_BLOCK=n.

Hmm, then isn't the fix to add a struct request_queue; and other
definitions above the stub functions?

What is the file that's causing this actual problem ... as in what still
needs to pull in the block headers if CONFIG_BLOCK=n (or more properly,
could it also need to use the bsg stub functions?)

James


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/