Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Oct 2022 12:54:21 +0530
From:   Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     <netdev@vger.kernel.org>, <davem@davemloft.net>, <kuba@kernel.org>,
        <linux-kernel@vger.kernel.org>, <lxu@maxlinear.com>,
        <hkallweit1@gmail.com>, <pabeni@redhat.com>, <edumazet@google.com>,
        <linux@armlinux.org.uk>, <UNGLinuxDriver@microchip.com>,
        <Ian.Saturley@microchip.com>
Subject: Re: [PATCH net-next] net: phy: mxl-gpy: Add PHY Auto/MDI/MDI-X set
 driver for GPY211 chips
Message-ID: <20221024072421.GB653394@raju-project-pc>
References: <20221021100305.6576-1-Raju.Lakkaraju@microchip.com>
 <Y1KmL7vTunvbw1/U@lunn.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <Y1KmL7vTunvbw1/U@lunn.ch>
Precedence: bulk

Hi Andrew,

Thank you for review comments.

The 10/21/2022 16:01, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> > +static void gpy_update_mdix(struct phy_device *phydev)
> > +{
> > +     int ret;
> > +
> > +     ret = phy_read(phydev, PHY_CTL1);
> > +     if (ret < 0) {
> > +             phydev_err(phydev, "Error: MDIO register access failed: %d\n",
> > +                        ret);
> > +             return;
> > +     }
> 
> > @@ -413,6 +490,8 @@ static void gpy_update_interface(struct phy_device *phydev)
> >
> >       if (phydev->speed == SPEED_2500 || phydev->speed == SPEED_1000)
> >               genphy_read_master_slave(phydev);
> > +
> > +     gpy_update_mdix(phydev);
> 
> Do you know why gpy_update_interface() is a void function? It is
> called from gpy_read_status() which does return error codes. And it
> seems like gpy_read_status() would benefit from returning -EINVAL, etc.

Do you want me to change gpy_update_interface() return type ?
Can I do those changes as part of this commit or need to fix on "net"
branch ?

> 
>       Andrew

-- 
--------
Thanks,
Raju