Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Oct 2022 14:59:15 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Li kunyu <kunyu@nfschina.com>
Cc:     krisman@collabora.com, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] unicode: mkutf8data: Add malloc allocation check
Message-ID: <Y1ZF040OJaJ31doE@debian.me>
References: <20221024045150.177521-1-kunyu@nfschina.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="8aHSJs7T8SNboEuL"
Content-Disposition: inline
In-Reply-To: <20221024045150.177521-1-kunyu@nfschina.com>
Precedence: bulk


--8aHSJs7T8SNboEuL
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Oct 24, 2022 at 12:51:50PM +0800, Li kunyu wrote:
> Increase the judgment of malloc allocation, and return NULL if the
> condition is met.
>=20
> Signed-off-by: Li kunyu <kunyu@nfschina.com>
> ---
>  fs/unicode/mkutf8data.c | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/fs/unicode/mkutf8data.c b/fs/unicode/mkutf8data.c
> index e06404a6b106..a929ddf1438c 100644
> --- a/fs/unicode/mkutf8data.c
> +++ b/fs/unicode/mkutf8data.c
> @@ -495,6 +495,9 @@ static struct node *alloc_node(struct node *parent)
>  	int bitnum;
> =20
>  	node =3D malloc(sizeof(*node));
> +	if (!node)
> +		return NULL;
> +
>  	node->left =3D node->right =3D NULL;
>  	node->parent =3D parent;
>  	node->leftnode =3D NODE;

What?

This is not "malloc judgement", but rather return NULL if node fails to
allocate.

Please, please reword the patch description.

Thanks.

--=20
An old man doll... just what I always wanted! - Clara

--8aHSJs7T8SNboEuL
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCY1ZF0wAKCRD2uYlJVVFO
o+NuAP9Yd3rapanReflkP3Ipd3eMM7Fi+VtoWwz62FI2bQavdAEAsKLyMkVadxgJ
HX1uqDw05+4qYGzxB4VhFksevfugews=
=lKLi
-----END PGP SIGNATURE-----

--8aHSJs7T8SNboEuL--