Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Oct 2022 15:11:19 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Li zeming <zeming@nfschina.com>
Cc:     masahiroy@kernel.org, linux-kbuild@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lxdialog: menubox: Add malloc allocation judgment
Message-ID: <Y1ZIp1ZAu0VzQ9Wf@debian.me>
References: <20221024055629.178198-1-zeming@nfschina.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="Jqf5YcVbJ9H+Bg3q"
Content-Disposition: inline
In-Reply-To: <20221024055629.178198-1-zeming@nfschina.com>
Precedence: bulk


--Jqf5YcVbJ9H+Bg3q
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Oct 24, 2022 at 01:56:29PM +0800, Li zeming wrote:
> Add menu_item Only when the pointer judges that the pointer is valid
> can function code be executed.
>=20

The if block isn't "judgement", but conditional.

What if menu_item fails to be allocated?

--=20
An old man doll... just what I always wanted! - Clara

--Jqf5YcVbJ9H+Bg3q
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCY1ZIogAKCRD2uYlJVVFO
o0G7AQC+JNmvgd7Xtavhg1fIdqeBIRUmO5VQgsGYeJuzy31GuQD/dxyjt1FHNdlH
d/Ywux2565vF+dIYBI9ql9phYyVoiAw=
=+AEF
-----END PGP SIGNATURE-----

--Jqf5YcVbJ9H+Bg3q--