Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Oct 2022 14:56:28 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Li kunyu <kunyu@nfschina.com>
Cc:     krisman@collabora.com, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] unicode: mkutf8data: Add compound malloc function
Message-ID: <Y1ZFLO98zNoAgniW@debian.me>
References: <20221024045030.177438-1-kunyu@nfschina.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="sDFdsZx+99thmPxE"
Content-Disposition: inline
In-Reply-To: <20221024045030.177438-1-kunyu@nfschina.com>
Precedence: bulk


--sDFdsZx+99thmPxE
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Oct 24, 2022 at 12:50:30PM +0800, Li kunyu wrote:
> The patch has the following modifications.
> 1. Add unicode_data_malloc function, which realizes the combined use of
> malloc and memcpy, and assigns values to dst.
> 2. Add unicode_data_remalloc function assigns 0 to the data in the
> allocated memory pointer. When the integer free parameter specifies 1,
> execute free (* dst), and finally assign the value to dst.
> 3. Remove the original um pointer related code and replace it with these
> two functions.
>=20

These changes should be split into separate patches.

Also, please take a time to review the patch description because what I
read above is somewhat confusing.

And the last, please learn how to use git-format-patch(1) and
git-send-email(1) correctly.

Thanks.

--=20
An old man doll... just what I always wanted! - Clara

--sDFdsZx+99thmPxE
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCY1ZFJgAKCRD2uYlJVVFO
o1tBAQDwKcOlq0JzuNcNkJwSJ+z+jSIrFDjUUSEmst/w6+/sRAD/QZLv948kpqlF
MELLTE9UeUW+RBSMxJR3O3F8O+oKVgs=
=j9Vn
-----END PGP SIGNATURE-----

--sDFdsZx+99thmPxE--