Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221024053711.696124-1-dzm91@hust.edu.cn> <Y1ZIc51hxE4iV70a@smile.fi.intel.com>
In-Reply-To: <Y1ZIc51hxE4iV70a@smile.fi.intel.com>
From:   Dongliang Mu <mudongliangabcd@gmail.com>
Date:   Mon, 24 Oct 2022 16:43:37 +0800
Message-ID: <CAD-N9QWhXWNjuzf+f+bOup2GF_HRzSvRDiajdsHDKu1yke+qgg@mail.gmail.com>
Subject: Re: [PATCH] can: mcp251x: fix error handling code in mcp251x_can_probe
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Dongliang Mu <dzm91@hust.edu.cn>,
        Wolfgang Grandegger <wg@grandegger.com>,
        Marc Kleine-Budde <mkl@pengutronix.de>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
        Oliver Hartkopp <socketcan@hartkopp.net>,
        =?UTF-8?Q?Stefan_M=C3=A4tje?= <stefan.maetje@esd.eu>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        =?UTF-8?Q?Sebastian_W=C3=BCrl?= <sebastian.wuerl@ororatech.com>,
        =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>, linux-can@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Oct 24, 2022 at 4:16 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Mon, Oct 24, 2022 at 01:37:07PM +0800, Dongliang Mu wrote:
> > In mcp251x_can_probe, if mcp251x_gpio_setup fails, it forgets to
> > unregister the can device.
> >
> > Fix this by unregistering can device in mcp251x_can_probe.
>
> Fixes tag?

Fixes: 2d52dabbef60 ("can: mcp251x: add GPIO support")

This commit adds the mcp251x_gpio_setup function, but with an incorrect label.

>
> --
> With Best Regards,
> Andy Shevchenko
>
>