Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp6502745rwi; Mon, 24 Oct 2022 02:14:05 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6/qIXLElgZbtHpC+IL0z/QWfLX6ZCx/ca1r59V662bc7uyW4e9o3Eg3hwXYlM+tIDKRCgq X-Received: by 2002:a17:90b:19ca:b0:212:d2c4:83ac with SMTP id nm10-20020a17090b19ca00b00212d2c483acmr17732334pjb.166.1666602845687; Mon, 24 Oct 2022 02:14:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666602845; cv=none; d=google.com; s=arc-20160816; b=FyTQHMzl33Hni+tOUArW/HLi077fc88C4FpPxRJm2dxuISdGx7MbJvbqm4jMbXggT5 RRxacC3sQY3DQhHLXCnFHjjMdLku8XOSVl6rhGNfU8pB8EcMxG4Tfhz1T3dsmBzJ0PXv kweM6JXj18v4bGROfNW6DTOcvbHEPvjm0jXyp38SN4LHQzCD1QsFFefKrYYNadcYdctw Gb+3f2YAqSgL1D7IoFuwBYsTZtP1vUku9/FooHow85aETYM0+t4vhtEA8zOgY9wL2o+V i9XbtAENHSLIYTuZkTy4KbzvNK61JrH2BQ1Oe7awAA23mx9tESgApL/tB9EHwmJIDeIU Y5FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=yie0c3jpnN0u+kJDDHCQMcyossMGUcrvLosaw06VCXU=; b=F9mN2CV32n24F+Xpz7eidUcTQ3UPjAyWIVdK66MrN28gw9SQrAX3NXboKhas0lgJMx cvMoQMFgYHuNnYb75SOr7MhlfFPoVOE/KmaD16XQ5rA+zmuipfwH0fn75yvxWBsXKXqe TP0YTg+0iHSd/teA1rMD5/FP/73AamLY6CKg+T1v53zI0wH5F0B91Atly46xn1jZ2875 q/K8I/E9IdvoRt+QFie67N5aSpgIBuxDJaKalqOVSVAij7RU258mVCYOBPDvw0e8UFRa COiT0Ck6kH6JIxbWvE567AnIj1x6xXvZJsvRsWE8D6P+SuLh8PzSIWd4+TghUbEdXgNY /H1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=kNhGC987; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b15-20020a170903228f00b001732b4e99c4si1740840plh.377.2022.10.24.02.13.53; Mon, 24 Oct 2022 02:14:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=kNhGC987; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229574AbiJXIKq (ORCPT + 99 others); Mon, 24 Oct 2022 04:10:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230181AbiJXIKk (ORCPT ); Mon, 24 Oct 2022 04:10:40 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2A94356E5; Mon, 24 Oct 2022 01:10:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666599037; x=1698135037; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=uw170i99a3xYagUOLTRB+BH+zYQ/zEo4hLwD3cRpGnE=; b=kNhGC987e3EHKOv2CVLFbcr3XYpsM+fAjNcdSc+n182yM04lDdPSGt9l ToRs8UClmVZsT1YcsIs0qBs/Gi0P2Lv5N18MEGFvxpdo2ZJiqWw7sM+z9 rrhAazPfMYe3VMRIuiIJcw6zpqEJsZ3VsTOPua4udAc53aGu5+OrOpJF8 5HGft3nwhMlwicq04743MZU8BMysQwj46G/Q35FBDM1QND05CNhOxfk2Q pykFfS6UKmgHLqTh45vS4bHxQOp4woV2RBGKTnmU4O0vy04+tiQwmb4jc GgbvvPGbVQMatfdJVzmJvg2ubV1sXlA+7Y9dYO4HLa+8+hJHqzGTsYxMD w==; X-IronPort-AV: E=McAfee;i="6500,9779,10509"; a="294763395" X-IronPort-AV: E=Sophos;i="5.95,207,1661842800"; d="scan'208";a="294763395" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2022 01:10:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10509"; a="756496680" X-IronPort-AV: E=Sophos;i="5.95,207,1661842800"; d="scan'208";a="756496680" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004.jf.intel.com with ESMTP; 24 Oct 2022 01:10:30 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1omsXT-001LDj-1z; Mon, 24 Oct 2022 11:10:27 +0300 Date: Mon, 24 Oct 2022 11:10:27 +0300 From: Andy Shevchenko To: Dongliang Mu Cc: Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vincent Mailhol , Oliver Hartkopp , Stefan =?iso-8859-1?Q?M=E4tje?= , Sebastian Andrzej Siewior , Sebastian =?iso-8859-1?Q?W=FCrl?= , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] can: mcp251x: fix error handling code in mcp251x_can_probe Message-ID: References: <20221024053711.696124-1-dzm91@hust.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221024053711.696124-1-dzm91@hust.edu.cn> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 24, 2022 at 01:37:07PM +0800, Dongliang Mu wrote: > In mcp251x_can_probe, if mcp251x_gpio_setup fails, it forgets to > unregister the can device. > > Fix this by unregistering can device in mcp251x_can_probe. Fixes tag? -- With Best Regards, Andy Shevchenko