Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Oct 2022 11:05:42 +0200
From:   Marcus Folkesson <marcus.folkesson@gmail.com>
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     Mitja Spes <mitja@lxnav.com>, Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Lee Jones <lee.jones@linaro.org>,
        Mark Brown <broonie@kernel.org>,
        Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= 
        <u.kleine-koenig@pengutronix.de>,
        Tomasz Duszynski <tduszyns@gmail.com>,
        linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] iio: pressure: ms5611: changed hardcoded SPI
 speed to value limited
Message-ID: <Y1ZVZpOgq8XkeCF1@gmail.com>
References: <20221021135827.1444793-1-mitja@lxnav.com>
 <20221021135827.1444793-3-mitja@lxnav.com>
 <Y1K7hWKl0siEtaAl@gmail.com>
 <20221023121222.5fe4a743@jic23-huawei>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="uqXQvfub/FN0MVU1"
Content-Disposition: inline
In-Reply-To: <20221023121222.5fe4a743@jic23-huawei>
Precedence: bulk


--uqXQvfub/FN0MVU1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Jonathan,

On Sun, Oct 23, 2022 at 12:12:22PM +0100, Jonathan Cameron wrote:
> On Fri, 21 Oct 2022 17:32:21 +0200
> Marcus Folkesson <marcus.folkesson@gmail.com> wrote:
>=20
> > Hi Mitja,
> >=20
> > On Fri, Oct 21, 2022 at 03:58:21PM +0200, Mitja Spes wrote:
> > > Don't hardcode the ms5611 SPI speed, limit it instead.
> > >=20
> > > Signed-off-by: Mitja Spes <mitja@lxnav.com>
> > > ---
> > >  drivers/iio/pressure/ms5611_spi.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >=20
> > > diff --git a/drivers/iio/pressure/ms5611_spi.c b/drivers/iio/pressure=
/ms5611_spi.c
> > > index 432e912096f4..a0a7205c9c3a 100644
> > > --- a/drivers/iio/pressure/ms5611_spi.c
> > > +++ b/drivers/iio/pressure/ms5611_spi.c
> > > @@ -91,7 +91,7 @@ static int ms5611_spi_probe(struct spi_device *spi)
> > >  	spi_set_drvdata(spi, indio_dev);
> > > =20
> > >  	spi->mode =3D SPI_MODE_0;
> > > -	spi->max_speed_hz =3D 20000000;
> > > +	spi->max_speed_hz =3D min(spi->max_speed_hz, 20000000U); =20
> >=20
> > max_speed_hz is a limit, and the max frequency the ms5611 support is
> > 20MHz.
> Hi Marcus,
>=20
> I'm not following what you are commenting on.. Perhaps give more
> detail?

Sorry for being unclear.
However, I must have thought wrong, this is good as it takes the speedlimit=
 set
in e.g. devicetree into account.


>=20
> Thanks,
>=20
> Jonathan
>=20
> >=20
> > Best regards,
> > Marcus Folkesson
>=20

Best regards,
Marcus Folkesson

--uqXQvfub/FN0MVU1
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEBVGi6LZstU1kwSxliIBOb1ldUjIFAmNWVWEACgkQiIBOb1ld
UjIUMhAAv8D5WWjvG14j7k8xAuDLVsAylOoEeaDOVDmShMKPzUU4TzNVk6beca+/
/TOo1U9fowbbTMIqxbYXr8mMiyBPaYoLP0WLn+bIfRNhhLyH9bry3X+FJshedLzM
lWAEtyAarjGhnnajUJZzu29EFe0q7pWE36Ai8e4wm24gnuQTROQgBZY9NaDOR2S2
IiL2VeiP/0fZn+8M3aMXHCeINUpQ74wA3bGwbHl2G6pMFbh1oEh39+URQVAXvUTw
3Kj6Brp+d4o+Mhy7pDnJCvRmFmARe2KMqrgKDMWb5hm6Q3APO3b5X5cOJFA5Ric3
Ldwfo/ubmJECTPcX+E1hIqruBkb4OZ0WGDS8FH6uIdxuhrpVkB0zIyiVk6XeCPKW
7fDklzTyjvh/KXf1h8EQC0eLex+xiBhKO8DsaL7XdU68P/imtwIGGQlzRxFThu7B
UHyfk93l6Ut2bQ+QuzgSQD+wBU3KG6TYIEGU9Z4NtSTu0f3OTR+mgZg3oZvvpOh4
1j5IVMMTP6lBOZ2N9mWX6gveaOG4WNVL2c9G30xGBdVzJgYDsfwjo//Yu8rPFdga
ppGxr7HpMy27e4h4uqI38rZzvqhHT+xPvCHZ0Y7dr6uz5zFd3v8inbMH0b4jmlYD
y3WJGGOuWXooVlfn1g36VeK94uRJ9Vgbs+5yamYYItIZsxR7IXk=
=SSFn
-----END PGP SIGNATURE-----

--uqXQvfub/FN0MVU1--