Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp6543596rwi; Mon, 24 Oct 2022 02:54:16 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7OLHPkrMGNlJ/CXlC+fuVSDYJ5eoEqNCKAs7Hj8+vGxx9XvuRh6lKcvOFtpbtPne8NNDtu X-Received: by 2002:a63:cc43:0:b0:43a:2f12:d326 with SMTP id q3-20020a63cc43000000b0043a2f12d326mr27350780pgi.320.1666605256101; Mon, 24 Oct 2022 02:54:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666605256; cv=none; d=google.com; s=arc-20160816; b=h7CRS+ChZRNzgZG8aqoPgIVcQ/OHsZXw2KhBrAQ2B6ZygKWzTxiWHZ1MHQQCq9JHAj 9gzneySRiBQMwCDDHZQN0DcBy6swE0NwiEe5E2X/eIXZ9w+t3eDLDCoqxhXUmuK7VtQG gA5f6kwnJjjgfqV9f/DT87oBdR/5c0eKI3cZT7dG9OO/yTkZiO76+Lna15C6KfMeHWTw Mg5OQV3Lyglt8yBzW0Kla+21KnFb5uzpBU2LCoGpZPQJ+Uc7MiL+5Xx/46BzsrXk5nyt 3BP7gdnvB7nAPRR9FdtxVJ8APD+GUQw915OXhHH/8t0PXG7sE19ZicZdVmFYLmR2P1DJ MY3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=yd+fxQKSE026OpZCfef536OFjJNo72Gu5e08Gc6kKHs=; b=fL21bfp4Nk+T/NVEbGnnShY9bSNlL6chGfl58Yz+V1tJLZv+Z6R2/TLMUjgboZMzj1 /iCO2FBP7ZeI9rDXM1Iq8KXjXTHkf/wbyj49QSya5TqLV233hiwSxID9wMgZAzIVKIlZ NX4FqL8huHKgIairmDj7qZgmuD86KWk2py1U6gJAQRZpADHPO3HYGldaqKrSFKzzOyn0 DQAxxV39wM3OkVPGA9agbKAeRcxfn9/6elhfZzOLdo563snxHW8TUrqAcqffZbVKHNDu ZUIG7jRhH8KcFLY1muEXutEpL0i3504I7Ay+E9B8K1hl9aMaEyroZr3dpa+MQLjphizL 1KCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=iIvkvtlG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f12-20020a17090aa78c00b00212c3779154si12027252pjq.118.2022.10.24.02.54.04; Mon, 24 Oct 2022 02:54:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=iIvkvtlG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229867AbiJXJ3g (ORCPT + 99 others); Mon, 24 Oct 2022 05:29:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230151AbiJXJ3d (ORCPT ); Mon, 24 Oct 2022 05:29:33 -0400 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E448E11A1E for ; Mon, 24 Oct 2022 02:29:32 -0700 (PDT) Received: by mail-pl1-x62f.google.com with SMTP id p3so7023613pld.10 for ; Mon, 24 Oct 2022 02:29:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yd+fxQKSE026OpZCfef536OFjJNo72Gu5e08Gc6kKHs=; b=iIvkvtlGpeDGszoMl3nRMlQ6N3mHCjIPx4UmJus9Z2sHCWiZWQmNAaORPdX9Dl4stS ZSexmfE6i/lOLfg/uvfl3CbhLSamiv4wgHMrU2a/UMdZ7eQKP5yL9HgYOhW7flDtKFu1 ToPqqJy1aGENjH56jzo8d/9V6X7NfW5ACBfn5VkPRBpqANjnpZWNMEtuFCqAEMBU1LlJ xGDxIjBoSE4weWYR0PvWL/at3+EKA6iWXPeYww/ODaZKuheb03a4BHOo/TCWgcYxdtil Y8Bix4WsWICuRyMKwvU5qA2ImVTO89jh48n1pyJhXVM+QbnXup5UU79LbrgAlKjfhbmt T64w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yd+fxQKSE026OpZCfef536OFjJNo72Gu5e08Gc6kKHs=; b=GuANp54qVBEJQjZ0IR4PD5smDJexbbtaQn6g+RAk/8aEQIRjclhEqyQAgzuFIG6hCP SZchcyaCWVuPXEMRwMNZfxbQAyG00YqjLhP7CpEioW/AgVV5PfNIgUyxxd/yd42Cz2g3 Z05NpCgDXsSC83mypucpf3/cDksn4s7mABBYgS2fYyGVR8JVbPT7PgnpRQHZ/Rww2YBA tltBzVVQELCIRR8zc8oZWbUnzQpKNsTakZqekNGOg92FE7gzzoarHhT7ufp5OWoPz0Yv 55fbnZn3aPrgSOS9KZxFkdGgPVLhHRywXp0OJ92T2RNGz0Q1B8aWszw4GdeQQoU/4/D6 xdAA== X-Gm-Message-State: ACrzQf2w+PDYOmr+R3Io6E/SMQwfhinhGSeCSSOfI0NuktAbFjo2bOFl fynQSeFUs5cTAkePJzbmEmY= X-Received: by 2002:a17:90b:3a90:b0:20d:a54c:e5cd with SMTP id om16-20020a17090b3a9000b0020da54ce5cdmr64819255pjb.183.1666603772445; Mon, 24 Oct 2022 02:29:32 -0700 (PDT) Received: from [192.168.43.80] (subs32-116-206-28-6.three.co.id. [116.206.28.6]) by smtp.gmail.com with ESMTPSA id l64-20020a622543000000b0056b1ecef957sm5123696pfl.37.2022.10.24.02.29.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Oct 2022 02:29:32 -0700 (PDT) Message-ID: <85af6032-020b-e406-672f-c4e13ab7f1ad@gmail.com> Date: Mon, 24 Oct 2022 16:29:29 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v2] staging: wlan-ng: remove commented debug printk messages Content-Language: en-US To: Greg KH Cc: Deepak R Varma , outreachy@lists.linux.dev, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <4863c6d7-ffdd-1304-981b-9b0644a87f4e@gmail.com> From: Bagas Sanjaya In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/24/22 11:08, Greg KH wrote: >>>> Shouldn't these printks be guarded under CONFIG_DEBUG_KERNEL instead? >>> >>> No, they should just be removed as was done here. >>> >> >> What if in case of debugging without these printks? > > I can not parse this line, sorry. OK. Ah, I mean I have to see Documentation/dev-tools/kgdb.rst and Documentation/dev-tools/gdb-kernel-debugging.rst. -- An old man doll... just what I always wanted! - Clara