Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp6544388rwi; Mon, 24 Oct 2022 02:55:06 -0700 (PDT) X-Google-Smtp-Source: AMsMyM41I2MTEQwwwS15qTxoShfb85SxbJVwOK4kmBXMXKcsRKD1jk6gTRz3Hue3cwlEV5HIsINb X-Received: by 2002:a05:6a00:a05:b0:563:5d36:ccd4 with SMTP id p5-20020a056a000a0500b005635d36ccd4mr32523491pfh.25.1666605306361; Mon, 24 Oct 2022 02:55:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666605306; cv=none; d=google.com; s=arc-20160816; b=0GrJaIn/eSz69+yW84AFhcjb8lS2tsTuRLzc8qJ84zi8ML3mjZ7xbs8jywAp+PaRhg vdC6kBUw0mOTXEAmOi0dGFeWumEmfkHFzVGL2GgAeMsHgjxIPttHmNHKQQjFtF56QYIH xeOwUJFPJQ7GxVehEQNlGD6k4iEW1llKPQGcYu9fx9b/pg0aBaMYLiYj6kPl3g3/ZSJc BHFSxsU9NnKib5trNSnYgRTzRAPrhaq5wyMiWPV5CAyvauJuCkByVhh4xbCdMvcnv/ro tVAxncb2Oba0hfBCNeH79rsTz6rjWRSDIlJvp/dB9071HzGBntBH88pDagj7mU03rc/i Altg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=NnolCiMBjl8qX8ASTYaNnJALNGKZaQCXHfWumAnTsTM=; b=EXDklouJyswKsIbAQtbbRQYdyu+m+7qHwHV9PFvEalPrcYbVi7kfeOCAQmPQSt1s9I tCFbUihVL0SeAvtDqOpGZzVbJVnz86ciuUko1q+fFwJJCwNDTljBTTNrPXFlYFHPkdpZ A6uM3nxOX++T8NovqRbiBlzWgHkJLKUTOoHWx8WnUTGJvtRk2ueZp/CrbDDVkGhzdnbs igCDnWi8cEyBvrnUsbdP8XOEXlOGytu7qKbuxr7scAE5/RntfjIjFGeaQuO1WzbZF7zW +kTutiR3EM6Lm+ckaIMZxMRijOc88+BxvOueePA4chMGWL7QNn/4EYKG/rynLZpIM+3m Alag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=gm46cR8s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k62-20020a17090a4cc400b00212d5631badsi7848106pjh.55.2022.10.24.02.54.54; Mon, 24 Oct 2022 02:55:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=gm46cR8s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229634AbiJXItq (ORCPT + 99 others); Mon, 24 Oct 2022 04:49:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230315AbiJXItm (ORCPT ); Mon, 24 Oct 2022 04:49:42 -0400 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8787119C20 for ; Mon, 24 Oct 2022 01:49:41 -0700 (PDT) Received: by mail-pl1-x62a.google.com with SMTP id jo13so4296960plb.13 for ; Mon, 24 Oct 2022 01:49:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NnolCiMBjl8qX8ASTYaNnJALNGKZaQCXHfWumAnTsTM=; b=gm46cR8stv769f/3qrG5mY89pnjak1s16VZzjmmrodfvPJ0t1TxqRTEAzeUemmns9O zl49OqL3wnKxo6MhOV53Hnaq/lS0cldqq6ZxQdBjruuvkO52R4OZxw4caNmr3CXA0NAO uwLvJoeEtsXEvJjjeJCZ3RSf4ZW0i2GHnp38JwbWol8Ppeo9mPzeXdbFARvpOrUaCzR6 j2cpfxE4W97id6cWrjzpIafnfIR49aaRHOFXcQXVQ0xyIRJPAAHGZ3dX46E+gTSg2uFU h1vyQtrt5bfWPK6NlBlPC1XIILP4TFTWH/+DaN4nxJbOt+fvEdapGmM3rSxprpdyouFy Z/2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NnolCiMBjl8qX8ASTYaNnJALNGKZaQCXHfWumAnTsTM=; b=6C4hXNpNmVJoGiyrIN5mK+N6F3R2yo9t1k4tEHV/+UE+w/aEogAJM4SZQGVVwXshf3 9udjY67M4/a8r7bZmFzzWgw6zcyVRKkgUzGTdNS/TIuhduKFFClQOvR7FcCNkfr4pdJC NkLM+pj6QnNlcB5D5FXq9z6QEkE1cFbarvN3A5jqNYELdWnkJm+OL9cqHM4BqfoTe2W8 OHB7ZYnU3mbB211SWRfiRy3T6ief8cRWEltM/CkJPexbAqaimJBZIgtatFck9TyDl/pq dUUokNK2FFp3aI72/lCmS8Zt3nv2yN407Pt0KnimtgtPmkt3sB6N2yoxr+7LKwaWNAKb 0PSw== X-Gm-Message-State: ACrzQf3Frj2RuL0ldLR61xvfy1NMXWHfT+1i5mHqcl5YIaqcnWvwPVvL MTj1Rq5FZpm7Cz51AwaNoFw= X-Received: by 2002:a17:90b:1804:b0:213:1a9c:5ae with SMTP id lw4-20020a17090b180400b002131a9c05aemr3094555pjb.81.1666601380700; Mon, 24 Oct 2022 01:49:40 -0700 (PDT) Received: from uftrace.. ([14.5.161.231]) by smtp.gmail.com with ESMTPSA id r2-20020a63a542000000b00434e1d3b2ecsm17245124pgu.79.2022.10.24.01.49.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 01:49:40 -0700 (PDT) From: Kang Minchul To: Larry Finger , Phillip Potter , Pavel Skripkin Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Kang Minchul Subject: [PATCH v2 3/4] staging: r8188eu: remove unnecessary variable in rtl8188eu_xmit Date: Mon, 24 Oct 2022 17:49:24 +0900 Message-Id: <20221024084925.262289-4-tegongkang@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221024084925.262289-1-tegongkang@gmail.com> References: <20221024084925.262289-1-tegongkang@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return 0 directly instead of storing it in a variable. This can prevent cocci warning as follows: Unneeded variable: "pull". Return "0" on line 298 Signed-off-by: Kang Minchul --- drivers/staging/r8188eu/hal/rtl8188eu_xmit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c b/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c index 8e4a5acc0b18..6d1f56d1f9d7 100644 --- a/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c +++ b/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c @@ -149,7 +149,6 @@ static void fill_txdesc_phy(struct pkt_attrib *pattrib, __le32 *pdw) static s32 update_txdesc(struct xmit_frame *pxmitframe, u8 *pmem, s32 sz, u8 bagg_pkt) { - int pull = 0; uint qsel; u8 data_rate, pwr_status, offset; struct adapter *adapt = pxmitframe->padapter; @@ -295,7 +294,7 @@ static s32 update_txdesc(struct xmit_frame *pxmitframe, u8 *pmem, s32 sz, u8 bag ODM_SetTxAntByTxInfo_88E(&haldata->odmpriv, pmem, pattrib->mac_id); rtl8188eu_cal_txdesc_chksum(ptxdesc); - return pull; + return 0; } /* for non-agg data frame or management frame */ -- 2.34.1