Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp6553590rwi; Mon, 24 Oct 2022 03:03:15 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6g0C8eVVPACUh+cvMXdR/d+TXLb1PVbMGPezcIWyEXXPscD92lpEai7u0Xjqx/dVL3+Qky X-Received: by 2002:a17:90b:305:b0:213:8a6:8bb4 with SMTP id ay5-20020a17090b030500b0021308a68bb4mr6293536pjb.33.1666605795244; Mon, 24 Oct 2022 03:03:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666605795; cv=none; d=google.com; s=arc-20160816; b=YrklWLc3clRmOytCXcNwnbdkGP13wYfdaOV+qYPzGaCVxzRGrD9WGrhTWnheUjy2V5 rUb4dSExIH+qenrjYUKUlUvdjbvAXHATAOCnd9GFe9/LUJzHTREQpEOBqZcGWUr4RCFR DJayxZZ7K2NYik9ClW7YDIRNOi22WTRsCsDn96HAKgVgzQTN8bF4CUYyVzmRixeJ0IOp xaPdZ4G1agiaKrkg7vwJff3tGZHMly+M4Se+oo9aeVDh6b8CqV+m6QKo3qJWr976o8kQ BW8xmKh+7lSrWx5J9SZMhAvDNa7pwNh0Jew82PCwOemfMNxAvwMyTKmDdSrXH6hCVdd9 +AaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=4LAV2egbw40LLMO9p/TswFP4zfNo6jVJgcGK+7WzHNw=; b=B4wG39FeWgSjsaHRMB/1ATtxFcrH1USV+bOfQgyVZVb3b76gZCm1cjaQW5BG79C+ql RApoezXT2BDsKP2uciCtTG2vznopSbWkdTQAsVADe9ILAqR7TwzpRpDY8m1GNrPGDNOx cdGFW3W1Va6mjzov4+JCw7JBHJDf0OKAELopzvgVkOXULEr5ZnrMgSxXaa+ZtKTFeVBR mjZ/vWMg1jD6D7OEg/Xa20VnL17+6kStAIZ3Uqo7AlUyfFRBNpUiXn/Ux+cs+4J8G5BI 4M/q7bCtPMnLFw+jVsXfBNEuPlD3/O+stTPDOxWlyXhR8/N25K6k1dmngBQ1vUxOsbI/ yi9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=V2Q+SvhX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 20-20020a631154000000b0043c0b452d3csi36465198pgr.69.2022.10.24.03.03.03; Mon, 24 Oct 2022 03:03:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=V2Q+SvhX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229782AbiJXJuW (ORCPT + 99 others); Mon, 24 Oct 2022 05:50:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229874AbiJXJuT (ORCPT ); Mon, 24 Oct 2022 05:50:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C2E3356FB; Mon, 24 Oct 2022 02:50:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ECB4661162; Mon, 24 Oct 2022 09:50:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 533B0C433C1; Mon, 24 Oct 2022 09:50:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666605016; bh=KkJv9pQMuI9y/XwLw6a+6h5/sOiz+GihvArdXW93g4g=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=V2Q+SvhXTUHpbdvPu8VO0g0ggFJQjQolsabqSNj0Pd7Both88nVwxYR5CnbH86S4C FHuuQcwegCIeuWylbmDE7RFxAlNd+p/hLckQBCyPiRz6jrCmhYLr9PmpHH9zPi7Ta1 CFGXiGgEbXsz/GkfVNrMsdSSPpI0eukQk+4ojC2n0n4jKf3O2l9ECYwppbTtnNhe9N 0CwbPNW7KuY5mHGX+8zkx0yaLVAYzKq71SZehfNeMdylBLLkZRJ+fGxqeKnBLno4LF iqBSuqPohDup0DKUTKK9khoqkPjVm5uaoWdFKDXfbIbiCOqMs9WkcOPwO3IULVzwiV kby0Sq2kwrRUg== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 36168E270DE; Mon, 24 Oct 2022 09:50:16 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net v2] net: fman: Use physical address for userspace interfaces From: patchwork-bot+netdevbpf@kernel.org Message-Id: <166660501621.28227.3493718376720166675.git-patchwork-notify@kernel.org> Date: Mon, 24 Oct 2022 09:50:16 +0000 References: <20221020155041.2448668-1-sean.anderson@seco.com> In-Reply-To: <20221020155041.2448668-1-sean.anderson@seco.com> To: Sean Anderson Cc: davem@davemloft.net, netdev@vger.kernel.org, geert@linux-m68k.org, madalin.bucur@nxp.com, edumazet@google.com, camelia.groza@nxp.com, kuba@kernel.org, andrew@lunn.ch, afd@ti.com, linux-kernel@vger.kernel.org, pabeni@redhat.com, madalin.bucur@oss.nxp.com X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Thu, 20 Oct 2022 11:50:41 -0400 you wrote: > Before 262f2b782e25 ("net: fman: Map the base address once"), the > physical address of the MAC was exposed to userspace in two places: via > sysfs and via SIOCGIFMAP. While this is not best practice, it is an > external ABI which is in use by userspace software. > > The aforementioned commit inadvertently modified these addresses and > made them virtual. This constitutes and ABI break. Additionally, it > leaks the kernel's memory layout to userspace. Partially revert that > commit, reintroducing the resource back into struct mac_device, while > keeping the intended changes (the rework of the address mapping). > > [...] Here is the summary with links: - [net,v2] net: fman: Use physical address for userspace interfaces https://git.kernel.org/netdev/net/c/c99f0f7e6837 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html