Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Xiaolei Wang <xiaolei.wang@windriver.com>
To:     gregkh@linuxfoundation.org, jirislaby@kernel.org, lukas@wunner.de
Cc:     fugang.duan@nxp.com, sherry.sun@nxp.com,
        ilpo.jarvinen@linux.intel.com, linux-serial@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH] serial: fsl_lpuart: Skip the reset for the early console port
Date:   Mon, 24 Oct 2022 17:12:20 +0800
Message-Id: <20221024091220.1619822-1-xiaolei.wang@windriver.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kLby+DvxTYAmbiePREo5JCpNfKwTEzxRbMJ7NuPe+ny4/sp8E15vx8RThmfZ?=
 =?us-ascii?Q?/Wz78u2zYZNWN2K0GxEkKlDDdmK8d+EH5btKEZSvziuorTUCTIx+OK9979OM?=
 =?us-ascii?Q?8i3J96lIoIysvpfFsQB5uQ0YsavrqJf/6+wt4QR3vwpX1CrxWPyoQL4vy7Ob?=
 =?us-ascii?Q?a+s/afCjc3rxUkzEQAWhplP9muT6VU2aEavn3cbQQILiWptrsU74kQm/eGt5?=
 =?us-ascii?Q?qrJB9qELF18gy3UZlpfWkLZUTgnjCVwKqRNae5YjmOcieEyCYVtm22ljV5CC?=
 =?us-ascii?Q?cdbAhS7UmYAWiS6DrVOukmIVFA214EMm5RTa8HOpnPnfSDmtY3YLaBNuApRI?=
 =?us-ascii?Q?iKmBmrX1O88rfEvMRa7aUO5jlxbDeNoh6HtMZ4rldUZ7+BnfXnp2f7z/xdvt?=
 =?us-ascii?Q?1hdqHtnNxRiSCPG5CNIukr7aPeAcvikt0ueD5Slh1BMPuIhXLq26WEXbBr8G?=
 =?us-ascii?Q?W1zzkXrVg27jMbki7pLbUI/bqqpm24mgFvAu5czdUiICtnCKG4g0irFCh1K1?=
 =?us-ascii?Q?NYTt0p0bgRJdRGPziOk0jObySc6AQMiqtwxeadbx8A0+VuEOOHzxDM788fqA?=
 =?us-ascii?Q?3p/ZnMx9EMiNA3obLWxd33ExoHVSMINiQqKuiQIz+VYIHkpWsm0AQ1WNCG1N?=
 =?us-ascii?Q?GNzPhppmD8OFdRBpAAda/p1cvQwrRUrvH2JBF3FpUl16UEJIfVJWjEUZBk+G?=
 =?us-ascii?Q?I0Lode5Df/CJn/aRnnFo0xBA4m58KdiiXpCc1c2NTwRLGYP0ON0j9pAiTOQj?=
 =?us-ascii?Q?NpBF1nZkhyC9QsviHIb35HjwIujVivOKGWFc1i4oRNV/gqs3dIjTq/NTznu8?=
 =?us-ascii?Q?yg2SAfJjA4Kw6n3OhWDHf41IyqHUNn7WRrXhbRMOvjEgliFgmst9eDXyHCnC?=
 =?us-ascii?Q?59r1F2OeENQGaYCUCpUW/rhtcFWUhW1bG1JflmUM0YReckVhCaJMowZ2xGiX?=
 =?us-ascii?Q?Doo64hhBW2iH31KEcDQXOhCQTuK80H52mpVZ+EkIfBdafkOfktMO5UyAKjtc?=
 =?us-ascii?Q?eCzr2ckcqV8rnvtYUfsfkp8/M/vjKd7oP2JQw7usFK9Bd/PHJorzmXqWkSs+?=
 =?us-ascii?Q?QWrN/GwzSHad4hxrt7NGAWowKkXfDAwdJToAmC/RzGMVRi4Dne1QkQvUbLzu?=
 =?us-ascii?Q?AD+/dnoniU2Uw9b7qmQkY6FCMbp6bKDAXAyGSOAIW4SxJ9E+otPo2c/egdpI?=
 =?us-ascii?Q?lg4rmVP1K5sHpto0RnDyMmBmWbF6wQn8F80tqn4OgJYm6lkSFkfhV7nnhNZv?=
 =?us-ascii?Q?eXK1lP4CtV0e9yqoObHy7Neqs05Bmvssetj4RS2/LxA8wzYocekLq8wMMirx?=
 =?us-ascii?Q?xtLI7fDr6z6nv7o/F6r+KZNDRe4hIpW3zNDUgWZfQz7IqNscER+PoDns60Bd?=
 =?us-ascii?Q?9PdIehZNgxlYkTteanF6taka2EXs/4TmbncwJriVRyTP+RxjdwsfazFpuC2/?=
 =?us-ascii?Q?uUNjhOoU7OIIFVkRREinDVYV+LuvrW9ZKb2uop2gq7keAPVA9jq7S9A9rkSl?=
 =?us-ascii?Q?tKJFk5/sklHsoceDKSgkSEDStFnVpVcVAloUIdW+N/zlRQ15jXTDZBrgP3GY?=
 =?us-ascii?Q?fmEpOogzMmkd8nl+acfnYy5guLqCXbww4wtFy3/kPn6IaWDvByFmsVzWYe6u?=
 =?us-ascii?Q?Lg=3D=3D?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ff128b12-dcee-47e6-d3db-08dab59fe52e
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5764.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 09:12:37.8336
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +k9gL7NVu+/gRkq6NaK1y0ztXZQL1exbdcogg0/jHR6LHFKZYtuhaeU+xSaUltnRbLLXU4F+dlEtOOM8Q+jH55bCH/IystPgfNgDjuGhWHw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4721
X-Proofpoint-ORIG-GUID: FT9xUM-goo1Gbh8uCJQId4m071VvhU3I
X-Proofpoint-GUID: FT9xUM-goo1Gbh8uCJQId4m071VvhU3I
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-24_02,2022-10-21_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0
 lowpriorityscore=0 clxscore=1011 adultscore=0 phishscore=0 bulkscore=0
 mlxscore=0 spamscore=0 mlxlogscore=999 priorityscore=1501 impostorscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210240058
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The commit 60f361722ad2 ("serial: fsl_lpuart: Reset prior to
registration") has moved the reset before the port registration,
this change makes the uart_console() in lpuart_global_reset() no sense
since the port is not registered to the system yet. So drop it.
But we sill need to check if the port is used as an early console
before performing the port reset, otherwise the reset will hang the
system.

Fixes: 60f361722ad2 ("serial: fsl_lpuart: Reset prior to registration")
Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
---
 drivers/tty/serial/fsl_lpuart.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index 67fa113f77d4..d0efeba5c695 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -239,6 +239,8 @@
 /* IMX lpuart has four extra unused regs located at the beginning */
 #define IMX_REG_OFF	0x10
 
+static resource_size_t lpuart_earlycon_mapbase;
+
 enum lpuart_type {
 	VF610_LPUART,
 	LS1021A_LPUART,
@@ -410,7 +412,7 @@ static int lpuart_global_reset(struct lpuart_port *sport)
 	void __iomem *global_addr;
 	int ret;
 
-	if (uart_console(port))
+	if ((port->mapbase - 0x10) == lpuart_earlycon_mapbase)
 		return 0;
 
 	ret = clk_prepare_enable(sport->ipg_clk);
@@ -2604,6 +2606,7 @@ static int __init lpuart32_imx_early_console_setup(struct earlycon_device *devic
 	device->port.iotype = UPIO_MEM32;
 	device->port.membase += IMX_REG_OFF;
 	device->con->write = lpuart32_early_write;
+	lpuart_earlycon_mapbase = device->port.mapbase;
 
 	return 0;
 }
-- 
2.25.1