Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a609cff3-b3db-1f17-832f-99652356e74e@amd.com>
Date:   Mon, 24 Oct 2022 12:56:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v1] drm: Switch drm_client_buffer_delete() to unlocked
 drm_gem_vunmap
Content-Language: en-US
To:     Dmitry Osipenko <dmitry.osipenko@collabora.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>
Cc:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20221020213335.309092-1-dmitry.osipenko@collabora.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20221020213335.309092-1-dmitry.osipenko@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MHhXRHY2T3JhZno5LzczVVRpTlJveUpRRnlQSmtwakZORnZJNmROTTBFWEVB?=
 =?utf-8?B?akZBODl2RDJyUmlZT0xyNVlIUEYzSzRMZmJjZ09CODk2dEFjbEhNSlFqdDhV?=
 =?utf-8?B?NkI5ZjZrVVIzQzNPUUxxZ0xJcmVXZEowYUNieHVQbDZPK3NEalo1emVjMGlz?=
 =?utf-8?B?U1hHTFlZU0xMV0l3Uk83SlpBdlFqSGtUOTRGdFNBR0VTOERCTzVXK0ZFVUJi?=
 =?utf-8?B?bHdNM1FCZmhhSGFiUm1iY3Nqa25OVk5tbWF0VDRiWldWazFUSkNiUDVjdnJN?=
 =?utf-8?B?STJGR2I0MTJKRkRwRTNkTjZHYWpRc1RHcjVjVWFXaUdkY1BLSFJKcEFWSXN2?=
 =?utf-8?B?Mm8vc1NVUXZhdUoxNmpTdFZTY2RMMmNvWXFoN05IUnVZVzRUVlpOYlR4NTRD?=
 =?utf-8?B?UnAzaFl1VVFweS9rSmtXdWZsMGJobWFKTUd6SGFTZytVTFR3Q3o3cDVWZVBT?=
 =?utf-8?B?emRRdUptZGRIZXBudUZHQzJMdmF1ckpZV2NaMlZpNDNSdEl6aFU2VXdVcHlM?=
 =?utf-8?B?MDhGcDU1ZjM3MUE4TnAzSStQZUE4S2cxb0dqUkk4aEwrSU9EU2loUExXOUZN?=
 =?utf-8?B?dFNjb2swM2x3VGs1UzJHeDhNeUROSW4vS2hROHZWdGJkdTBNblZYV0NONUpv?=
 =?utf-8?B?MEtyT1I4M0J2Z0JqMzNzYVFwNHhNVWpreGdXRnhodzBuWFVuY2NnYzBha05K?=
 =?utf-8?B?SFVObVNpM0k5OS9xZ25vRWZzQXRobElHNWFKbG03QTN3UjNBVHJ3OEJpcUFn?=
 =?utf-8?B?RW04RmlJMmdRTXJlS0VLdHZ1bjdYMjdtU1VzTzhDOE1DcFFYU0tUM084VDhm?=
 =?utf-8?B?NTRBMklVeEI2aEYrK3E0Ri8yTmFWaGJxMGZRb01HSElQRE5EQk1FMEhIKzk5?=
 =?utf-8?B?ZWxOQWRKaXJSUjFsTDZHb2Fna3VkYjhIMk5TcTMrMWRyQ081VFlpbVRqL2gr?=
 =?utf-8?B?YWp0T3VzWTFjMUVxQ3owdWkwTHZnUDJGYlpPeWs3c01KZGNMN2NRb09oWnZz?=
 =?utf-8?B?dFFySFhnTmdUY0FOeXFnMWxrTFh1aHV6S1RmUUNQVWtaeGs2Q3ZSYlRuOUth?=
 =?utf-8?B?anJmc0MvMmZtV1g1eEgzdnQ2bjkyWEpGWlFPemliYjgyUjRxS3htK1ZxRXJG?=
 =?utf-8?B?eVl0QXNleFR5MHBQZXZrZWFlRGd3UUFUYmcrNlJXd2JHb0FMcTNmTlM0RnhV?=
 =?utf-8?B?NEJHeGlrck1mWGpUc24yL1pJRHlwNTlYOXZmQzIvZ1VNVnp0dW9NUFR2SVhj?=
 =?utf-8?B?YWM0UjNPRlUrWGEzdTkxQUMvQisyaEJ6QXFOTmw4blJWSWlsaERsbWpMZXFx?=
 =?utf-8?B?NXozd2VnRzE3djRkUXpEaGlNVDBWMTFEWkw0Mko3REpEcjFUdFJDdUtMOHdL?=
 =?utf-8?B?dWJiOWZDRHJ3S1pVakNwbUJqdCtxQlkwL2xIbE5FblpKWUpXRlNCamJOZUJ1?=
 =?utf-8?B?RmJqSzZIdDVrVzBtWVdUSWUzdTd1SWduUUxtY0xOM0NwZHEzeXNaYjZxMUR2?=
 =?utf-8?B?VUROWExMTjh5clBNemNoZEc5ZE81dHFaeWFpN1d4cHppcGttQjd3WXRHazZO?=
 =?utf-8?B?dnMxTzlvak9DRHEwdmtJVnUxNjVXdmpveFBuMFRBd2NENGZWQThGOFd5OUVN?=
 =?utf-8?B?QjlSVDZzOERXSThMTWxpOUl1dGZLWVI3QTZWSVo1ZmVNUXJKeHVnODgyaCtR?=
 =?utf-8?B?MkZLTjRYWWZtU284RHdQRUN3dlhvQzREckhuVVRCUWs1MWxubDhyclgzMWk0?=
 =?utf-8?B?c2Y1TE42cDd0aW9DbnYvVXI4Qng3R3Z5Yi9JUVBsNElwd01INlUxdktPdE5n?=
 =?utf-8?B?TXlpRjRaSUtUazBFS0VSVGwrK3RVeU1laSswd0J2aFlpT0RlQXhEL1FPWFBZ?=
 =?utf-8?B?WWtWRzJicFRFaE5iVGtraHhqZVVHTjBBYkVlMmF5aEh0dS9XSkNkZ2UrekZX?=
 =?utf-8?B?ait5aFgwNWFlL3E4MUJXS1pIY1prT2haR3pIeWhPSEdyUWxzbGtWeEtvV0J3?=
 =?utf-8?B?R1EwSVdhYjhIVHdUUzU2RFNmTTgzUmpqLzcwKzlVcHE4aW5OVEFQVjVRN2Nv?=
 =?utf-8?B?Q3ZGa2pqbC9MTWpPdVNGYytPa1g5WEYyelV4WXN2Q2lRdmhielF0K3lJTWF5?=
 =?utf-8?Q?guNNiHU10c9k8S5G6lM3wzNal?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 114a8e3f-b22d-491d-eed9-08dab5ae6867
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 10:56:30.8956
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hO5/okaVz0KeqjSXFxosMxhhHm6HhVj7JHDqM7YJKMOEGSg47GyzDGS1ojfxHsHZ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4582
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Am 20.10.22 um 23:33 schrieb Dmitry Osipenko:
> The drm_client_buffer_delete() wasn't switched to unlocked GEM vunmapping
> by accident when rest of drm_client code transitioned to the unlocked
> variants of the vmapping functions. Make drm_client_buffer_delete() use
> the unlocked variant. This fixes lockdep warning splat about missing
> reservation lock when framebuffer is released.
>
> Reported-by: kernel test robot <yujie.liu@intel.com>
> Link: https://lore.kernel.org/dri-devel/890f70db-68b0-8456-ca3c-c5496ef90517@collabora.com/T/
> Fixes: 79e2cf2e7a19 ("drm/gem: Take reservation lock for vmap/vunmap operations")
> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>

The code was properly added recently between review and pushing. Let's 
get that upstream ASAP.

Acked-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/drm_client.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c
> index fbcb1e995384..38e1be991caa 100644
> --- a/drivers/gpu/drm/drm_client.c
> +++ b/drivers/gpu/drm/drm_client.c
> @@ -235,7 +235,7 @@ static void drm_client_buffer_delete(struct drm_client_buffer *buffer)
>   {
>   	struct drm_device *dev = buffer->client->dev;
>   
> -	drm_gem_vunmap(buffer->gem, &buffer->map);
> +	drm_gem_vunmap_unlocked(buffer->gem, &buffer->map);
>   
>   	if (buffer->gem)
>   		drm_gem_object_put(buffer->gem);