Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp6709554rwi; Mon, 24 Oct 2022 05:15:34 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5qwTFpbEX/0+xSVvbkd7T0l9fgCOfPSnnhGHB3tTfNsSjr88QrD3ayuI0tC2kcJR9Z07ET X-Received: by 2002:a63:ed18:0:b0:439:4176:3ea6 with SMTP id d24-20020a63ed18000000b0043941763ea6mr27806760pgi.363.1666613734331; Mon, 24 Oct 2022 05:15:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666613734; cv=none; d=google.com; s=arc-20160816; b=m9WrIWD+laOVokfCeWPQrSfBJ6C+Ry7T1OQiJf+akGtwCVVaPA/bM545Txz0qv2g5b PhfiD7TxuxJN7cBv+YeEbec4BggbXA0hy3BWg+K8l2jha1C13wS5Fq7Dqni0/hGN7GPH lYVxGtJsbed8mH4wbxe3qHfZGpz9kW1FiiWmrFnph6tjeyQu2EBGw0l+sQjW+e5Y1H+L d8/yxxJ0iuX3+nYKLtSwb/JBjuq5m0uOz8nJ7IHVa13Xh1spFHO3/ZUVa6duemfyB9qK ugDBa11Lzy4xLMTm4nxnLE86kOpAf7Q4f/14dSbecMPraoPoLmkPjJ7jSD/DRlkTfTdS gcOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :organization:in-reply-to:subject:cc:to:from:dkim-signature; bh=1yAEqhY/xeX1L+6nQlEyV6z3uPfSGlmYtgQ/dJ8ctj8=; b=ccKvq5cHrta+/VQt07hv9hl3Azb68ohqYwaJUom/tTn32icfABewzT5PsLah3KA0BX Ts4EPVOIoOB8eUZ02dbYCF3A6B+0cVtmwlGgyBRiDBkPzL/NCx1Ebz1wB/yYEaI7UnQg 5pfWbn2DtlhU22QD/LxvDjmf5yuJNopwRThh9HdyiGhrrEG4U3lqzIJYWb4tJ6BgNz6u CWW9VlDYwTJBllQnrih26PNb11eqqfZNNx3l9SoWh+kJEv8T1HdMXoAywfiGUq+6jum5 CeNvENnhzkyo+yb5G0I0qEVvB4BYWv5ukllGdNKdE3WfqTgI5E13yvEqa5r7Pucnf20l hkbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=UkxUqyMw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y31-20020a056a00181f00b00562a1693523si36053016pfa.20.2022.10.24.05.15.20; Mon, 24 Oct 2022 05:15:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=UkxUqyMw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230168AbiJXMFj (ORCPT + 99 others); Mon, 24 Oct 2022 08:05:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232513AbiJXMDt (ORCPT ); Mon, 24 Oct 2022 08:03:49 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA247275F9; Mon, 24 Oct 2022 04:49:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666612191; x=1698148191; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=t3cjsGp+mGZTfId3Uz83F67WuGQ8r3GpeajQ9Pj0MTw=; b=UkxUqyMwyIAVJpU8jQYYJmQF7FVqcu1nNSUULmp1M5bcYoSDMcq0Ep2E aplorVrnxfcma5FWPqb0QfkXmZVoaKYyEwVtfmQX+2E6ULzwj5nitYuKR Cphhzlm42wM5QleBRv3cV12C+7AgnyGo/LjIvhVWfiKLl6oTgg/4fx05t Xjf/wp5Tf+ZP0dgb/0sF3USMF/I66369wmpurruJTuSWTXcM29VGPbSSg ko6r6OPyLywcWONDaPkwAQ7DzYPyKAa4z3y2eLmiHI347Uvw8pjksIsMg 1WgKIGXOKO25DWh5UpmdmxCM05MOPiE7WZn53VcJu7XlcD90HpjaGNO+T Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10509"; a="333981437" X-IronPort-AV: E=Sophos;i="5.95,209,1661842800"; d="scan'208";a="333981437" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2022 04:48:46 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10509"; a="631231987" X-IronPort-AV: E=Sophos;i="5.95,209,1661842800"; d="scan'208";a="631231987" Received: from emontau-mobl2.ger.corp.intel.com (HELO localhost) ([10.252.52.221]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2022 04:48:35 -0700 From: Jani Nikula To: Akihiko Odaki Cc: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Jonathan Corbet , "Rafael J. Wysocki" , Len Brown , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , "Lee, Chun-Yi" , Hans de Goede , Mark Gross , Corentin Chary , Cezary Jackiewicz , Matthew Garrett , Pali =?utf-8?Q?Roh=C3=A1r?= , Jonathan Woithe , Ike Panhc , Daniel Dadap , Kenneth Chan , Mattia Dongili , Henrique de Moraes Holschuh , Azael Avalos , Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller , Robert Moore , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, intel-gfx@lists.freedesktop.org, platform-driver-x86@vger.kernel.org, acpi4asus-user@lists.sourceforge.net, ibm-acpi-devel@lists.sourceforge.net, linux-fbdev@vger.kernel.org, devel@acpica.org, Akihiko Odaki Subject: Re: [PATCH 00/22] Fallback to native backlight In-Reply-To: <20221024113513.5205-1-akihiko.odaki@daynix.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20221024113513.5205-1-akihiko.odaki@daynix.com> Date: Mon, 24 Oct 2022 14:48:32 +0300 Message-ID: <87tu3te92n.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 24 Oct 2022, Akihiko Odaki wrote: > Commit 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() > helper") and following commits made native backlight unavailable if > CONFIG_ACPI_VIDEO is set and the backlight feature of ACPI video is > unavailable, which broke the backlight functionality on Lenovo ThinkPad > C13 Yoga Chromebook. Allow to fall back to native backlight in such > cases. Where's the bug report with relevant logs, kconfigs, etc? BR, Jani. > > Signed-off-by: Akihiko Odaki > > Akihiko Odaki (22): > drm/i915/opregion: Improve backlight request condition > ACPI: video: Introduce acpi_video_get_backlight_types() > LoongArch: Use acpi_video_get_backlight_types() > platform/x86: acer-wmi: Use acpi_video_get_backlight_types() > platform/x86: asus-laptop: Use acpi_video_get_backlight_types() > platform/x86: asus-wmi: Use acpi_video_get_backlight_types() > platform/x86: compal-laptop: Use acpi_video_get_backlight_types() > platform/x86: eeepc-laptop: Use acpi_video_get_backlight_types() > platform/x86: fujitsu-laptop: Use acpi_video_get_backlight_types() > platform/x86: ideapad-laptop: Use acpi_video_get_backlight_types() > platform/x86: msi-laptop: Use acpi_video_get_backlight_types() > platform/x86: msi-wmi: Use acpi_video_get_backlight_types() > platform/x86: nvidia-wmi-ec-backlight: Use > acpi_video_get_backlight_types() > platform/x86: panasonic-laptop: Use acpi_video_get_backlight_types() > platform/x86: samsung-laptop: Use acpi_video_get_backlight_types() > platform/x86: sony-laptop: Use acpi_video_get_backlight_types() > platform/x86: thinkpad_acpi: Use acpi_video_get_backlight_types() > platform/x86: toshiba_acpi: Use acpi_video_get_backlight_types() > platform/x86: dell-laptop: Use acpi_video_get_backlight_types() > platform/x86: intel_oaktrail: Use acpi_video_get_backlight_types() > ACPI: video: Remove acpi_video_get_backlight_type() > ACPI: video: Fallback to native backlight > > Documentation/gpu/todo.rst | 8 +-- > drivers/acpi/acpi_video.c | 2 +- > drivers/acpi/video_detect.c | 54 ++++++++++--------- > drivers/gpu/drm/i915/display/intel_opregion.c | 3 +- > drivers/platform/loongarch/loongson-laptop.c | 4 +- > drivers/platform/x86/acer-wmi.c | 2 +- > drivers/platform/x86/asus-laptop.c | 2 +- > drivers/platform/x86/asus-wmi.c | 4 +- > drivers/platform/x86/compal-laptop.c | 2 +- > drivers/platform/x86/dell/dell-laptop.c | 2 +- > drivers/platform/x86/eeepc-laptop.c | 2 +- > drivers/platform/x86/fujitsu-laptop.c | 4 +- > drivers/platform/x86/ideapad-laptop.c | 2 +- > drivers/platform/x86/intel/oaktrail.c | 2 +- > drivers/platform/x86/msi-laptop.c | 2 +- > drivers/platform/x86/msi-wmi.c | 2 +- > .../platform/x86/nvidia-wmi-ec-backlight.c | 2 +- > drivers/platform/x86/panasonic-laptop.c | 2 +- > drivers/platform/x86/samsung-laptop.c | 2 +- > drivers/platform/x86/sony-laptop.c | 2 +- > drivers/platform/x86/thinkpad_acpi.c | 4 +- > drivers/platform/x86/toshiba_acpi.c | 2 +- > drivers/video/backlight/backlight.c | 18 +++++++ > include/acpi/video.h | 21 ++++---- > include/linux/backlight.h | 1 + > 25 files changed, 85 insertions(+), 66 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center