Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e5d65c14-b1a3-7f30-e8db-9e292f576f45@huawei.com>
Date:   Mon, 24 Oct 2022 19:27:18 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH -next] init/main: Use strtobool for param parsing in
 set_debug_rodata()
To:     Mark Rutland <mark.rutland@arm.com>
CC:     <linux-kernel@vger.kernel.org>, <will@kernel.org>,
        <ardb@kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        <wangkefeng.wang@huawei.com>, Guohanjun <guohanjun@huawei.com>
References: <20221024093817.3003291-1-tongtiangen@huawei.com>
 <Y1ZwaYLckR8/IDh5@FVFF77S0Q05N>
From:   Tong Tiangen <tongtiangen@huawei.com>
In-Reply-To: <Y1ZwaYLckR8/IDh5@FVFF77S0Q05N>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2022/10/24 19:00, Mark Rutland 写道:
> On Mon, Oct 24, 2022 at 09:38:17AM +0000, Tong Tiangen wrote:
>> Aftern parsing "full", we can still use strtobool rather than "on" and
>> "off" parsing in set_debug_rodata().
>>
>> Fixes: 2e8cff0a0eee ("arm64: fix rodata=full")
> 
> Why do you think this is a fix; what do you believe is broken?
> 
> As noted in the commit message for 2e8cff0a0eee, we *deliberately* don't use
> strtobool() here so that we don't accept garbage values like "ful".
> 
> NAK to this patch as it stands.
> 
> Thanks,
> Mark.

Hi Mark:

Ok, missing that.

Thanks,
Tong.

> 
>> Signed-off-by: Tong Tiangen <tongtiangen@huawei.com>
>> ---
>>   init/main.c | 8 +-------
>>   1 file changed, 1 insertion(+), 7 deletions(-)
>>
>> diff --git a/init/main.c b/init/main.c
>> index aa21add5f7c5..f420e20b1fa3 100644
>> --- a/init/main.c
>> +++ b/init/main.c
>> @@ -1463,13 +1463,7 @@ static int __init set_debug_rodata(char *str)
>>   	if (arch_parse_debug_rodata(str))
>>   		return 0;
>>   
>> -	if (str && !strcmp(str, "on"))
>> -		rodata_enabled = true;
>> -	else if (str && !strcmp(str, "off"))
>> -		rodata_enabled = false;
>> -	else
>> -		pr_warn("Invalid option string for rodata: '%s'\n", str);
>> -	return 0;
>> +	return strtobool(str, &rodata_enabled);
>>   }
>>   early_param("rodata", set_debug_rodata);
>>   #endif
>> -- 
>> 2.25.1
>>
> 
> .