Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp6793687rwi; Mon, 24 Oct 2022 06:15:57 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5oLPbagmfAs78uoDFwY9lrhIqy42xhYE7w5cLbVsvfLIpYYeChGn9HLj/+lb1AKUEKV/Q6 X-Received: by 2002:a05:6402:90b:b0:45c:16a0:ec1e with SMTP id g11-20020a056402090b00b0045c16a0ec1emr31644549edz.427.1666617357024; Mon, 24 Oct 2022 06:15:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666617357; cv=none; d=google.com; s=arc-20160816; b=QmOtcZLCxJBJ/1wZKORcLJEYXsxeC8RWulH9WRiysdq0jgi+4W/vypTx/ZvdLEV2SN pVE/gcHEpVCq6i++pBqQ8vi3YETdb5ewvyIbn9DusAp5BS9O0L8ac7K1rq6P92lTUBc1 JcGEwAFPgW4ehajaCAcXQwiLEzZ5peWLpTARwHx/DQ1ZXUraw/RzivM9TNFaR/LXkX3q bCzf5WaxJu44B3qj8T6Oe0uiLMsac1kKrEg+58g86iCxQ8QYjzeHNow+TAjf5vpCSJP5 mtRQ8xcmV0aSy/FtgbsaERWtN5+PkiMfjzPSLIGlJ5S3FSJ4MuvX86eH/6Ra28WhuVIU 2ypg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=AjqEfNE8rwYg4kdwNc0mIjvzNIaxsQeuYdOvzNZuXe0=; b=ebveZc7kGggi8aYK/mJSmpYQMWLdF0HK6uJJ9D5nNfbBulL2U47oPMfTfaWV8em3+k oXS5YGwWQe4gyaLZ1QBxn7t6bQh2pI1x1oEf1pkBWXjRxIBjM2dQjhZXAU9mFAUfFpzj yaoA/jHRKMRZDYOHNvMshjpW+lqhpWoLV2ccPiePHyrz43Xk5uK97OQ+eNP9J02HZwnV E/1bwVa5lp+Z78/ZuWjmzJc/ggzk+kL31DrRg7HACkJah3YcjHGjCWF/J3kaY5heZIjn zH5ZIcli5/O3J5+zK3ay7hF0W168enah8jRcYPfSa6JaRqHA5y/GFJmqfD1ZfsuZtAwO fpFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="A3/h6DPL"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id wu13-20020a170906eecd00b0078db6f56d51si30103984ejb.808.2022.10.24.06.15.29; Mon, 24 Oct 2022 06:15:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="A3/h6DPL"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232873AbiJXMNH (ORCPT + 99 others); Mon, 24 Oct 2022 08:13:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232876AbiJXMMV (ORCPT ); Mon, 24 Oct 2022 08:12:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2ACBDBF5D; Mon, 24 Oct 2022 04:54:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A5CE4612D6; Mon, 24 Oct 2022 11:53:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6A62C433C1; Mon, 24 Oct 2022 11:53:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666612397; bh=zsc+NPBNRssYvuCi2pIfNAVP01gepb+7Au+cEg+X6mA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=A3/h6DPLc39DykkVOxjTecXz2RDh3s/JDgkSAmmyhS3z9BrJp9SHJerkmxde/cS9B CglmrnH3MN/JvCsmI5DOQQJmhcUBpwtTzx8UW5AZbg0nyGYIk8jCFw1GLGm25Y2+yE +PGyDTd9C9cmh44V3Dne7zz30HsLipBPekK72lDY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andrew Gaul , Jakub Kicinski , Sasha Levin Subject: [PATCH 4.14 183/210] r8152: Rate limit overflow messages Date: Mon, 24 Oct 2022 13:31:40 +0200 Message-Id: <20221024113002.896969208@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024112956.797777597@linuxfoundation.org> References: <20221024112956.797777597@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andrew Gaul [ Upstream commit 93e2be344a7db169b7119de21ac1bf253b8c6907 ] My system shows almost 10 million of these messages over a 24-hour period which pollutes my logs. Signed-off-by: Andrew Gaul Link: https://lore.kernel.org/r/20221002034128.2026653-1-gaul@google.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/usb/r8152.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index a5a4fef09b93..1ed358d0da84 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -1382,7 +1382,9 @@ static void intr_callback(struct urb *urb) "Stop submitting intr, status %d\n", status); return; case -EOVERFLOW: - netif_info(tp, intr, tp->netdev, "intr status -EOVERFLOW\n"); + if (net_ratelimit()) + netif_info(tp, intr, tp->netdev, + "intr status -EOVERFLOW\n"); goto resubmit; /* -EPIPE: should clear the halt */ default: -- 2.35.1