Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp6870637rwi; Mon, 24 Oct 2022 07:07:27 -0700 (PDT) X-Google-Smtp-Source: AMsMyM76HbLhgsBGGwcKA4JPHjFoqIUuDIXeg/vegK+ztFLy08f8aOFgllsupfqvJjZessPxXP/U X-Received: by 2002:a17:906:fe45:b0:788:15a5:7495 with SMTP id wz5-20020a170906fe4500b0078815a57495mr28147190ejb.633.1666620447581; Mon, 24 Oct 2022 07:07:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666620447; cv=none; d=google.com; s=arc-20160816; b=xHNepHRqmEkn53UB01yaNiEC4F+qMYrCO4qjvoUk0/gQN7afkyGfxHKcHtFgpHJjpn gs5vZNnx0Sb2oav13rgB7LmdC0o5nYYLKUP+yMaZC1deAs5yUXZzkhcm68lGHjBKL+nw jTrZjPwBd/3o0YjaqrOKYD4kSeVkukIKWJVmfKuh78unTEtp/6dsSnZC6x3pyTTJAlxW R82Y3C2qSyxA14sUvwrhZW5ieCSt48ME5jHbeur0EG4bj2OF/qYePuuj1NsF39xu1s7/ 3JLkqyfgL1faztx/FNQoS/bhwO97zf64kKJUvU8rYv/sLH7wQaeK+82dDWkmpQz4AvXO SgYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=ObDhDtOp6AhrQXdu2sbBNldO1/0bBKr0Gs2QCZXTg6U=; b=dXPWne6025pojUcubake3HBD0KNl2zh4jvxvCZ8wAx/pe1jmpJlOO++gtsF7PIN+vo Apn4eNJAz8KbGAqY7TDNh2WbY7yrRA31sL/PuPCmhe94dPXhVO/Lgd45hub0F7GZ1JMb h0W9zMMmPP3VSqF4/AIRiqaf8CdW2reVhKGhigwg96JatvGhcgF/4Zhbe0JepCx7x78G wS4WS9OIrQt/2xv3SZEd69Kl8Ci29QlP5nvJS17m2kvUowiZ8GH5Yx62GeL3KLi7gP+i ueKSMp8bCQisVW4caCUz2KYaH6teSxyuuNCiUu6lKOr93OaE2BqjXWoeicrADQJcOrzp EjxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=dmWZYRFA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w5-20020a50c445000000b00461701dab0csi7754523edf.526.2022.10.24.07.07.02; Mon, 24 Oct 2022 07:07:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=dmWZYRFA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234090AbiJXMdx (ORCPT + 99 others); Mon, 24 Oct 2022 08:33:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234140AbiJXM3Y (ORCPT ); Mon, 24 Oct 2022 08:29:24 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA0ED13F8F; Mon, 24 Oct 2022 05:03:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666613003; x=1698149003; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=CfmKsPPFEZz3JYfcGzvUpUe5DGAdjt5IdWHUUS6XAEs=; b=dmWZYRFA91f6Ed2pGUxy8ykbOWmOEk7oyxmtZEGToGJX7N6oCdh01SwU RU++LYZ3H7nn/rfUBvUp3n4MIBcTS9XBxeknyfQYwiD9FRT8dkfMOPf9C NJY7taDADtXIc1Y1fpdOsWpYAkpcvo/ocThsvoZVZrpZk5nBvo3a1xu1Z LRRL++tix6RmgTGQBwh2gXW+KRyDtIurTfQ0IYurR70v9dhlNrB9axGNi enTJnD/Ug9zhCMKGYTtchYBs34JHisP07s8zHxzfY+PTzqZjPAbUJpPgT dZ1qkMQilZlMDg5hlseGWpkejtooGpK4yKJONeMtkIbEm/t94GxlF1n3k A==; X-IronPort-AV: E=McAfee;i="6500,9779,10509"; a="305008264" X-IronPort-AV: E=Sophos;i="5.95,209,1661842800"; d="scan'208";a="305008264" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2022 05:00:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10509"; a="633684800" X-IronPort-AV: E=Sophos;i="5.95,209,1661842800"; d="scan'208";a="633684800" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga007.fm.intel.com with ESMTP; 24 Oct 2022 05:00:31 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1omw84-001QQC-1P; Mon, 24 Oct 2022 15:00:28 +0300 Date: Mon, 24 Oct 2022 15:00:28 +0300 From: Andy Shevchenko To: Dongliang Mu Cc: Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chris Packham , Damien Le Moal , Wolfram Sang , Michael Ellerman , Cai Huoqing , Christophe Leroy , Gerhard Sittig , Anatolij Gustschin , Mark Brown , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] can: mscan: mpc5xxx: fix error handling code in mpc5xxx_can_probe Message-ID: References: <20221024114810.732168-1-dzm91@hust.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221024114810.732168-1-dzm91@hust.edu.cn> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 24, 2022 at 07:48:07PM +0800, Dongliang Mu wrote: > The commit 1149108e2fbf ("can: mscan: improve clock API use > ") only adds put_clock in mpc5xxx_can_remove function, forgetting to add Strange indentation. Why the '")' part can't be on the previous line? > put_clock in the error handling code. > > Fix this bug by adding put_clock in the error handling code. -- With Best Regards, Andy Shevchenko