Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Niklas Cassel <Niklas.Cassel@wdc.com>
To:     John Garry <john.garry@huawei.com>
CC:     Damien Le Moal <damien.lemoal@opensource.wdc.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "jinpu.wang@cloud.ionos.com" <jinpu.wang@cloud.ionos.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Linuxarm <linuxarm@huawei.com>,
        yangxingui <yangxingui@huawei.com>,
        yanaijie <yanaijie@huawei.com>
Subject: Re: [PATCH v5 0/7] libsas and drivers: NCQ error handling
Thread-Topic: [PATCH v5 0/7] libsas and drivers: NCQ error handling
Thread-Index: AQHY1/ID0O3xyFitDU+9c+6EHqQqRa3+RKaAgAE7cQCAANLyAIAAAgSAgAAKBoCAAAiJAIAApReAgABn/oCAACBvAIAcAj2A
Date:   Mon, 24 Oct 2022 12:24:57 +0000
Message-ID: <Y1aEGW2BtdIRJy7s@x1-carbon>
References: <YzwvpUUftX6Ziurt@x1-carbon>
 <cfa52b91-db81-a179-76c2-8a61266c099d@huawei.com>
 <27148ec5-d1ae-d9a2-1b00-a4c34d2da198@huawei.com>
 <Yz33FGwd3YvQUAqT@x1-carbon>
 <5db6a7bc-dfeb-76e1-6899-7041daa934cf@opensource.wdc.com>
 <Yz4BLTPkXqyjW4a4@x1-carbon>
 <64ab35a7-f1ff-92ee-890e-89a5aee935a4@opensource.wdc.com>
 <f190f19e-34b2-611c-1cf4-f8f34d12fe74@huawei.com>
 <Yz7qD+gpmI1bdw16@x1-carbon>
 <bc7d74dc-5aaa-1ad3-626f-df89955b1380@huawei.com>
In-Reply-To: <bc7d74dc-5aaa-1ad3-626f-df89955b1380@huawei.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0Z+OBR5XZkoi+4d9Rb2z6FJC8uTW2hB9OAx3BF8MoQy5FsW1JNTpY7NgeMAn?=
 =?us-ascii?Q?zyaRx1zCtZDdPuN8sWDJWbBV5KEgR2D11QqVcYhjZhXQEAsHmryMSe9wSe3l?=
 =?us-ascii?Q?1m0RtWSMeIEmDam7IzPDf5maIZC16NF0jQ3JIaYu5nD17RM8j1SOK9/wBy0Y?=
 =?us-ascii?Q?XKbX+kfYCzEevPSwbVdXJL7Jea/eUVZD5ErQ7+cbT2ckajvgZAkOZxCkGza8?=
 =?us-ascii?Q?+PdWelTmLPIbm2qZOTR+5RMHT3pYKcoDYQ/Bw0+JEHIbuBGmoa4olyHwQ40L?=
 =?us-ascii?Q?yg6yPW9aDef2Ynj2GMKO9oaGVVBGpfinEPk2E+fjf8hRn5crS1U3mjilLt/Z?=
 =?us-ascii?Q?fzVHYXmBvYbQuC5qtjvCTVxSU7zdpqpCwgl4swYYEK0k8SMmgsInRkgrb1Sj?=
 =?us-ascii?Q?dk80wu6Ejj9c1quR7EB5CXrpmpsYXpMV0J/edzfsifb9kGufON15q6apw3Kb?=
 =?us-ascii?Q?oKKZ+pgVD43TlvHlPNz0xAaK2dxghFjyVC0cJQZpVWFunIPSmPkt4cWwFWLD?=
 =?us-ascii?Q?u9SWTpmM1eenTkKpF54RICXWRdsveR4weTqqNDL8CRY/e9Xysep58jlW/5FU?=
 =?us-ascii?Q?A4A7HDHbc+AXC0dZ3rJ073XIb7PCTc4Un6XbH/IFXiuvWlxkJnZuuSxX4OSu?=
 =?us-ascii?Q?VCSZsN83L2kFafQKS3eUiEX5owDQzgfUEFD9F1a16/0S7q0SMOtoZc0oQ4pJ?=
 =?us-ascii?Q?JIVfPycdAUVPU4yvpoLeedwnuZq9AJkDZFMncUz0haQF8bJYR6yhvHUtY2S0?=
 =?us-ascii?Q?xdDUXE5w81XTTCEVpgIFnndEFR6ZDSWfx7TRJL8UHcmqGnMdWtpb+9SSBPLh?=
 =?us-ascii?Q?jZjD1x9cQOT//Kk2nrDqmEre4TY+1lL4ruTvi8jk+Ey11Ofenl3dc8ZkuZwX?=
 =?us-ascii?Q?n8HHUBf1zBYaQ5fn2lX/TNQjEAkIcVQ2c2SRDyYN29YcitXeFygEuT/h0vPX?=
 =?us-ascii?Q?UFmhzaGs+HhCuKEaIBZh0ugvyI1yEfvdWHQ0Xs4H8Cu7vU2sFyr1j4B96jJQ?=
 =?us-ascii?Q?7ALG1t9rt2mH3BmLIx+iYqo5kUxSwKFWq3F7/mGrG4iPZuwY8bW/aqU0GKtK?=
 =?us-ascii?Q?ax+NMo5DLjK4IsfYCbL9KhTvAeuBPb7L6KHbpsU4N/bx1NNYpS3iAwSyRFeM?=
 =?us-ascii?Q?5PKo64FKGBHoyOW+2QXmLhO8tc4qp1VmRGILBt/gcgsjuTqvXuxV2afhvE6l?=
 =?us-ascii?Q?UpXiDH1l8C2aPkW+Hk1HWxV+IGag3rIhL74xJUDq93vKCYulPHZ4+mEA0j7M?=
 =?us-ascii?Q?EVkBxGnP8Qgoc+hTVrOUWzh0yjGU9MZUh7/Rf5v5pOfk2qNW8GETtd6U2SDP?=
 =?us-ascii?Q?Gc7DEV7ihKnq7pU5NZ3tVohFehPN40kHbUMaQOgNrBO2+W9BKpGbp2lZ3Lv0?=
 =?us-ascii?Q?e+jgds4qX2dxvT72OOSr6H85mXGIpuFQrY/UYOF1E5AD4zSJwxX/ffLxmtrA?=
 =?us-ascii?Q?+osbnAdWbD1znxM8XVfXtoJkOESjXKzvDM+A4cft5VHtleUe1DXF9gd7ya/O?=
 =?us-ascii?Q?QnjBKQo0Ed7R5i+77IuYlDT2JuOumSbwiashnVUWQpSM+eRiUWPAe8hxE/Bu?=
 =?us-ascii?Q?z7mdnmE2L5+9qBGtAJlSqIAQPyMp0xWIyiEt102D8kpEbnwZ/AP7NmbdBb3S?=
 =?us-ascii?Q?ow=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <CD5D06FF7D1F7D45AD2B1371D8DA180C@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR04MB6272.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 54f5c034-1c49-4dbd-b3db-08dab5bac3d2
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Oct 2022 12:24:57.9944
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xOsSj3LLWaiRw02ghQqLOmki8dt1si4GFfCao9d90wgg2NJp2mgEsH24/pRgc1RLxXHzyid1PHFUrYpcvIC6HA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR0401MB3562
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 06, 2022 at 05:41:40PM +0100, John Garry wrote:
> > > >=20
> > > Yeah, it just looks to be the longstanding issue of using this card o=
n my
> > > arm64 machine - that is that I get IO timeouts quite regularly. I sho=
uld
> > > have mentioned that yesterday. This just seems to be a driver issue.
> > Out of curiosity, which arm64 SoC is this?
>=20
> HiSilicon hi1620 which contains a custom arm v8 implementation. Note that
> others have also seen the issue with this card on other arm implementatio=
ns.
>=20
> >=20
> > While it is very unlikely that this is your problem, but I've encounter=
ed
> > an issue on an ARM board before, where the PCIe controller was incorrec=
tly
> > configured in device tree, causing the controller to miss interrrupts,
> > which presented itself to the user as timeouts in the WiFi driver:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/comm=
it/?id=3D97131f85c08e024df49480ed499aae8fb754067f
>=20
> Unlikely. Indeed, when I was checking this issue some time go, I found th=
at
> not only was there no completion interrupt but also no completion when I
> manually examine the completion ring buffer read and write pointers.
>=20
> Here's where I discuss this issue earlier a bit:
> https://lore.kernel.org/linux-scsi/PH0PR11MB511238B8FF7B44C375DDDFADEC519=
@PH0PR11MB5112.namprd11.prod.outlook.com/
>=20

Hello John,

For the record, I tested the pm80xx driver on a HoneyComb LX2 board
(an arm64 board using ACPI).

I tried v6.1-rc1 both with and without your series in $subject.

I couldn't see any issues.


What I tried:
-Running fio:
fio --name=3Dtest --filename=3D/dev/sdc --ioengine=3Dio_uring --rw=3Drandrw=
 --direct=3D1 --iodepth=3D32 --bs=3D1M
on three different HDDs simultaneously for 15+ minutes,
without any errors in fio or dmesg.

-Creating and mounting a btrfs volume, doing a huge dd to the filesystem
without issues.

-sg_sat_read_gplog -d --log=3D0x10 /dev/sda
which successfully returned the log.


It is worth mentioning that this arm64 board has reserved memory regions,
but does not yet have a firmware that supplies a IORT RMR (reserved memory
regions) revision E.d node, which means that in order to get this board to
boot successfully, we need to supply:
"arm-smmu.disable_bypass=3D0 iommu.passthrough=3D1"
on the kernel command line.

It could be worth trying the same on your arm64 machine, to see that also
makes the pm80xx driver play nice for you.


Kind regards,
Niklas=