Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221024115429.1343257-1-heiko.thiery@gmail.com> <20221024122659.2krt2hh2sdvxuurn@pengutronix.de>
In-Reply-To: <20221024122659.2krt2hh2sdvxuurn@pengutronix.de>
From:   Heiko Thiery <heiko.thiery@gmail.com>
Date:   Mon, 24 Oct 2022 14:52:46 +0200
Message-ID: <CAEyMn7Y9uxeFLM7-6jR=bonusdwjX=ukRotZm=7x_3QyxVW-DQ@mail.gmail.com>
Subject: Re: [PATCH v3] arm64: dts: imx8mq-kontron-pitx-imx8m: remove
 off-on-delay-us for regulator-usdhc2-vmmc
To:     Marco Felsch <m.felsch@pengutronix.de>
Cc:     devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Marco,

Am Mo., 24. Okt. 2022 um 14:34 Uhr schrieb Marco Felsch
<m.felsch@pengutronix.de>:
>
> Hi Heiko,
>
> On 22-10-24, Heiko Thiery wrote:
> > With that delay U-Boot is not able to store the environment variables in
> > the SD card. Since the delay is not required it can be remove.
>
> Now I'm curious, since this doesn't tell us the why, it just tell us
> about the end result. I'm asking because the NXP EVKs have an issue with
> the sd-card power line capacity and we need this delay to reach a level
> which is marked as low within the sd-spec.

I must admit that I do not know at all why this entry was made. I have
now looked at the dtbs of the imx8 EVKs and except for imx8dxl-evk.dts
I see no delay here.

-- 
Heiko

> Regards,
>   Marco
>
>
> > Fixes: 5dbadc848259 (arm64: dts: fsl: add support for Kontron pitx-imx8m board)
> >
> > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> > ---
> > v3:
> >  - Improve commit message and explain why it is a fix (thanks to Fabio)
> >
> > v2:
> >  - add Fixes tag
> >
> >  arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
> > index a91c136797f6..21442e04a632 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
> > @@ -51,7 +51,6 @@ reg_usdhc2_vmmc: regulator-usdhc2-vmmc {
> >               regulator-min-microvolt = <3300000>;
> >               regulator-max-microvolt = <3300000>;
> >               gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
> > -             off-on-delay-us = <20000>;
> >               enable-active-high;
> >       };
> >  };
> > --
> > 2.30.2
> >
> >