Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f4e4c09b-9426-eede-a83c-8c55f6dc7d2d@huawei.com>
Date:   Mon, 24 Oct 2022 20:50:17 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v4] scsi:iscsi: Fix multiple iscsi session unbind event
 sent to userspace
Content-Language: en-US
To:     Mike Christie <michael.christie@oracle.com>,
        Lee Duncan <lduncan@suse.com>, Chris Leech <cleech@redhat.com>,
        "James E . J . Bottomley" <jejb@linux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC:     Steffen Maier <maier@linux.ibm.com>, <liuzhiqiang26@huawei.com>,
        <linfeilong@huawei.com>
References: <20221021235754.1968981-1-haowenchao@huawei.com>
 <daa60cf0-0dde-ea2d-211a-70a9e0efc1b8@oracle.com>
 <2adeb439-646b-ebb1-b266-c3ed4750eac2@huawei.com>
 <64689ca9-62eb-27e1-63df-e2e8c1a59cbb@oracle.com>
From:   Wenchao Hao <haowenchao@huawei.com>
In-Reply-To: <64689ca9-62eb-27e1-63df-e2e8c1a59cbb@oracle.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2022/10/23 11:21, Mike Christie wrote:
>> I have some wonder about the target_id like be2iscsi which allocated from 
>> iscsi_sess_ida. Should not we get the target_id from iSCSI target?
>> If they allocate target_id with an random value, how to handle the
>> iscsi_user_scan_session which would check the session's target_id.
>>
> For iscsi, that target id is only a number that's used on the initiator side
> to track the target. The target has no idea what it is and it's never
> sent/used/passed to the target.
> 
> For example, the qla4xxx driver uses it to lookup persistent target info it
> has stored on it's flash. The other use is that we need a unique name for
> the target in sysfs and that target id is used as part of that name.
> .

Thanks for your answer, I would update this patch and open-iscsi's PR.