Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp6962040rwi; Mon, 24 Oct 2022 08:10:27 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6uEQP0pW5eHlD49pxWBEw4dMP6Pe97C7kLsqD6gp6tdR+1R6SEGMGPSx03qlFi1GW1QxA5 X-Received: by 2002:a17:906:8a64:b0:78d:b00d:fe with SMTP id hy4-20020a1709068a6400b0078db00d00femr28744628ejc.32.1666624213444; Mon, 24 Oct 2022 08:10:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666624213; cv=none; d=google.com; s=arc-20160816; b=tNJwqPGENhJ+OnUs65CTLum5ZmYl9J4uuadDKxpj9fIyutOsRmnpf2EvKADZDWQaxT O+BkFK2WVgrEVfZVacWg1gf9/VaUR8yPy2gr0enSHY9mkKbu+9oNhHRmQ0nXX/pvYnGJ cpLUEvik46+++84sV3Adzjlu1a7DNgljbZF+FrUAJaWxqJKhoV970inUHeB1AX4kFEIl VtqSAHkF5wXj/7f7ZP9I1Z7rJ1AV79hZcC/fVMJk9srBRiA5VH40fL7CVm1vTjzkvhpn B01F92yf0tlpjXGJVqYqRUyS7n9yR/Q+ZXFG2sXzRGYsHcvUXp7ISQjc9KEeLSOJMFFh 0L3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=kAy4NrkKR2QiHW/iYdPqZ67JivxqMxR6zRtn6zBBxY0=; b=HXAquWQIGRBCoO3SiIMSZWMvY4AkcRf9g11R03HckCiViTn3cwpj0uK+d1iPhGLBlo 9nm9VIneGZspu9xVZ7vh43D99FbRPIDVdOM5ZeUL/B/LcmxFkjQ/9kxX+fFCzg7WLZe2 8TRq4bLTCUptT0KHF1wjB7Ezlu4VlpV9AzbFEhAl6/QvJfaOKFfL+4dMfbSWAale53PM SAhnkyjltaXR4srqB7q6LUBkwwgaoxxoFwmNLZJjzJ/Vf+3u/p3Y3oVin3PHgPjJoG0b jSpbXQqwuDXs+S7OKVh14S0zezZRxNYgToJqTUJGaX8CPm6SnGP31u0FErypnRL9ErLc lykw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Dk9KlCHg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e28-20020a170906845c00b007417e9a2c71si5419ejy.352.2022.10.24.08.09.47; Mon, 24 Oct 2022 08:10:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Dk9KlCHg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236303AbiJXNng (ORCPT + 99 others); Mon, 24 Oct 2022 09:43:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236814AbiJXNlT (ORCPT ); Mon, 24 Oct 2022 09:41:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABDAD8993C; Mon, 24 Oct 2022 05:38:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1B1D36132D; Mon, 24 Oct 2022 12:35:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B8DBC433D7; Mon, 24 Oct 2022 12:35:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666614952; bh=pz2UwXMRKNrNA4L+NtDLBqs3w52XvYBv/P4Jt38nelM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Dk9KlCHgT14bpPFh5t1cw9QJ+NF/0r6PElNihq7j8NNPVCvpe4FxwacxEI+YB3Jct EMVGIA25AnW4Ze0UioKJXPRAoXtTkqC7AeMdAondf8HZOjIGO1aaSjpeg3Yn3x4KqW FtpwNB6I6z9wc306HNoN0vPvpNYKoZlpH9FY64oc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Liang He , Mengda Chen , Guenter Roeck Subject: [PATCH 5.15 035/530] hwmon: (gsc-hwmon) Call of_node_get() before of_find_xxx API Date: Mon, 24 Oct 2022 13:26:19 +0200 Message-Id: <20221024113046.592040234@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113044.976326639@linuxfoundation.org> References: <20221024113044.976326639@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Liang He commit 7f62cf781e6567d59c8935dc8c6068ce2bb904b7 upstream. In gsc_hwmon_get_devtree_pdata(), we should call of_node_get() before the of_find_compatible_node() which will automatically call of_node_put() for the 'from' argument. Fixes: 3bce5377ef66 ("hwmon: Add Gateworks System Controller support") Signed-off-by: Liang He Co-developed-by: Mengda Chen Signed-off-by: Mengda Chen Link: https://lore.kernel.org/r/20220916154708.3084515-1-chenmengda2009@163.com Cc: stable@vger.kernel.org Signed-off-by: Guenter Roeck Signed-off-by: Greg Kroah-Hartman --- drivers/hwmon/gsc-hwmon.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/hwmon/gsc-hwmon.c +++ b/drivers/hwmon/gsc-hwmon.c @@ -267,6 +267,7 @@ gsc_hwmon_get_devtree_pdata(struct devic pdata->nchannels = nchannels; /* fan controller base address */ + of_node_get(dev->parent->of_node); fan = of_find_compatible_node(dev->parent->of_node, NULL, "gw,gsc-fan"); if (fan && of_property_read_u32(fan, "reg", &pdata->fan_base)) { dev_err(dev, "fan node without base\n");